My health regeneration code is stopping my gameplay section and goes on an infinite loop. + Dissapearing text

Author

Message

My games are free

14

Years of Service

User Offline

Joined: 28th Sep 2009

Location: Under your Bed

Posted: 19th Feb 2012 23:52

Link

I cant explain it very good but, I have the code for the first level (or at least start for it) and i made an health regenerate thing for my game. the problem is that when i run the code, it first begins as it should, but then it goes to the health regeneration code. what im asking is to get the HPReg. code to be "invisible" throughout the game it only should regenerate health. And i have.
code for the 1st map

+ Code Snippet

health = 100
maxhealth = 100
world1:
print "HP "; health ; "/"; maxhealth
print "My text"
   if health < maxhealth    
    goto inchealth
endif

and heres my health reg. code

+ Code Snippet

inchealth:
   if health =< maxhealth
   do
   cls
   print "HP "; health ; "/"; maxhealth
   inc health,1
   wait 5000
      if health => maxhealth then health = maxhealth
      return

      loop
   endif
   if health = nohealth
      do
      cls 
         Print "Game over. Press any key to continue"
      loop
  endif
  return

it never gets back to my game

and the other problem is that when i add for example a cube in my map
every text disappears and is not to be seen

+ Code Snippet

print "I wont be seen because of that dang cube"
make object cube 1,100
wait key

Back to top

Profile PM Email

The Weeping Corpse

12

Years of Service

User Offline

Joined: 19th Sep 2011

Location: United Kingdom

Posted: 20th Feb 2012 06:17

Link

goto inchealth

should be

gosub inchealth

and the value of nohealth needs to be specified. so,

health = 100
maxhealth = 100
nohealth = 0

Back to top

Profile PM Email

My games are free

14

Years of Service

User Offline

Joined: 28th Sep 2009

Location: Under your Bed

Posted: 20th Feb 2012 08:07 Edited at: 20th Feb 2012 08:12

Link

i had it at first as gosub inchealth and i actually had exactly "nohealth = 0" in my previous code, ill try it again, thanks more ideas are accepted

Back to top

Profile PM Email

Hodgey

14

Years of Service

User Offline

Joined: 10th Oct 2009

Location: Australia

Posted: 20th Feb 2012 11:25

Link

I think you may need to restructure your program. A lot of programmers adopt the practice of having a main loop, typically a do-loop and then have most events inside that loop.

E.g

+ Code Snippet

do
    if health < maxhealth
        gosub inchealth
    endif
    sync
loop

inchealth:
    if Timer() - OldTime > 5000
        inc health, 1
        OldTime = Timer()
    endif

    text 0, 0, "Health: " + str$(health) + "/" + str$(maxhealth)
return

Quote: "and the other problem is that when i add for example a cube in my map
every text disappears and is not to be seen"

The TEXT command may be a better choice.

+ Code Snippet

sync on : sync rate 60
make object cube 1,100
do
   text 0, 0, "This will appear"
   sync
loop

Back to top

Profile PM Email

My games are free

14

Years of Service

User Offline

Joined: 28th Sep 2009

Location: Under your Bed

Posted: 20th Feb 2012 14:19

Link

Hodgey: your code was almost perfect, but when i run it, it starts counting the numbers but the system starts putting numbers on top of each other like if theres a -10 from the starting health, it goes 90-91-92 and all numbers go above each other. i made a slight change to make it go normally.

+ Code Snippet

inchealth:
    if Timer() - OldTime > 5000
        inc health, 1
        cls
        OldTime = Timer()
    endif

    text 0, 0, "Health: " + str$(health) + "/" + str$(maxhealth)
return

another problem comes in, now i cant see the "Health 100/100" text until health is under 100
and along that, i am back to the infinite loop of health regen.

Back to top

Profile PM Email

MrValentine

AGK Backer

13

Years of Service

User Offline

Joined: 5th Dec 2010

Playing: FFVII

Posted: 20th Feb 2012 20:28

Link

Think your best placing text at something other than 0,0... try 30,30

Back to top

Profile PM

Hodgey

14

Years of Service

User Offline

Joined: 10th Oct 2009

Location: Australia

Posted: 20th Feb 2012 20:50

Link

Quote: "it starts counting the numbers but the system starts putting numbers on top of each other"

The text command is independent of the print command and so overlapping text is easy to come across. Simply change the coordinates used each time you use TEXT.

Quote: "another problem comes in, now i cant see the "Health 100/100" text until health is under 100"

Try moving the text line from the sub routine to inside the do-loop.

Back to top

Profile PM Email

My games are free

14

Years of Service

User Offline

Joined: 28th Sep 2009

Location: Under your Bed

Posted: 20th Feb 2012 21:31 Edited at: 20th Feb 2012 22:16

Link

Hodgey:

Quote: "Quote: "it starts counting the numbers but the system starts putting numbers on top of each other"
The text command is independent of the print command and so overlapping text is easy to come across. Simply change the coordinates used each time you use TEXT."

i told this in previous post but i already got it work by adding a cls in middle of it. And i meant that when it regenerates health it overlaps previous numbers.

Quote: "Quote: "another problem comes in, now i cant see the "Health 100/100" text until health is under 100"
Try moving the text line from the sub routine to inside the do-loop."

This worked, thanks man, but im still in the inf. loop

EDIT: almost forgot this, my fix on your code doesnt work as it clears everything from screen...

Back to top

Profile PM Email

nonZero

12

Years of Service

User Offline

Joined: 10th Jul 2011

Location: Dark Empire HQ, Otherworld, Silent Hill

Posted: 21st Feb 2012 09:51 Edited at: 21st Feb 2012 09:54

Link

I'm not supposed to be here, I have a project to do (and an angry friend if he catches me slacking). I promised I'd just lurk to stay abreast of things until I was finished my project and the stuff I'm helping my mate with yet here I am...

Oh well, couldn't resist...

1) Hodgey's code is perfect. There are no "errors". It's simply not being implemented correctly.
2) Your program gets stuck in a loop because of structuring.

1). Use Hodgey's code but remove all CLS statements from your code and replace all PRINT statements with TEXT. Now use the following code at startup, after setting up your display:

+ Code Snippet

BACKDROP ON: COLOR BACKDROP RGB(0,0,0)
rem Activates 3D mode. Screen is now being constantly refreshed. You can
rem lose SYNC ON and the SYNC statements too and stick this at the beginning instead:
SYNC RATE 60

Before you say "it's all gone black", see number 2

2). Make every call [sub/function] a dynamic one. DO..LOOP in most cases should be avoided in functions/subs. Example:

+ Code Snippet

`Declare vars
   GLOBAL maxhealth = 100
   GLOBAL curhealth = 100
   GLOBAL regentimer = 0

`Setup Display
   SET DISPLAY MODE DESKTOP WIDTH(), DESKTOP HEIGHT(), 32
   SYNC RATE 60
   BACKDROP ON
   COLOR BACKDROP RGB(0,0,0)

`Main Loop
   DO
      `etc, etc
         TEXT 1, 20, "Your health is: " + STR$(curhealth) + "/" + STR$(maxhealth)
         TEXT 1, 60, "KEYS:"
         TEXT 1, 80, "1 = Deplete health to 50%"
         TEXT 1, 100, "Esc = exit"
         IF curhealth < maxhealth: Regen(): ENDIF
         IF curhealth =< 0: EXIT: ENDIF
         IF VAL(INKEY$()) = 1: curhealth = 50: ENDIF
   LOOP

   END

Function Regen()
rem This is what Hodgey was using; a timer for Regeneration.
      IF TIMER() - Regentimer > 100
            INC curhealth
            regentimer = TIMER()
      ENDIF
EndFunction

Dynamic coding makes life easier once the habit is formed. Using 3D screen mode even for text-based things actually BETTER because you'll end up using less statements, especially where PRINT and CLS are concerned so your code becomes neater and more compact and, ultimately, easier for you and the machine to handle.

Hopefully this clarifies it all. Good luck.

Back to top

Profile PM Email Website

My games are free

14

Years of Service

User Offline

Joined: 28th Sep 2009

Location: Under your Bed

Posted: 21st Feb 2012 13:52 Edited at: 21st Feb 2012 13:54

Link

nonzero:
Yea, i just read a subject on program structure and layout (TDKs tutorials) a very big thanks on his work, and to Hodgey i must say sorry for saying your code bad instantly

i really appreciate everyones help. Ill try your code now nonZero. And really big thanks to you for helping me even when you have a project (+ an angry friend, i know the feeling

) sorry for interrupting your work

Back to top

Profile PM Email

My games are free

14

Years of Service

User Offline

Joined: 28th Sep 2009

Location: Under your Bed

Posted: 21st Feb 2012 17:53 Edited at: 23rd Feb 2012 21:40

Link

It still goes overlapping the prev. numbers...

EDIT: sorry, it was my own fail

EDIT: I got it working, thanks everyone for your support. Heres the Code, if you have problems with it, tell me

+ Code Snippet

Sync on: sync rate 30
BACKDROP ON
COLOR BACKDROP RGB(0,0,0)

GLOBAL maxmp = 100
GLOBAL curmp = 100
GLOBAL nomp = 0
GLOBAL mpregentimer = 0
GLOBAL maxhealth = 100
GLOBAL curhealth = 100
GLOBAL regentimer = 0
GLOBAL nohealth = 0

inc curhealth,-50
DO
         TEXT 1, 10, "HP: " + STR$(curhealth) + "/" + STR$(maxhealth)
         IF curhealth < maxhealth: Regen(): ENDIF
         IF curhealth =< 0: EXIT: ENDIF
	sync
LOOP   

DO         
         TEXT 1, 30, "MP: " + STR$(curmp) + "/" + STR$(maxmp)
         IF curmp < maxmp: MPRegen(): ENDIF
         IF curmp =< 0: EXIT: ENDIF
    sync
LOOP
 

Function Regen()
      IF TIMER() - Regentimer > 5000
            INC curhealth
            regentimer = TIMER()
      ENDIF
EndFunction

Function MPRegen()
      IF TIMER() - MPRegentimer > 5000
            INC curmp
            regentimer = TIMER()
      ENDIF
EndFunction

Back to top

Profile PM Email

Sorry your browser is not supported!

Newcomers DBPro Corner / My health regeneration code is stopping my gameplay section and goes on an infinite loop. + Dissapearing text