Need help with Collatz Conjecture Loop

Author

Message

ChristMatt

12

Years of Service

User Offline

Joined: 2nd Apr 2012

Location:

Posted: 2nd Apr 2012 20:07

Link

My friend and I are writing a simple program that lets the user enter a number and the program runs a collatz conjecture on that number and shows each step. For whatever reason, it continues to crash/not run. We don't know if it's the schools crap computers or if there is a problem with our loop/functions. Any input is nice.

+ Code Snippet

// This program solves the collatz conjecture for a number.
// Matthew Yankello and Christian Anderson

#include "DarkGDK.h"

// Prototypes.
void runLoop(int);
void endProgram();

// DarkGDK
void DarkGDK()
{
	// Window title.
	dbSetWindowTitle("Collatz Conjecture.");

	// Receive inputted number.
	dbPrint("This program takes an imputted number from the user");
	dbPrint("and tests it using Collatz Conjecture.");
	dbPrint();
	dbPrint("Please enter a number.");
	int num = atoi(dbInput());
	dbPrint();
	dbPrint("Press any key to initialize test.");
	dbWaitKey();
	dbCLS();

	// Run loop.
	runLoop(num);

	// End program.
	endProgram();
}


void runLoop(int num)
{
	int check;
	while ( num != 1);
	{
		check = num%2;
		if (check = 0)
		{
			num=num/2;
			dbPrint(dbStr(num));
		}
		else
		{
			num=num*3+1;
			dbPrint(dbStr(num));
		}
	}
}

void endProgram()
{
	dbCenterText(dbScreenWidth()/2, dbScreenHeight()/2, "Press any key to end the program.");
	dbWaitKey();
}

Back to top

Profile PM

DeadTomGC

13

Years of Service

User Offline

Joined: 11th Aug 2010

Location: LU

Posted: 3rd Apr 2012 09:04 Edited at: 3rd Apr 2012 09:13

Link

Hmm, well I would usually put "void" in the argument for endprogram when I am defining and declaring it.

What?! Oh, well that might mean something. atoi takes a str but dbInput is VOID!

OK, so you should have something like this:

+ Code Snippet

int num;
dbPrint("This program takes an imputted number from the user");
	dbPrint("and tests it using Collatz Conjecture.");
	dbPrint("");
	dbPrint("");
	dbInput("Please enter a number.",num);
	dbPrint("");
	dbPrint("Press any key to initialize test.");
	dbWaitKey();

Note that dbInput passes int num by reference, so it will be altered by the function.

Have a look at the documentation on your computer if you haven't already. (C:\Program Files (x86)\The Game Creators\Dark GDK\Documentation).

Back to top

Profile PM Email Website

ChristMatt

12

Years of Service

User Offline

Joined: 2nd Apr 2012

Location:

Posted: 3rd Apr 2012 20:05

Link

Quote: "
Hmm, well I would usually put "void" in the argument for endprogram when I am defining and declaring it.

What?! Oh, well that might mean something. atoi takes a str but dbInput is VOID!

OK, so you should have something like this:+ Code Snippet
int num;
dbPrint("This program takes an imputted number from the user");
dbPrint("and tests it using Collatz Conjecture.");
dbPrint("");
dbPrint("");
dbInput("Please enter a number.",num);
dbPrint("");
dbPrint("Press any key to initialize test.");
dbWaitKey();

Note that dbInput passes int num by reference, so it will be altered by the function.

Have a look at the documentation on your computer if you haven't already. (C:\Program Files (x86)\The Game Creators\Dark GDK\Documentation).

"

We tried this but are getting errors now from the dbInput because it doesn't take 2 arguements.

Back to top

Profile PM

matt yankello

12

Years of Service

User Offline

Joined: 3rd Apr 2012

Location:

Posted: 4th Apr 2012 00:48

Link

Quote: "
Hmm, well I would usually put "void" in the argument for endprogram when I am defining and declaring it.

What?! Oh, well that might mean something. atoi takes a str but dbInput is VOID!

OK, so you should have something like this:+ Code Snippet

Note that dbInput passes int num by reference, so it will be altered by the function.

Have a look at the documentation on your computer if you haven't already. (C:\Program Files (x86)\The Game Creators\Dark GDK\Documentation).
"

Hi I am Christmatt's friend that he is talking about. I do not believe that this is the problem, for I tried running the program with the loop and it worked, well it gave the first number. This leads me to believe that the problem is how I set up the loop.

Back to top

Profile PM

DeadTomGC

13

Years of Service

User Offline

Joined: 11th Aug 2010

Location: LU

Posted: 4th Apr 2012 01:47 Edited at: 4th Apr 2012 01:55

Link

well, you could always fix num to see if you're loop works.
Then you'll know where the problem is.

The documentation says that dbInput takes 2 arguments. I've never used it though.

Quote: "Syntax
void dbInput ( char* szStatement, int iInput )
"

BTW, did you mean "without" here?

Quote: "for I tried running the program with the loop and it worked,"

One more thing. In general I don't use commands like atoi because I have had bad experiences with them. built in converters are usually built to crash the program if they receive an invalid input. Instead I make my own converter. I could explain how to do this, but it would kind of be a waste of my time if you don't care.

This isn't an issue though for your code since dbInput handles it.

Back to top

Profile PM Email Website

WickedX

15

Years of Service

User Offline

Joined: 8th Feb 2009

Location: A Mile High

Posted: 4th Apr 2012 02:08 Edited at: 4th Apr 2012 02:22

Link

The problem is in the function itself. Try this, it works for me.

// This program solves the collatz conjecture for a number.
// Matthew Yankello and Christian Anderson

#include "DarkGDK.h"

// Prototypes.
int Collatz(int);
void endProgram();

// DarkGDK
void DarkGDK()
{
	int num;

// Window title.
	dbSetWindowTitle("Collatz Conjecture.");

// Receive inputted number.
	dbPrint("This program takes an input number from the user");
	dbPrint("and tests it using Collatz Conjecture.");
	dbPrint();
	dbPrint("Please enter a number.");
	num = atoi(dbInput());
	dbPrint();
	dbPrint("Press any key to initialize test");
	dbWaitKey();
	dbCLS();

// Run loop.
	Collatz(num);

// End program.
	endProgram();
}
int Collatz(int num)
{
    int length = 1; // how many iterations it takes for this number
    while (num != 1)
    {
	// if you want to see the iterations, simply output n here
        if (num % 2 == 0)
	{
            num /= 2;
	    dbPrint((double)num);
        }
	else
	{
            num = (3*num) + 1;
	    dbPrint((double)num);
        }
	length++;
    }
    return length; // returns the number of iterations
}
void endProgram()
{
    dbCenterText(dbScreenWidth()/2, dbScreenHeight()/2, "Press any key to end the program.");
    dbWaitKey();
}

+ Code Snippet

// This program solves the collatz conjecture for a number.
// Matthew Yankello and Christian Anderson

#include "DarkGDK.h"

// Prototypes.
int Collatz(int);
void endProgram();

// DarkGDK
void DarkGDK()
{
	int num;

	// Window title.
	dbSetWindowTitle("Collatz Conjecture.");

	// Receive inputted number.
	dbPrint("This program takes an input number from the user");
	dbPrint("and tests it using Collatz Conjecture.");
	dbPrint();
	dbPrint("Please enter a number.");
	num = atoi(dbInput());
	dbPrint();
	dbPrint("Press any key to initialize test");
	dbWaitKey();
	dbCLS();

	// Run loop.
	Collatz(num);

	// End program.
	endProgram();
}
int Collatz(int num)
{
    int length = 1; // how many iterations it takes for this number
    while (num != 1)
    {
	// if you want to see the iterations, simply output n here
        if (num % 2 == 0)
	{
            num /= 2;
	    dbPrint((double)num);
        }
	else
	{
            num = (3*num) + 1;
	    dbPrint((double)num);
        }
	length++;
    }
    return length; // returns the number of iterations
}
void endProgram()
{
    dbCenterText(dbScreenWidth()/2, dbScreenHeight()/2, "Press any key to end the program.");
    dbWaitKey();
}

Cheers.

Back to top

Profile PM Email

DeadTomGC

13

Years of Service

User Offline

Joined: 11th Aug 2010

Location: LU

Posted: 4th Apr 2012 02:17 Edited at: 4th Apr 2012 02:23

Link

Quick question, why are you guys even using the Dark GDK?

Ok, so the guy above this post has code that works.

There is a disconnect between the documentation and the actual Dark GDK apparently when it comes to the dbInput command.

Back to top

Profile PM Email Website

WickedX

15

Years of Service

User Offline

Joined: 8th Feb 2009

Location: A Mile High

Posted: 4th Apr 2012 02:32 Edited at: 4th Apr 2012 02:34

Link

Quote: "
There is a disconnect between the documentation and the actual Dark GDK apparently when it comes to the dbInput command.
"

So what's new? That's why I use IntelliSense.

Back to top

Profile PM Email

ChristMatt

12

Years of Service

User Offline

Joined: 2nd Apr 2012

Location:

Posted: 4th Apr 2012 02:37

Link

Quote: "Quick question, why are you guys even using the Dark GDK?"

We're taking a class that's being taught from the Gaddis book. We got bored, so we tried writing this program. When we hit a wall our teacher couldn't answer any of our questions, and so we came here instead. The end.

Back to top

Profile PM

DeadTomGC

13

Years of Service

User Offline

Joined: 11th Aug 2010

Location: LU

Posted: 4th Apr 2012 03:11

Link

Well, for the most part the documentation has been accurate as far as I've used it. So, I just learned about that command so its new for me.

Back to top

Profile PM Email Website

matt yankello

12

Years of Service

User Offline

Joined: 3rd Apr 2012

Location:

Posted: 4th Apr 2012 03:54

Link

Hi thanks for all the input but we actually fixed it by simply changing it to a do-while loop. I am not fully sure why this worked but it did. The reason why we are using darkgdk is because we are actually in high school and we took a c++ class only to learn that the school bought book for gaming and design IN c++ so darkgdk is all we know. And yes I did mean without. Not with

Back to top

Profile PM

matt yankello

12

Years of Service

User Offline

Joined: 3rd Apr 2012

Location:

Posted: 4th Apr 2012 03:58

Link

Wicked X thank you very much for your working code as well

Back to top

Profile PM

Sorry your browser is not supported!

Dark GDK / Need help with Collatz Conjecture Loop