Multiple objects - GameCreators Forum

Author

Message

Silence

11

Years of Service

User Offline

Joined: 14th Oct 2012

Location:

Posted: 1st Nov 2012 19:25

Link

Hello! I am having a tiny problem with my code. More or less confusion to be exact. I have three cubes on my screen and I when I hit "s" I want it to switch which cube I can control. How does one do this?

+ Code Snippet

do
   if Upkey()=1 then move object 1,5
   if Downkey()=1 then move object 1,-5
   if Leftkey()=1 then Yrotate object 1,wrapvalue(A1Y#-3.5)
   if Rightkey()=1 then Yrotate object 1,wrapvalue(A1Y#+3.5)
   sync
loop


if inkey$() <> "s" then gosub cube2

cube2:

do
   if Upkey()=1 then move object 2,5
   if Downkey()=1 then move object 2,-5
   if Leftkey()=1 then Yrotate object 2,wrapvalue(A1Y#-3.5)
   if Rightkey()=1 then Yrotate object 2,wrapvalue(A1Y#+3.5)
   sync
loop

wait key

this is what I have so far but the controls dont swich to a different cube

Back to top

Profile PM

Phaelax

DBPro Master

21

Years of Service

User Offline

Joined: 16th Apr 2003

Location: Metropia

Posted: 2nd Nov 2012 01:19

Link

Bad way of writing it. What if you had 100 cubes? Would you really want to rewrite the control routine for every single one?

But as to why yours doesn't work is because your inkey$ is never reached. Your first block contains a do-loop, which means unless you explicitly escape the loop, nothing outside of it will ever do anything.

Look through this code example:

+ Code Snippet

obj_id = 1


sync on
sync rate 60

do

    if Upkey()=1 then move object obj_id,5
    if Downkey()=1 then move object obj_id,-5
    if Leftkey()=1 then Yrotate object obj_id,wrapvalue(A1Y#-3.5)
    if Rightkey()=1 then Yrotate object obj_id,wrapvalue(A1Y#+3.5)
    

    if inkey$() <> "s" and vkFlag = 0
        vkFlag = 1
        inc obj_id
        if obj_id > 3 then obj_id = 1
    endif
    
    if inkey$() = "" then vkFlag = 0
    

    sync
loop

Let's say your three objects are numbered 1 through 3. By using a variable to represent the object number, we can just increment its value whenever you press "S". When you press the "S" key, the computer can register it many times before you release it, cause the action to happen repeatedly. We don't want that kind of behavior so we use vkFlag to prevent that. It's just another variable, what we call a flag. You can only press S if the flag is down. When you press S it raises the flag. When you release the key, the flag goes back down. This is so if you hold down the key, it won't continuously keep switching objects on you.

inc obj_id adds 1 to the value of obj_id. We only want the value to be between 1 and 3, so if it goes over 3, set it back to 1. This will make your object selection loop around from 1 to 3. So if you're controlling object 3, pressing the S key will now control object 1 again.

"You're not going crazy. You're going sane in a crazy world!" ~Tick

Back to top

Profile PM Email Website

Silence

11

Years of Service

User Offline

Joined: 14th Oct 2012

Location:

Posted: 2nd Nov 2012 02:00

Link

Thank you very much for you code. But it's not quite what I wanted. This code makes all three cubes move at the same time and when I hold "S" it will move a different cube each time. What I needed was that as soon as the program started it will move object 1 with the control button and when I hit "S" once it should move object 2 and so on.

Back to top

Profile PM

Virtual Nomad

Moderator

18

Years of Service

User Offline

Joined: 14th Dec 2005

Location: SF Bay Area, USA

Posted: 2nd Nov 2012 05:21 Edited at: 2nd Nov 2012 05:28

Link

elaborated on the same notions phaelax offered:

+ Code Snippet

FirstObj = 1 : LastObj = 20
CurrentObj = FirstObj

sync on : sync rate 60
randomize timer()

autocam off

for x = FirstObj to LastObj
   make object cube x, 10.0
   position object x, x*10.0, 0.0, 0.0
   color object x, rgb(rnd(255),rnd(255),rnd(255))
next x

position camera (LastObj*10.0)/2.0, LastObj*20.0, 0.0
   point camera camera position x(), 0.0,0.0

do

   if inkey$() <> "s" then WasReleased = 1

   if inkey$() = "s" and WasReleased = 1
      INC CurrentObj
      if CurrentObj > LastObj then CurrentObj = FirstObj
      WasReleased = 0
   endif

   yrotate object CurrentObj, wrapvalue(object angle y(CurrentObj)+((rightkey()-leftkey())*1.0))
   move object CurrentObj, (upkey()-Downkey())*1.0

   set cursor 0,0
   print CurrentObj
   sync

loop

adjust to suit your needs.

oops: fixed it to set the WasReleased flag specifically for the s key. all better now

Virtual Nomad @ California, USA . DBPro V7.7
AMD Phenom™ X4 9750 Quad-Core @ 2.4 GHz . 8 GB PC2-6400 RAM
ATI Radeon HD 3650 @ 512 MB . Vista Home Premium 64 Bit

Back to top

Profile PM Website

Phaelax

DBPro Master

21

Years of Service

User Offline

Joined: 16th Apr 2003

Location: Metropia

Posted: 2nd Nov 2012 08:26

Link

Quote: "as the program started it will move object 1 with the control button and when I hit "S" once it should move object 2 and so on."

Uhh isn't that what mine does? You just said you wanted all 3 to move at the same time, now you're stating one at a time.

"You're not going crazy. You're going sane in a crazy world!" ~Tick

Back to top

Profile PM Email Website

nonZero

12

Years of Service

User Offline

Joined: 10th Jul 2011

Location: Dark Empire HQ, Otherworld, Silent Hill

Posted: 2nd Nov 2012 12:01 Edited at: 2nd Nov 2012 12:03

Link

Quote: "I am having a tiny problem with my code."

Quote: "

+ Code Snippet

do
   if Upkey()=1 then move object 1,5
   if Downkey()=1 then move object 1,-5
   if Leftkey()=1 then Yrotate object 1,wrapvalue(A1Y#-3.5)
   if Rightkey()=1 then Yrotate object 1,wrapvalue(A1Y#+3.5)
   sync
loop


if inkey$() <> "s" then gosub cube2

cube2:

do
   if Upkey()=1 then move object 2,5
   if Downkey()=1 then move object 2,-5
   if Leftkey()=1 then Yrotate object 2,wrapvalue(A1Y#-3.5)
   if Rightkey()=1 then Yrotate object 2,wrapvalue(A1Y#+3.5)
   sync
loop

wait key

"

Okay, OP, you have some solutions but you need to understand why your code doesn't work so we'll go through this.
Firstly, you've a DO..LOOP with a set of instructions. Fine. But your condition for switching cubes is outside the DO..LOOP so essentially you'll keep looping and never reach that IF INKEY$() = "s" part. Secondly, and this wouldn't be apparent straight away be you are calling GOSUB above your label. This is pointless because the program executes from top to bottom, meaning it'll go to your label anyway. This method of using a label is wrong however, as Phaelax pointed out, for the reasons he stated (as well as the fact that GOTO/GOSUB should be avoided by newcomers).

@Phaelax:
I think you made a typo:

Quote: "

+ Code Snippet

    if inkey$() <> "s" and vkFlag = 0
        vkFlag = 1
        inc obj_id
        if obj_id > 3 then obj_id = 1
    endif

"

You said if inkey$() != 's'... should be ==. I do that too and then the next day I'm like "why won't it work!?" when I compile, lol

My most recent blunder was yesterday evening when I was comparing to string buffers and I had = instead of ==. I read over the code about 5 times and didn't spot it till I ran through it outputting the results for every line. The minute I saw the assignment pop up on screen I thought "Noooo, I checked the code!"

Also, forgot to update the "A1Y#" variable at the end of the controls codeblock.

Just gonna post the corrected code for OP's education:

+ Code Snippet

obj_id = 1

sync on
sync rate 60

do

    if Upkey()=1 then move object obj_id,5
    if Downkey()=1 then move object obj_id,-5
    if Leftkey()=1 then Yrotate object obj_id,wrapvalue(A1Y#-3.5)
    if Rightkey()=1 then Yrotate object obj_id,wrapvalue(A1Y#+3.5)

    A1Y# = OBJECT ANGLE Y(obj_id)         // Here

    if inkey$() = "s" and vkFlag = 0      // And here
        vkFlag = 1
        inc obj_id
        if obj_id > 3 then obj_id = 1
    endif

    if inkey$() = "" then vkFlag = 0


    sync
loop

Anyway, OP, hope this is of use.

RP Functions Library v1.0

+ Code Snippet

My sig is now minimalistic; optimized for your optical resources.

Back to top

Profile PM Email Website

Silence

11

Years of Service

User Offline

Joined: 14th Oct 2012

Location:

Posted: 2nd Nov 2012 16:14

Link

o: thank you to all for your help. And i apologized. i could have stated my problem better. This code works amazingly! I love it!

Back to top

Profile PM

Sorry your browser is not supported!

Newcomers DBPro Corner / Multiple objects