Sorry your browser is not supported!

wondering if it was possible to make a type as a parameters for functions. it would be alot better than typeing in each value on the type

for example

type _obj
     img
     spr
     x#
     y#
     ang#
     w#
     h#
endtype

dim object[10] as _obj
collisionTest as _obj

do
    for i = 0 to 10
       GetSpriteCollision (collisionTest.spr, object[i].spr)
           MakeObjectDoSomething (object)
       endif
    next i
loop

Function MakeObjectDoSomething ( paratype as _obj )
   //do stuff with the object
EndFunction

how can it be done if it can be?

Back to top

Profile PM

Phaelax

DBPro Master

21

Years of Service

User Offline

Joined: 16th Apr 2003

Location: Metropia

Posted: 8th Aug 2013 22:19

Yes you can pass a UDT into a function, however, it's passed by value. Therefore, whatever you do to that variable will only exist within the function. You'd have to return it and assign to something else outside the scope of the function.

t as myUDT

t = doThing(t)

function doThing(n as myUDT)
    n.x = 42
    n.life = 100
endfunction n

Back to top

Profile PM Email Website

Markus

Valued Member

20

Years of Service

User Offline

Joined: 10th Apr 2004

Location: Germany

Posted: 8th Aug 2013 23:04

and one issue i had, you can not dim a udt inside a function and
give it the next function.
a faster way is giving the function the array index
but then you can handle only one array with it...

Back to top

Profile PM Email

samqweqwe

11

Years of Service

User Offline

Joined: 7th Apr 2013

Location:

Posted: 9th Aug 2013 02:05

doent seem to work... i get this error:

Sprite 0 does not exist at line ... in ....agc

it is what is located at the position

Function Reset_Ball ( ball as _obj )
    ball = Randomize_Ball ( ball )

    scoreFlag = 3
    SetSpritePositionByOffset ( ball.spr, width / 2, height / 2)
    SetSpritePhysicsVelocity ( ball.spr, ball.sx#, ball.sy# )
EndFunction ball

the line where the error occurs is SetSpritePositionByOffset
this function is called like:

if GetSpriteX (ball.spr) <= 1
        score = score + 500
        ball = Reset_Ball ( ball )
    endif

what am i doing wrong??

Back to top

Profile PM

Markus

Valued Member

20

Years of Service

User Offline

Joined: 10th Apr 2004

Location: Germany

Posted: 9th Aug 2013 03:14

i can't see the source where you set .spr=

Back to top

Profile PM Email

Hockeykid

DBPro Tool Maker

16

Years of Service

User Offline

Joined: 26th Sep 2007

Location:

Posted: 9th Aug 2013 08:15

Quote: "doent seem to work... i get this error:"

Unfortunately, UDT's can't be returned from a function (which looks like what you're trying to do).

Sean

Back to top

Profile PM Email

Markus

Valued Member

20

Years of Service

User Offline

Joined: 10th Apr 2004

Location: Germany

Posted: 9th Aug 2013 09:13

@Hockeykid
it seems to works, here is a example

rem
rem AGK Application 108 B 16
rem Test UDT

SetDisplayAspect( 4.0/3.0 )

type TTest
    x
    y
    s as string
endtype

Main()
end

function Main()

 a as TTest
 b as TTest

    do
     a=Test()
     print(a.x)
     print(a.y)
     print(a.s)

     b=Test2(b)
     print(b.x)

     if getpointerpressed()=1 then exit
     Sync()
    loop
endfunction

function Test()

    r as TTest
    r.x=1
    r.y=2
    r.s="Hallo"

endfunction r

function Test2(r as TTest)

    r.x=r.x+1

endfunction r

Back to top

Profile PM Email

samqweqwe

11

Years of Service

User Offline

Joined: 7th Apr 2013

Location:

Posted: 9th Aug 2013 16:19 Edited at: 9th Aug 2013 16:21

sorry
heres the UDT definition:

type _obj
    img
    spr
    x#
    y#
    ang#
    w#
    h#
    sx#
    sy#
    flag
    name$
endtype

and heres .spr

ball.img = LoadImage ( "basic ball.png" )
ball.spr = CreateSprite ( ball.img )

Back to top

Profile PM

JimHawkins

14

Years of Service

User Offline

Joined: 26th Jul 2009

Location: Hull - UK

Posted: 9th Aug 2013 19:55

That's never going to work on Android!

Take the space out.

-- Jim DO IT FASTER, EASIER AND BETTER WITH AppGameKit FOR PASCAL

Back to top

Profile PM Website

Digital Awakening

AGK Developer

21

Years of Service

User Offline

Joined: 27th Aug 2002

Location: Sweden

Posted: 9th Aug 2013 20:47

UDTs can be passed by value, to and from functions. Just beware of this bug. http://code.google.com/p/agk/issues/detail?id=449&start=100

Back to top

Profile PM Website

samqweqwe

11

Years of Service

User Offline

Joined: 7th Apr 2013

Location:

Posted: 9th Aug 2013 20:57

Quote: "Take the space out."

do you mean like:

ball.img=LoadImage("basic ball.png")
ball.spr=CreateSprite(ball.img)

?

would a better way to do this is by having an array where everything is a float eg ball#[10] insead of ball as _obj?

Back to top

Profile PM

Markus

Valued Member

20

Years of Service

User Offline

Joined: 10th Apr 2004

Location: Germany

Posted: 10th Aug 2013 00:52

i believe JimHawkins means the space in filename, rename and try.
ball.img = LoadImage ( "basicball.png" )
ball.spr = CreateSprite ( ball.img )

if you only have one sprite with this image you can use also ball.spr=LoadSprite("basicball.png")

Back to top

Profile PM Email

samqweqwe

11

Years of Service

User Offline

Joined: 7th Apr 2013

Location:

Posted: 10th Aug 2013 14:03 Edited at: 10th Aug 2013 14:52

thanks

would it be better if ball.spr = 1 instead of ball.spr = CreateSprite? what i gather is that it is not putting values into the function

EDIT:
i may have found why i is doing it. originally i had:

do 
       ball = update_Game (ball)
loop

where in a different file i went

function update_Game (ball as _obj)
       ball = update_Ball(ball)
       //other functions do do with updating the game
endfunction ball

where in another file

function update_Ball (ball as _obj)
       //update ball code
endfunction ball

but by removing the middle function it worked

do 
       ball = update_Ball (ball)
       //other functions do do with updating the game
loop

is there a way to overcome this?

Back to top

Profile PM

peterJBE

16

Years of Service

User Offline

Joined: 11th Mar 2008

Location: Belgium

Posted: 10th Aug 2013 17:59

I am also a bit confused by the discussion about UDT´s
I think if passing by value works correctly following code should be OK. f1() can not access the first member of the UDT.

rem
rem AGK Application
rem

rem A Wizard Did It!
createtext(1,"")
createtext(2,"")
createtext(3,"")
settextposition (1,10,10)
settextposition (2,10,20)
settextposition (3,10,30)


type person
famname as string
name as string
endtype

main()
end

function main()
p1 as person
p1.name="peter"
p1.famname = "jonckheere"
settextstring(1,"1:" + p1.name +":" + p1.famname)
settextposition (1,10,10)
f1(p1)
do
Sync()
loop
endfunction

function f1( p as person )
settextstring(2, "2:" + p.name + ":" +  p.famname)
f2(p)
endfunction

function f2(p as person)
settextstring(3, "3:"  +p.name + " "  + p.famname)
endfunction


// only the first member of the UDT can be accessed ?

I wonder why this works as a workaround

rem
rem AGK Application
rem

rem A Wizard Did It!
createtext(1,"")
createtext(2,"")
createtext(3,"")
settextposition (1,10,10)
settextposition (2,10,20)
settextposition (3,10,30)


type person
famname as string
name as string
endtype

main()
end

function main()
global p1 as person // added global
p1.name="peter"
p1.famname = "jonckheere"
settextstring(1,"1:" + p1.name +":" + p1.famname)
settextposition (1,10,10)
f1(p1)
do
Sync()
loop
endfunction

function f1( p as person )
global pp as person // declared extra global variable
pp = p // assigned function parameter to it
settextstring(2, "2:" + p.name + ":" +  p.famname)
f2(pp)
endfunction

function f2(p as person)
settextstring(3, "3:"  +p.name + ":"  + p.famname)
endfunction

Back to top

Profile PM Email

samqweqwe

11

Years of Service

User Offline

Joined: 7th Apr 2013

Location:

Posted: 10th Aug 2013 19:06

that seems like it should work. ill try it out

Back to top

Profile PM

Mobiius

Valued Member

21

Years of Service

User Offline

Joined: 27th Feb 2003

Location: The Cold North

Posted: 12th Aug 2013 21:00 Edited at: 12th Aug 2013 21:00

Quote: "p1 as person"

Perhaps this doesn't work as it's not being turned into an array, whereas internally Globals are arrays.

If you're declaring new types surely you should be typing the following anyway:

Dim p1 as person

In AppGameKit, I ALWAYS create UDT's at the top of include files not in functions, and declare them in functions without error.

Back to top

Profile PM Email Website

baxslash

Valued Member

Bronze Codemaster

17

Years of Service

User Offline

Joined: 26th Dec 2006

Location: Duffield

Posted: 12th Aug 2013 23:27

Quote: "In AppGameKit, I ALWAYS create UDT's at the top of include files not in functions, and declare them in functions without error."

Me too. If your arrays are declared at the top of your included file (even if empty) they can be picked up anywhere.

I know it's not ideal but it works for now. I've managed to convince the team that it needs looking at and fixing (preferably before V2) but it all depends on how deep in the core code this lies as to whether it will be fixed in V1.

"Here I am trying to do some good for the world..." - Fluffy Rabbit

Back to top

Profile PM Email

Impetus73

12

Years of Service

User Offline

Joined: 28th Aug 2011

Location: Volda, Norway

Posted: 12th Aug 2013 23:33

It's important to know that include files are just pasted under the main file during compiling, making one long main file of text, so all inside them HAS to be inside functions, and you need to call them after you use the #include command, or they never get run.

----------------
AGK programmer
Did Amiga / AMOS programming in the 90's.

Back to top

Profile PM Email

Mobiius

Valued Member

21

Years of Service

User Offline

Joined: 27th Feb 2003

Location: The Cold North

Posted: 13th Aug 2013 00:31 Edited at: 13th Aug 2013 00:31

Quote: "so all inside them HAS to be inside functions"

Not entirely true. Type defines DO NOT need to be executed in AppGameKit to be processed. Yes it's true #includes are included at the bottom of the code, but when I define them, they're in 'No Codes Land' either Between the End statement and the first function declaration, or between functions where execution never reaches. (Gotta love pre-processors!) I do however have to declare the type in executing code.

Note the difference between a define and a declare...

Define: Does not need to be stepped over.

Type tType
   iNumber
   szText$
   fDecimal
EndType

Declare: Needs to be executed.

Dim Array[ X ] As tType

Back to top

Profile PM Email Website

baxslash

Valued Member

Bronze Codemaster

17

Years of Service

User Offline

Joined: 26th Dec 2006

Location: Duffield

Posted: 13th Aug 2013 10:44

@Mobiius is right actually. I always define UDT's in a relevant agc file. For example my player type is almost always declared in my player.agc file these days. I just find it easier to keep track of that way.

"Here I am trying to do some good for the world..." - Fluffy Rabbit

Back to top

Profile PM Email

Mobiius

Valued Member

21

Years of Service

User Offline

Joined: 27th Feb 2003

Location: The Cold North

Posted: 13th Aug 2013 20:33

Quote: "@Mobiius is right actually."

Don't sound so surprised! lol

Back to top

Profile PM Email Website

baxslash

Valued Member

Bronze Codemaster

17

Years of Service

User Offline

Joined: 26th Dec 2006

Location: Duffield

Posted: 13th Aug 2013 23:09

Not surprised at all, you normally are right. Except when you're wrong.

"Here I am trying to do some good for the world..." - Fluffy Rabbit

Back to top

Profile PM Email

Mobiius

Valued Member

21

Years of Service

User Offline

Joined: 27th Feb 2003

Location: The Cold North

Posted: 13th Aug 2013 23:58

Never a truer word was spoken. lol

Back to top

Profile PM Email Website

Ancient Lady

Valued Member

20

Years of Service

User Offline

Joined: 17th Mar 2004

Location: Anchorage, Alaska, USA

Posted: 15th Aug 2013 06:55