iOs/Android/Win/Mac Random Crash

Author

Message

Mendo

7

Years of Service

User Offline

Joined: 13th Nov 2016

Location:

Posted: 28th Sep 2019 17:48 Edited at: 29th Sep 2019 12:26

Link

Hello everybody,
I have a problem with mobile devices that I can't solve (after months of debugging): at random, when the main loop of the game is restarted (I repeat, not always), the App ends without any error (both iOs and Android) .
The problem occurs both with the agkplayer and with ipa and apk.
Occasionally even while trying the game in windows or mac, when the main loop is restarted, the program ends without errors.
Thanks
I attach the log file iOs.

Attachments

Login to view attachments

Back to top

Profile PM

fubarpk

Retired Moderator

19

Years of Service

User Offline

Joined: 11th Jan 2005

Playing: AGK is my friend

Posted: 28th Sep 2019 23:49

Link

@Mendo
Can you refrain from posting excessively large lists of unmeaningful data
this could all have been attached as a textfile with a brief description. This is exactly
the type of thread that causes forum crashes

fubarpk
fubarpk on Itch...………...https://fubarpk.itch.io/
fubarpk on googleplay..https://play.google.com/store/apps/developer?id=fubarpk

Back to top

Profile PM Email Website

Mendo

7

Years of Service

User Offline

Joined: 13th Nov 2016

Location:

Posted: 29th Sep 2019 16:32

Link

@fubarpk
ok, i re-post:

Hello everybody,
I have a problem with mobile devices that I can't solve (after months of debugging): at random, when the main loop of the game is restarted (I repeat, not always), the App ends without any error (both iOs and Android) .
The problem occurs both with the agkplayer and with ipa and apk.
Occasionally even while trying the game in windows or mac, when the main loop is restarted, the program ends without errors.
Thanks
I attach the log file iOs.

Attachments

Login to view attachments

Back to top

Profile PM

Mendo

7

Years of Service

User Offline

Joined: 13th Nov 2016

Location:

Posted: 2nd Oct 2019 16:36

Link

Update:

random bug on

+ Code Snippet

DeleteAllSprites()
DeleteAllImages()
DeleteAllText()

AGC is too instable, switch on Amazon Lumberyard

Back to top

Profile PM

fubarpk

Retired Moderator

19

Years of Service

User Offline

Joined: 11th Jan 2005

Playing: AGK is my friend

Posted: 2nd Oct 2019 16:49

Link

Unless they've changed that recently I haven't noticed a bug with those
but I have noticed that if you delete an image while a sprite exists then
there is issues. Its documented

fubarpk
fubarpk on Itch...………...https://fubarpk.itch.io/
fubarpk on googleplay..https://play.google.com/store/apps/developer?id=fubarpk

Back to top

Profile PM Email Website

Mendo

7

Years of Service

User Offline

Joined: 13th Nov 2016

Location:

Posted: 2nd Oct 2019 18:11

Link

Thanks for the reply, but in sequence I delete:
DeleteAllSprites()
DeleteAllImages()
DeleteAllText()
I'm using the auto numbering of objects and it seems that at a certain point it goes into confusion (I create and delete many resources, about a thousand, during the main loop) and even if I try a manual deletion (recovering all the ids of the main objects and "ifexist"), at random, it crashes, sometimes on the deleteimage other deletesprite ... (ios report "the resource does not exist in that position", so agk is trying to delete an object incorrectly assigned type an id image instead of a sprite id ...)

Back to top

Profile PM

fubarpk

Retired Moderator

19

Years of Service

User Offline

Joined: 11th Jan 2005

Playing: AGK is my friend

Posted: 2nd Oct 2019 18:30 Edited at: 2nd Oct 2019 18:38

Link

just a thought do you have any 3D objects ?

as that will cause a problem if your deleting images

DeleteAllObjects () before deleting images will fix that

the other thing if any buttons are using images that will also error

and if you attempt to use any ID that doesn't exist anymore that will cause errors

deleting all sprites etc should only be called at the end of each level preferably

fubarpk
fubarpk on Itch...………...https://fubarpk.itch.io/
fubarpk on googleplay..https://play.google.com/store/apps/developer?id=fubarpk

Back to top

Profile PM Email Website

fubarpk

Retired Moderator

19

Years of Service

User Offline

Joined: 11th Jan 2005

Playing: AGK is my friend

Posted: 2nd Oct 2019 18:50

Link

if you could share some code someone may be able to help

im quite sure there is some form of logic error that if you shared some code or
an example of code that has the same issue its fixable.

fubarpk
fubarpk on Itch...………...https://fubarpk.itch.io/
fubarpk on googleplay..https://play.google.com/store/apps/developer?id=fubarpk

Back to top

Profile PM Email Website

fubarpk

Retired Moderator

19

Years of Service

User Offline

Joined: 11th Jan 2005

Playing: AGK is my friend

Posted: 2nd Oct 2019 19:04

Link

The following demonstrates it working for me

//background infinite scrolling - good for jetpack joyride style of gameplay

//made for iphone resolution - change for your own prefered
SetVirtualResolution(960,640)

//background array
global dim BG[10]

//set background sprite
for num = 1 to 9
	BG[num] = CreateSprite (0)
	SetSpriteSize(BG[num],64,64)
	//SetSpriteColor(BG[num],random(1,255),random(2,255),random(1,255),255)
	col=MakeColor(random(1,255),random(1,255),random(1,255))
	SetSpriteImage(BG[num],CreateImage(col))
	SetSpritePosition(BG[num],random(0,960),random(0,640))
next num
//main loop

AddVirtualButton(1,100,100,100)
Do

if GetRawKeyState(37)
		x=x+1
	endif
	if GetRawKeyState(39)
		x=x-1
	endif
		
	if GetVirtualButtonState(1)
		DeleteAllSprites()
		DeleteAllImages()
		for num = 1 to 9
			BG[num] = CreateSprite (0)
			SetSpriteSize(BG[num],64,64)
			//SetSpriteColor(BG[num],random(1,255),random(2,255),random(1,255),255)
			col=MakeColor(random(1,255),random(1,255),random(1,255))
			SetSpriteImage(BG[num],CreateImage(col))
			SetSpritePosition(BG[num],random(0,960),random(0,640))
		next num
		
	endif		
    
    //offsetting
    SetViewOffset (x, 0)

sync()
Loop

function CreateImage(color)
    SetClearColor(0,0,0)
    ClearScreen()
    //draw craft
    DrawBox(0,0,16,16,color,color,color,color,1)
    img = getImage(0,0,16,16)
    SetImageTransparentColor(img,0,0,0)
endfunction img

+ Code Snippet


//background infinite scrolling - good for jetpack joyride style of gameplay

//made for iphone resolution - change for your own prefered
SetVirtualResolution(960,640)

//background array
global dim BG[10]

//set background sprite
for num = 1 to 9
	BG[num] = CreateSprite (0)
	SetSpriteSize(BG[num],64,64)
	//SetSpriteColor(BG[num],random(1,255),random(2,255),random(1,255),255)
	col=MakeColor(random(1,255),random(1,255),random(1,255))
	SetSpriteImage(BG[num],CreateImage(col))
	SetSpritePosition(BG[num],random(0,960),random(0,640))
next num
//main loop

    AddVirtualButton(1,100,100,100)
Do


    if GetRawKeyState(37)
		x=x+1
	endif
	if GetRawKeyState(39)
		x=x-1
	endif
		
	if GetVirtualButtonState(1)
		DeleteAllSprites()
		DeleteAllImages()
		for num = 1 to 9
			BG[num] = CreateSprite (0)
			SetSpriteSize(BG[num],64,64)
			//SetSpriteColor(BG[num],random(1,255),random(2,255),random(1,255),255)
			col=MakeColor(random(1,255),random(1,255),random(1,255))
			SetSpriteImage(BG[num],CreateImage(col))
			SetSpritePosition(BG[num],random(0,960),random(0,640))
		next num
		
	endif		
    
    //offsetting
    SetViewOffset (x, 0)

    sync()
Loop

function CreateImage(color)
    SetClearColor(0,0,0)
    ClearScreen()
    //draw craft
    DrawBox(0,0,16,16,color,color,color,color,1)
    img = getImage(0,0,16,16)
    SetImageTransparentColor(img,0,0,0)
endfunction img

fubarpk
fubarpk on Itch...………...https://fubarpk.itch.io/
fubarpk on googleplay..https://play.google.com/store/apps/developer?id=fubarpk

Back to top

Profile PM Email Website

Mendo

7

Years of Service

User Offline

Joined: 13th Nov 2016

Location:

Posted: 9th Oct 2019 09:53

Link

thanks for the answer and for the example.
we identified the problem as a sum of weaknesses from the mobile operating system (both) and the management of agk images.
It is difficult to reproduce the error (random), our main loop is about 15000 lines.
We are optimizing the image management, which apparently creates most of the problems with the operating system and agk (stack with a wrong memory block), using almost exclusively subimages, but this causes another problem ... ( but will they ever end?): the 2d shader does not work properly with a "normal mapping" image, but only with an image loaded with the classic loadimage method; in the help it was explained that the subimages are treated as images, but it is not so, at least for the 2d shader.
We want to load as few images as possible with atlas textures, but if the shader doesn't accept subimages, I don't see other solutions than implementing loadimage again (which brings us back to the stack problem) ...

Back to top

Profile PM

vennis73

7

Years of Service

User Offline

Joined: 12th Sep 2016

Location:

Posted: 19th Dec 2019 22:52 Edited at: 19th Dec 2019 22:57

Link

I also have this problem of the ClearAlImages crash.

My application worked fine until tonight.

I added sounds and music today and suddenly IOS crashes. Windows has no problems.
I added logs and it seems DeleteAllImages() causes a hard crash on IOS.

I tried to debug but also without loading sounds/music it crashes.

I'm thinking it might has to do with the latest release (17th dec) since i didn't had this issue before.
So either it has to do with sound/music or it's just a new thing (from my point of view).

Edit: I thought i had a workaround, same issue.

workaround same issue
i ended up to store the last imageID and just manually clear it. It's not pretty but for now it works.

+ Code Snippet

function ClearAllImages()
	for i = 0 to max_imageID
		if(GetImageExists(i) = 1)
			DeleteImage(i)
		endif
	next
endfunction

Back to top

Profile PM

fubarpk

Retired Moderator

19

Years of Service

User Offline

Joined: 11th Jan 2005

Playing: AGK is my friend

Posted: 19th Dec 2019 23:03

Link

@vennis73

is it possible you are deleting an image that is being used at the time
for example if you have a sprite on the screen and then delete all images
you will get problems. The same if you delete an image that a 3d object
is already using.

deleteallsprites
deleteallobjects
deleteallimages

in the above will work if done in that order

fubarpk
fubarpk on Itch...………...https://fubarpk.itch.io/
fubarpk on googleplay..https://play.google.com/store/apps/developer?id=fubarpk

Back to top

Profile PM Email Website

vennis73

7

Years of Service

User Offline

Joined: 12th Sep 2016

Location:

Posted: 19th Dec 2019 23:35 Edited at: 19th Dec 2019 23:37

Link

@fubarpk

I'm 2D only, so just sprites, images and particles atm.
The ClearAllObjects isn't really required.

At this moment i manually created a list of sprites and images that should be deleted using wrappers

global gfxCleanupSprites as integer[]
global gfxCleanupImages as integer[]

function gfxLoadImage(filename$)
	newimage as integer
	newimage = LoadImage(filename$)
	gfxCleanupImages.insert(newimage)
endfunction newimage

function gfxCreateSprite(image as integer)
	newsprite as integer
	newsprite = CreateSprite(image)
	gfxCleanupSprites.insert(newsprite)
endfunction newsprite

function gfxCloneSprite(sprite as integer)
	newsprite as integer
	newsprite = CloneSprite(sprite)
	gfxCleanupSprites.insert(newsprite)
endfunction newsprite

function ClearAllImages()
	if(gfxCleanupImages.length > -1)
		for i = 0 to gfxCleanupImages.length
			if(GetImageExists(gfxCleanupImages[i]) = 1)
				hlpWriteDebug("DeleteImage " + str(gfxCleanupImages[i]))
				DeleteImage(gfxCleanupImages[i])
			endif
		next
		gfxCleanupImages.length = -1
	endif
endfunction
function ClearAllSprites()
	if(gfxCleanupSprites.length > -1)
		for i = 0 to gfxCleanupSprites.length
			if(GetSpriteExists(gfxCleanupSprites[i]) = 1)
				hlpWriteDebug("DeleteSprite " + str(gfxCleanupSprites[i]))
				DeleteSprite(gfxCleanupSprites[i])
			endif
		next
		gfxCleanupSprites.length = -1
	endif
endfunction

+ Code Snippet

global gfxCleanupSprites as integer[]
global gfxCleanupImages as integer[]

function gfxLoadImage(filename$)
	newimage as integer
	newimage = LoadImage(filename$)
	gfxCleanupImages.insert(newimage)
endfunction newimage

function gfxCreateSprite(image as integer)
	newsprite as integer
	newsprite = CreateSprite(image)
	gfxCleanupSprites.insert(newsprite)
endfunction newsprite

function gfxCloneSprite(sprite as integer)
	newsprite as integer
	newsprite = CloneSprite(sprite)
	gfxCleanupSprites.insert(newsprite)
endfunction newsprite


function ClearAllImages()
	if(gfxCleanupImages.length > -1)
		for i = 0 to gfxCleanupImages.length
			if(GetImageExists(gfxCleanupImages[i]) = 1)
				hlpWriteDebug("DeleteImage " + str(gfxCleanupImages[i]))
				DeleteImage(gfxCleanupImages[i])
			endif
		next
		gfxCleanupImages.length = -1
	endif
endfunction
function ClearAllSprites()
	if(gfxCleanupSprites.length > -1)
		for i = 0 to gfxCleanupSprites.length
			if(GetSpriteExists(gfxCleanupSprites[i]) = 1)
				hlpWriteDebug("DeleteSprite " + str(gfxCleanupSprites[i]))
				DeleteSprite(gfxCleanupSprites[i])
			endif
		next
		gfxCleanupSprites.length = -1
	endif
endfunction

result after two runs (seems really random)
Sometimes i can do it successfully but the 2nd cleanup alway fails

Log

eleteImage 100045
Log

eleteImage 100046
Log

eleteImage 100047
etc...
Log

eleteImage 100480
Log

eleteImage 100481
*CRASH*

after another run
Log

eleteImage 100143
Log

eleteImage 100144
etc..
Log

eleteImage 100186
Log

eleteImage 100187
*CRASH*

Back to top

Profile PM

vennis73

7

Years of Service

User Offline

Joined: 12th Sep 2016

Location:

Posted: 19th Dec 2019 23:49

Link

@fubarpk

Something weird happens

My cleanup function

+ Code Snippet

*snippets* 

	ClearAllSprites()
	hlpWriteDebug("DeleteAllObjects")
	DeleteAllObjects()
	hlpWriteDebug("ClearAllImages")
	ClearAllImages()


function hlpWriteDebug(text$)
	if(hlpDebugEnabled = 1)
		Log(text$)
		hlpDebuglog.insert(text$)
		debugFile=openToWrite("debugLog.txt",1)
		writeLine(debugFile,text$)
		closefile(debugFile)
	endif
endfunction

My log, the weird thing is around sprite 100611 it switches to image.

Log:DeleteAllSprites
Log:DeleteSprite 100570
Log:DeleteSprite 100571
Log:DeleteSprite 100572
Log:DeleteSprite 100573
Log:DeleteSprite 100594
Log:DeleteSprite 100595
Log:DeleteSprite 100596
Log:DeleteSprite 100597
Log:DeleteSprite 100598
Log:DeleteSprite 100599
Log:DeleteSprite 100600
Log:DeleteSprite 100601
Log:DeleteSprite 100604
Log:DeleteSprite 100605
Log:DeleteSprite 100606
Log:DeleteSprite 100607
Log:DeleteSprite 100608
Log:DeleteSprite 100611
Log:DeleteImage 100338
Log:DeleteImage 100339
Log:DeleteImage 100340
Log:DeleteImage 100341
Log:DeleteImage 100342
Log:DeleteImage 100343
Log:DeleteSprite 100612
Log:DeleteSprite 100613
Log:DeleteSprite 100614
Log:DeleteSprite 100615
Log:DeleteSprite 100618
Log:DeleteSprite 100619
Log:DeleteSprite 100620
Log:DeleteSprite 100621
Log:DeleteSprite 100622
Log:DeleteSprite 100870
Log:DeleteSprite 101376
Log:DeleteSprite 101378
Log:DeleteSprite 101379
Log:DeleteAllObjects
Log:ClearAllImages
Log:DeleteImage 100333
Log:DeleteImage 100334
Log:DeleteImage 100335
Log:DeleteImage 100336
Log:DeleteImage 100337
Log:DeleteImage 100344
Log:DeleteImage 100345
Log:DeleteImage 100346
Log:DeleteImage 100347
Log:DeleteImage 100348
Log:DeleteImage 100349
Log:DeleteImage 100350
Log:DeleteImage 100351
Log:DeleteImage 100352

+ Code Snippet

Log:DeleteAllSprites
Log:DeleteSprite 100570
Log:DeleteSprite 100571
Log:DeleteSprite 100572
Log:DeleteSprite 100573
Log:DeleteSprite 100594
Log:DeleteSprite 100595
Log:DeleteSprite 100596
Log:DeleteSprite 100597
Log:DeleteSprite 100598
Log:DeleteSprite 100599
Log:DeleteSprite 100600
Log:DeleteSprite 100601
Log:DeleteSprite 100604
Log:DeleteSprite 100605
Log:DeleteSprite 100606
Log:DeleteSprite 100607
Log:DeleteSprite 100608
Log:DeleteSprite 100611
Log:DeleteImage 100338
Log:DeleteImage 100339
Log:DeleteImage 100340
Log:DeleteImage 100341
Log:DeleteImage 100342
Log:DeleteImage 100343
Log:DeleteSprite 100612
Log:DeleteSprite 100613
Log:DeleteSprite 100614
Log:DeleteSprite 100615
Log:DeleteSprite 100618
Log:DeleteSprite 100619
Log:DeleteSprite 100620
Log:DeleteSprite 100621
Log:DeleteSprite 100622
Log:DeleteSprite 100870
Log:DeleteSprite 101376
Log:DeleteSprite 101378
Log:DeleteSprite 101379
Log:DeleteAllObjects
Log:ClearAllImages
Log:DeleteImage 100333
Log:DeleteImage 100334
Log:DeleteImage 100335
Log:DeleteImage 100336
Log:DeleteImage 100337
Log:DeleteImage 100344
Log:DeleteImage 100345
Log:DeleteImage 100346
Log:DeleteImage 100347
Log:DeleteImage 100348
Log:DeleteImage 100349
Log:DeleteImage 100350
Log:DeleteImage 100351
Log:DeleteImage 100352

Back to top

Profile PM

fubarpk

Retired Moderator

19

Years of Service

User Offline

Joined: 11th Jan 2005

Playing: AGK is my friend

Posted: 20th Dec 2019 01:42 Edited at: 20th Dec 2019 02:35

Link

what happens if you swap ClearAllSprites() for deleteallsprites()

both of your functions can be replaced with
DeleteallSprites()
DeleteAllImages()

but if you insist on doing it that way

+ Code Snippet

function ClearAllImages()
    if(gfxCleanupImages.length > -1)
        for i = gfxCleanupImages.length to 0 step-1 //note you need to work backwards otherwise theres a problem with the logic
                hlpWriteDebug("DeleteImage " + str(gfxCleanupImages[i]))
                DeleteImage(gfxCleanupImages[i])
                gfxCleanupImages.remove(i)
        next
    endif
endfunction

the above logic should work but perhaps it should be length-1

fubarpk
fubarpk on Itch...………...https://fubarpk.itch.io/
fubarpk on googleplay..https://play.google.com/store/apps/developer?id=fubarpk

Back to top

Profile PM Email Website

Qugurun

Valued Member

9

Years of Service

User Offline

Joined: 8th Dec 2014

Playing: AppGameKit

Posted: 20th Dec 2019 03:10 Edited at: 20th Dec 2019 03:25

Link

You delete the sprite and image but not the cell in the table, information is still stored there. You need to add "remove"

+ Code Snippet

sprites as integer []

for i=0 to 10
	sprites.insert(CreateSprite(0)) 
next i

do
    if GetPointerPressed() = 1
		for i=sprites.length to 0 step -1
			if GetSpriteExists(sprites[i])
				DeleteSprite(sprites[i])
			endif
			
			sprites.remove(i)
		next i
	endif

    Print( sprites.length )
    Sync()
loop

[Plugin] Drag&Drop - Windows [Plugin] Custom Cursor - Windows https://www.instagram.com/qugurun/

Back to top

Profile PM

Bengismo

6

Years of Service

User Offline

Joined: 20th Nov 2017

Location: Yorkshire, England

Posted: 20th Dec 2019 11:17

Link

Quote: "You delete the sprite and image but not the cell in the table, information is still stored there. You need to add "remove""

He doesn't need to do that as he is deleting the the whole array after....all the entries are removed at once after deletion

Line 31: gfxCleanupImages.length = -1
Line 42: gfxCleanupSprites.length = -1

Back to top

Profile PM

vennis73

7

Years of Service

User Offline

Joined: 12th Sep 2016

Location:

Posted: 20th Dec 2019 12:02 Edited at: 20th Dec 2019 12:03

Link

@fubarpk

i created ClearAll functions because DeleteAllImages crashed. It was a test if it would be a workaround. But it crashes too on DeleteImage on some random (seems to be) point.
I used DeleteAll till yesterday

I wanted to show you that deleting images at some point just crashes, i check the existense of the image before deleting so it should be a valid deletecall.

Quote: "is it possible you are deleting an image that is being used at the time"

If an image is in use, like in a sprite, and deleting should not be possible (IMHO), then Delete should throw an exception, i don't know if it works like that but i don't think it should just crash out without error.

Back to top

Profile PM

fubarpk

Retired Moderator

19

Years of Service

User Offline

Joined: 11th Jan 2005

Playing: AGK is my friend

Posted: 20th Dec 2019 16:46

Link

Quote: "If an image is in use, like in a sprite, and deleting should not be possible"

true it is still a problem which was reported and I believe fixed some time ago but may have cropped up again

but if there is a button or sprite etc that's still using the image that might be why your having the problem and
would atleast allow you to fix the logic of your code and make it work

On windows it shows both the button and the sprite as white
as the image is gone which I still suspect is the problem with your code
but there has been xcode changes so that might explain why but if the below
code crashes on your machine that gives paul an example and also shows
what yours is perhaps doing

try this

+ Code Snippet


// Project: test 
// Created: 19-12-21

// show all errors

SetErrorMode(2)

// set window properties
SetWindowTitle( "test" )
SetWindowSize( 1024, 768, 0 )
SetWindowAllowResize( 1 ) // allow the user to resize the window

// set display properties
SetVirtualResolution( 1024, 768 ) // doesn't have to match the window
SetOrientationAllowed( 1, 1, 1, 1 ) // allow both portrait and landscape on mobile devices
SetSyncRate( 30, 0 ) // 30fps instead of 60 to save battery
SetScissor( 0,0,0,0 ) // use the maximum available screen space, no black borders
UseNewDefaultFonts( 1 )
AddVirtualButton(1, 0,0, 20)

imageID=createImg()
SetVirtualButtonImageUp(1,imageID) 
CreateSprite(1,imageID)
SetSpritePosition(1,100,100)
DeleteAllimages()
do
    Print( ScreenFPS() )
    Sync()
loop
function createImg()
	color=MakeColor(0,255,0,255)
	DrawBox(0,0,64,64,color,color,color,color,1)
	render()
    img = getImage(0,0,64,64)
    SetImageTransparentColor(img,0,0,0)
endfunction img

fubarpk
fubarpk on Itch...………...https://fubarpk.itch.io/
fubarpk on googleplay..https://play.google.com/store/apps/developer?id=fubarpk

Back to top

Profile PM Email Website

vennis73

7

Years of Service

User Offline

Joined: 12th Sep 2016

Location:

Posted: 20th Dec 2019 20:03

Link

@fubarpk i tested you code, this does not crash, it shows the white sprite.

I'll try analyze my own code and try to reproduce it in a small piece of code.

Back to top

Profile PM

vennis73

7

Years of Service

User Offline

Joined: 12th Sep 2016

Location:

Posted: 20th Dec 2019 21:09

Link

At some point i got my windows app also crashing. I found some info back in the EventLog
The attached file contains an information event, the error event and the related error file.
I doubt it's any use but maybe you can read it better then i can.

I tried to create a small program to reproduce the issue but i couldn't reproduce it yet. I'll try later again.
It does just seem to be clearimages that causes the crash. maybe it is something like a relation or the amount of images that causes trouble

My program uses images and sprites quite intensive.
I create images, i create basic character sprites with them with animations
and then clone those again into instances. But i do clearsprites first and then clearimages.

For now, i created a workaround by caching images and reusing them instead of reloading them.
Using this i don't get any crashes anymore so far.

+ Code Snippet

type imageinfo
	imageid as integer
	imagefile as string
endtype
global gfxImageCache as imageinfo[]

function gfxLoadImage(filename$)
	ifoundimage as integer = -1
	if(gfxImageCache.length > -1)
		for i = 0 to gfxImageCache.length
			if(gfxImageCache[i].imagefile = filename$)
				ifoundimage = gfxImageCache[i].imageid
			endif
		next
	endif
	if(ifoundimage = -1)
		newimage as imageinfo
		newimage.imagefile = filename$
		newimage.imageid = LoadImage(filename$)
		gfxImageCache.insert(newimage)
		ifoundimage = newimage.imageid
		gfxCleanupImages.insert(ifoundimage)
	endif
endfunction ifoundimage

Attachments

Login to view attachments

Back to top

Profile PM

fubarpk

Retired Moderator

19

Years of Service

User Offline

Joined: 11th Jan 2005

Playing: AGK is my friend

Posted: 21st Dec 2019 00:50 Edited at: 21st Dec 2019 00:51

Link

Glad you got it sorted

Perhaps you were deleting an image that was deleted previously and a combination of some memory leak or perhaps some other issue
atleast you have it working now. It helps sometimes if you can recreate the problem in a small example code atleast we know the delete
image isn't a problem and Paul can enjoy his much deserved time off over Christmas break

if you still have problems share the code with someone else who can test it, that always helps particularly if you can recreate the problem
in a condensed version of your code

fubarpk
fubarpk on Itch...………...https://fubarpk.itch.io/
fubarpk on googleplay..https://play.google.com/store/apps/developer?id=fubarpk

Back to top

Profile PM Email Website

vennis73

7

Years of Service

User Offline

Joined: 12th Sep 2016

Location:

Posted: 21st Dec 2019 08:50 Edited at: 21st Dec 2019 08:51

Link

@fubarpk,

i really don't expect anyone to interrupt his holiday for me or my problems! really don't, enjoy your holiday!

Quote: " atleast we know the delete image isn't a problem"

I don't agree with this but it's not my call. I personally think the ClearImages and DeleteImage should never cause any blunt crash in a programmer-friendly tool like AGK. i can't catch exceptions so AppGameKit should do that for me. it really should throw a controlled exception in the log and exit.

But i do understand, without a good example you guys can't do much. So i'll try to give you an example you can work with. Even if it turns out to be my own fault by doing something stupid, it might help us all to see if we can prevent the crashing.

But if i'm the only case then don't break your heads over it. The imagecaching works for now and it's for me to give you guys a good example.

Thanks for the help so far!

Back to top

Profile PM

vennis73

7

Years of Service

User Offline

Joined: 12th Sep 2016

Location:

Posted: 21st Dec 2019 10:47

Link

@fubarpk

see attached zip

I think i been able to recreate the problem. It only happens if you have a lot of sprites and images.
I rougly recreated the structure i use to create/manage sprites. The memory of the process doesn't seem to be extreme.

The amount of sprites seems to have a tip-over point. maybe that differs on OS/systems

Some background on my choise of structures:

On game initiation i create 'characters'
- load and xml file with character data (animation images and properties like animationspeed etc)
- i create a 'character-struct' for each character type
so i got a 'enemy01' with it's walking sprite, stand sprite etc.
and an 'enemy02' with it's own walking sprite and

- when starting a game, i create enemy's. these enemies are structs that are based on the character-structs
basically i clone the character-struct into the enemy-struct-instance. So i create like 10 enemies all of type 'enemy01'

Maybe i'm asking too much or should use another concept but this is as it is atm.

Attachments

Login to view attachments

Back to top

Profile PM

fubarpk

Retired Moderator

19

Years of Service

User Offline

Joined: 11th Jan 2005

Playing: AGK is my friend

Posted: 21st Dec 2019 11:53

Link

the problem isn't where you expected the problem is with these 2 lines
aBigTest.sprs1 = aTest
aBigTest.sprs2 = aTest

you need to insert these values the above is logic madness

il have a go a bit later at rewriting it but if you comment out those lines I show above it works perfectly
indefinately

fubarpk
fubarpk on Itch...………...https://fubarpk.itch.io/
fubarpk on googleplay..https://play.google.com/store/apps/developer?id=fubarpk

Back to top

Profile PM Email Website

vennis73

7

Years of Service

User Offline

Joined: 12th Sep 2016

Location:

Posted: 21st Dec 2019 12:01 Edited at: 21st Dec 2019 12:48

Link

@fubarpk i know this doesn't make sense in this test, i just had to simulate roughly how things work.

+ Code Snippet

type ArrayOfSpr
	sprs1 as SprStruct[]	
	sprs2 as SprStruct[]	
endtype 

	aTest as SprStruct[]
	aBigTest.sprs1 = aTest
	aBigTest.sprs2 = aTest

Isn't this just putting a copy of aTest into sprs1/sprs2 ?
Should i walk through the array and copy each element loose ?

Copying a array of data to another array of same type is not madness ?

Edit:

I don't the that part is the issue, if i do it like this it still crashes.

+ Code Snippet

			//aTest as SprStruct[]
			CreateSprites(aBigTest.sprs1)
			CreateSprites(aBigTest.sprs2)
			//aBigTest.sprs1 = aTest
			//aBigTest.sprs2 = aTest

Edit2:

Also the crashing is in cleaning up images. These are just integer/string arrays/structs. They contain no images or sprites. Just a bunch of integers.
I doubt these datastructures are the problem. It's in either the number or complexity of the images/sprites that are created.

Back to top

Profile PM

fubarpk

Retired Moderator

19

Years of Service

User Offline

Joined: 11th Jan 2005

Playing: AGK is my friend

Posted: 21st Dec 2019 12:17 Edited at: 21st Dec 2019 12:18

Link

+ Code Snippet

if(aBigTest.sprs1.length <0 )
			sLog	.length = -1
			iRun = iRun + 1
			sLog.insert("Run " + str(iRun))
			
			CreateSprites(aTest)
			//aBigTest.sprs1 = aTest
			//aBigTest.sprs2 = aTest
			iTotalSprites = iTotalSprites * 2
			iTotalImages = iTotalImages * 2
			sLog.insert("Create sprites")
			sLog.insert("Total images: " + str(iTotalImages))
			sLog.insert("Total sprites: " + str(iTotalSprites))
		else

but how you had it you cant copy it accross to all of the elements it has to be done a part at a time from my understanding or using insert

fubarpk
fubarpk on Itch...………...https://fubarpk.itch.io/
fubarpk on googleplay..https://play.google.com/store/apps/developer?id=fubarpk

Back to top

Profile PM Email Website

fubarpk

Retired Moderator

19

Years of Service

User Offline

Joined: 11th Jan 2005

Playing: AGK is my friend

Posted: 21st Dec 2019 19:52 Edited at: 21st Dec 2019 20:08

Link

the main changes

+ Code Snippet

CreateSprites(aTest)
			For num=aTest.length to 0
				aBigTest.sprs1=aTest
				aBigTest.sprs2=aTest
			next num

my complete solution

// Project: test 
// Created: 19-12-21
rem
rem Champions Of Metal
rem

// set window properties
SetWindowTitle( "test" )
SetErrorMode(2)

SetAntialiasMode(0)
SetDisplayAspect(-1)

SetDefaultMagFilter(0)
SetDefaultMinFilter(0)

global screen_width = 300 // 597	417  300x200
global screen_height = 200
global scale as integer = 3
SetVirtualResolution (screen_width, screen_height ) 
SetWindowSize( screen_width * scale, screen_height * scale, 0)
//SetWindowSize( 1024, 768, 0 )

SetOrientationAllowed ( 0, 0, 1, 1 )

type SprStruct
	name as string
	id as integer 
	spr as integer
	spr_clone as integer
endtype
type ArrayOfSpr
	sprs1 as SprStruct[]	
	sprs2 as SprStruct[]	
endtype 
sLog as string[]
btnStart as integer = 0
iRun as integer = 0
aBigTest as ArrayOfSpr
global iTotalSprites as integer
global iTotalImages as integer
aTest as SprStruct[]
do

if(GetPointerReleased() = 1)
		if(aBigTest.sprs1.length <0 )
			sLog	.length = -1
			iRun = iRun + 1
			sLog.insert("Run " + str(iRun))
			
			CreateSprites(aTest)
			For num=aTest.length to 0
				aBigTest.sprs1=aTest
				aBigTest.sprs2=aTest
			next num	
			iTotalSprites = iTotalSprites * 2
			iTotalImages = iTotalImages * 2
			sLog.insert("Create sprites")
			sLog.insert("Total images: " + str(iTotalImages))
			sLog.insert("Total sprites: " + str(iTotalSprites))
		else
	
			Log("DeleteAllSprites")
			DeleteAllSprites()
			Log("DeleteAllImages")
			DeleteAllImages()
			aBigTest.sprs1.length = -1
			aBigTest.sprs2.length = -1
			sLog.insert("Clear all")
			iTotalSprites = 0
			iTotalImages = 0
		endif
	endif
	
	if(sLog.length > -1)
		for i = 0 to sLog.length
			Print(sLog[i])
		next
	endif
    Print( ScreenFPS() )

Sync()
loop

function CreateSprites(aTest ref as SprStruct[])
	for i = 0 to 60
		img = createImg()
		spr = CreateSprite(img)
		iTotalSprites = iTotalSprites + 1
		AddSpriteAnimationFrame(spr, createImg())
		AddSpriteAnimationFrame(spr, createImg())
		AddSpriteAnimationFrame(spr, createImg())
		AddSpriteAnimationFrame(spr, createImg())

SetSpriteShapeCircle(spr, 0,0,20)
		PlaySprite(spr)
		iNew as SprStruct
		iNew.id = i
		iNew.spr = spr
		iNew.spr_clone = CloneSprite(spr)
		iTotalSprites = iTotalSprites + 1
		aTest.insert(iNew)
	next

endfunction

function createImg()
	iTotalImages = iTotalImages + 1
    color=MakeColor(random(1,255),random(1,255),random(1,255),255)
    DrawBox(0,0,64,64,color,color,color,color,1)
    render()
    img = getImage(0,0,64,64)
    SetImageTransparentColor(img,0,0,0)
endfunction img

+ Code Snippet

// Project: test 
// Created: 19-12-21
rem
rem Champions Of Metal
rem

// set window properties
SetWindowTitle( "test" )
SetErrorMode(2)

SetAntialiasMode(0)
SetDisplayAspect(-1)

SetDefaultMagFilter(0)
SetDefaultMinFilter(0)

global screen_width = 300 // 597	417  300x200
global screen_height = 200
global scale as integer = 3
SetVirtualResolution (screen_width, screen_height ) 
SetWindowSize( screen_width * scale, screen_height * scale, 0)
//SetWindowSize( 1024, 768, 0 )

SetOrientationAllowed ( 0, 0, 1, 1 )


type SprStruct
	name as string
	id as integer 
	spr as integer
	spr_clone as integer
endtype
type ArrayOfSpr
	sprs1 as SprStruct[]	
	sprs2 as SprStruct[]	
endtype 
sLog as string[]
btnStart as integer = 0
iRun as integer = 0
aBigTest as ArrayOfSpr
global iTotalSprites as integer
global iTotalImages as integer
aTest as SprStruct[]
do

	if(GetPointerReleased() = 1)
		if(aBigTest.sprs1.length <0 )
			sLog	.length = -1
			iRun = iRun + 1
			sLog.insert("Run " + str(iRun))
			
			CreateSprites(aTest)
			For num=aTest.length to 0
				aBigTest.sprs1=aTest
				aBigTest.sprs2=aTest
			next num	
			iTotalSprites = iTotalSprites * 2
			iTotalImages = iTotalImages * 2
			sLog.insert("Create sprites")
			sLog.insert("Total images: " + str(iTotalImages))
			sLog.insert("Total sprites: " + str(iTotalSprites))
		else
	
			Log("DeleteAllSprites")
			DeleteAllSprites()
			Log("DeleteAllImages")
			DeleteAllImages()
			aBigTest.sprs1.length = -1
			aBigTest.sprs2.length = -1
			sLog.insert("Clear all")
			iTotalSprites = 0
			iTotalImages = 0
		endif
	endif
	
	if(sLog.length > -1)
		for i = 0 to sLog.length
			Print(sLog[i])
		next
	endif
    Print( ScreenFPS() )

    Sync()
loop

function CreateSprites(aTest ref as SprStruct[])
	for i = 0 to 60
		img = createImg()
		spr = CreateSprite(img)
		iTotalSprites = iTotalSprites + 1
		AddSpriteAnimationFrame(spr, createImg())
		AddSpriteAnimationFrame(spr, createImg())
		AddSpriteAnimationFrame(spr, createImg())
		AddSpriteAnimationFrame(spr, createImg())

		SetSpriteShapeCircle(spr, 0,0,20)
		PlaySprite(spr)
		iNew as SprStruct
		iNew.id = i
		iNew.spr = spr
		iNew.spr_clone = CloneSprite(spr)
		iTotalSprites = iTotalSprites + 1
		aTest.insert(iNew)
	next

endfunction

function createImg()
	iTotalImages = iTotalImages + 1
    color=MakeColor(random(1,255),random(1,255),random(1,255),255)
    DrawBox(0,0,64,64,color,color,color,color,1)
    render()
    img = getImage(0,0,64,64)
    SetImageTransparentColor(img,0,0,0)
endfunction img

the problem being aBigTest was type ArrayOfSpr while aTest was SprStruct[] mismatching types with the equals operation

fubarpk
fubarpk on Itch...………...https://fubarpk.itch.io/
fubarpk on googleplay..https://play.google.com/store/apps/developer?id=fubarpk

Back to top

Profile PM Email Website

vennis73

7

Years of Service

User Offline

Joined: 12th Sep 2016

Location:

Posted: 22nd Dec 2019 21:32

Link

@fubarpk thanks for the effor lookin into this.

In your sample

+ Code Snippet

            For num=aTest.length to 0
                aBigTest.sprs1=aTest
                aBigTest.sprs2=aTest
            next num

This doesn't do anything. Its like "for num = 60 to 0"
the spr vars are empty after this, and then the crash isn't triggered (seems really a relation to the number of arrays or something).

I think just

+ Code Snippet

			//For num=aTest.length to 0
				aBigTest.sprs1=aTest
				aBigTest.sprs2=aTest
			//next num

is the result we wanted right ? just to create more mass. And then we get a crash again.

I still don't understand whi it crashes when we add some more arrays of structs that do not contain images or sprites themselves. They just contain integers.
Why would DeleteImages crash if we add some structs that are not directly related to images or sprites ?

Back to top

Profile PM

fubarpk

Retired Moderator

19

Years of Service

User Offline

Joined: 11th Jan 2005

Playing: AGK is my friend

Posted: 22nd Dec 2019 21:53

Link

The problem is aTest is of type sprStruct and aBigtest is of Arrayofspr type which consists of sprStruct arrays
they are all size varying arrays

you could always simplify it by removing
sprs1 as SprStruct[]
sprs2 as SprStruct[]
out of the arrayofsprite

but otherwise it kinda needs to be how I had it

fubarpk
fubarpk on Itch...………...https://fubarpk.itch.io/
fubarpk on googleplay..https://play.google.com/store/apps/developer?id=fubarpk

Back to top

Profile PM Email Website

vennis73

7

Years of Service

User Offline

Joined: 12th Sep 2016

Location:

Posted: 22nd Dec 2019 22:03

Link

i didn't do
aBigtest = aTest

i did
aBigtest.spr1 = aTest

And spr1 and aTest are the same types.
I don't see how it is a problem that spr1 and spr2 are part of a structure themself. IThis seems a total valid construnction to me, and it is, because that copy itself works fine.
That DeleteImages crashes seems related to the amount of structures or something. Or maybe some bug in memory handling in copying structures or references (deep inside AGK).

But beside this structure thing, i don't see how this is relevant at all to DeleteImage crashing since they don't contain images.

Back to top

Profile PM

Sorry your browser is not supported!

AppGameKit Studio Chat / iOs/Android/Win/Mac Random Crash

Attachments

Attachments

Attachments

Attachments