Memblocks cleanup - GameCreators Forum

Author

Message

DannyD

6

Years of Service

User Offline

Joined: 29th Aug 2017

Location:

Posted: 1st Nov 2019 02:45 Edited at: 1st Nov 2019 10:15

Link

Hi Guys
Playing around with Memblocks

creating Memblocks (first image) selected

+ Code Snippet

do
        if getvirtualbuttonpressed(1)
             cleanupMemB()
           loadnewPhonics("1")
        elseif getvirtualbuttonpressed2)
             cleanupMemB()
           loadnewPhonics("2")
       endif

loop

function loadnewPhonics(l as string)
   myimage= LoadImage ( "phonics/"+l+".png" )
   mymemblock= CreateMemblockFromImage ( myimage)
   CreateSprite ( spriteimageid, myimage)
   SetSpritePosition ( spriteimageid, 0, 0 )
endfunction

function cleanupMemB()

 	DeleteMemblock(mymemblock)
  	deletesprite(spriteimageid)
  	deleteimage(myimage)

endfunction

Above code works 100%.
First image display and works 100%

The second image loads very very slow... even that the filesize is smaller than the first
Sometimes it don't even load...

Is there a better way to cleanup the memblock array/memory?

Thanks

Back to top

Profile PM Website

Virtual Nomad

Moderator

18

Years of Service

User Offline

Joined: 14th Dec 2005

Location: SF Bay Area, USA

Posted: 1st Nov 2019 03:18 Edited at: 1st Nov 2019 03:19

Link

is that all the code? AKA, are the variables GLOBALized somewhere else?
(i'm assuming you're loading 1 then 2).

Back to top

Profile PM Website

DannyD

6

Years of Service

User Offline

Joined: 29th Aug 2017

Location:

Posted: 1st Nov 2019 10:14

Link

Hi, not complete code... only a small snippet.
The global and all the others are declared in the program at the top

I assume the problem is when delete the memblock, that's why I only add a piece of snippet to show.
User click 1 or 2 and according to that load the selected sprite into memblock.
But when selecting the second sprite, it just get very slow. Does matter if they select 2 first and then 1, or visa verse

Back to top

Profile PM Website

Bored of the Rings

User Banned

Posted: 1st Nov 2019 11:10

Link

hmmm, depending on the size of a memblock, it takes time to delete larger memblocks so there might be a slight delay when deletion occurs.

Professional Programmer, languages: SAS, C++, SQL, PL-SQL, DBPro, Purebasic, JavaScript, others

Back to top

Profile

Virtual Nomad

Moderator

18

Years of Service

User Offline

Joined: 14th Dec 2005

Location: SF Bay Area, USA

Posted: 1st Nov 2019 17:42 Edited at: 1st Nov 2019 17:47

Link

This is consistent re: time to execute w/ 1080x720 JPGs @ ~240KB:

+ Code Snippet

...

AddVirtualButton(1,100,100,64)
SetVirtualButtonText(1,"1")

AddVirtualButton(2,164,100,64)
SetVirtualButtonText(2,"2")

GLOBAL Spr as Integer
GLOBAL Img as Integer
GLOBAL Mem as Integer

MinMem = GetImageMemoryUsage()

do
    
    For x = 1 to 2
		If GetVirtualButtonPressed(x)
			StartTime# = Timer()
			DoImg(STR(x))
			TotalTime# = Timer()-StartTime#
		EndIf
	Next x
	
    Print( TotalTime# )
    Print( GetImageMemoryUsage()-MinMem)
    If GetMemblockExists(Mem) = 1 then Print (GetMemblockSize(Mem)/1024.0/1024.0)
    Sync()
loop

Function DoImg(FNum$)
	If GetImageExists(Img) then DeleteImage(Img)
	If GetMemblockExists(Mem) then DeleteMemblock(Mem)
	If GetSpriteExists(Spr) then DeleteSprite(Spr)
	
	Img = LoadImage("back_"+FNum$+".jpg")
	Spr = CreateSprite(Img)
	Mem = CreateMemblockFromImage(Img)
EndFunction

TotalTime# varies between 0.05 and 0.09 but i expect the HD might be doing other things 1/2 the time.

IE, i can't replicate

Back to top

Profile PM Website

DannyD

6

Years of Service

User Offline

Joined: 29th Aug 2017

Location:

Posted: 2nd Nov 2019 01:50 Edited at: 2nd Nov 2019 01:54

Link

@Virtual Nomad
Thanks.

I put together a complete example AGKStudio project

What can I do to speed things up.

Most code I found somewhere on the forum, and just add things together... but still I miss something to speed things up.

Appreciate the help

EDITED: The idea behind this is to do floodfill, for a painting APP

Attachments

Login to view attachments

Back to top

Profile PM Website

Kevin Picone

21

Years of Service

User Offline

Joined: 27th Aug 2002

Location: Australia

Posted: 2nd Nov 2019 02:32

Link

DannyD,

I dunno what your goal is, but when working with pixel processing in interpreted languages (and compiled) instruction redundancy is critically important. Depending upon the image size the snippet from your example bellow is wasting millions if not billions of cycles being interpreted..

ie.

+ Code Snippet


		for columns = 1 to img_width
			colour_test = GetPixel ( memBlockInput, columns-1, rows-1, img_width )

                         if colour_test = colour_back
                                  
                                       does lots of  other stuff...  that code was removed

                        endif

               next

function GetPixel ( memBlockIn, x, y, width )
	offsetPixel = 12 + (( x + ( y * width )) * 4 )
	Red = GetMemBlockByte ( memBlockIn, offsetPixel )
	Green = GetMemBlockByte ( memBlockIn, offsetPixel + 1 )
	Blue = GetMemBlockByte ( memBlockIn, offsetPixel + 2 )
	Alpha = GetMemBlockByte ( memBlockIn, offsetPixel + 3 )
	PixelColourRGB = Red + Green + Blue
endfunction PixelColourRGB

Since this bit of code just skimming a linearly laid out chunk of contiguous memory, the GetPixel (among others) has a disproportionate cost at runtime. So that could be inlined.

+ Code Snippet


             // compute address of left most pixel once per row
               offsetPixel = 12 + ((  ( rows * img_width )) * 4 )

		for columns = 1 to img_width

                          // add the RED - GREEN and BLUES together for whatever reason
                       colour_test = GetMemBlockByte (  memBlockInput, offsetPixel )+ GetMemBlockByte (  memBlockInput, offsetPixel + 1 )+ GetMemBlockByte (  memBlockInput, offsetPixel + 2 )

                         if colour_test = colour_back
                                  
                                       does lots of  other stuff...  that code was removed

                        endif
                         // move to the next pixel on this row
                       offsetPixel=offsetPixel+4
               next

That's not going to be express either, but the cost of just skimming the buffer at least 10 instructions per pixel... Which adds up

PlayBASIC To HTML5/WEB - Convert PlayBASIC To Machine Code

Back to top

Profile PM Website

SFSW

21

Years of Service

User Offline

Joined: 9th Oct 2002

Location:

Posted: 2nd Nov 2019 04:47

Link

I second Kevin's advice, it's one of the key methods to improve performance for an operation like that. When running through that many checks, avoid going into and out of a function with so many redundant lookups to perform such an operation. It can make a big difference.

SW3DG | Evochron

Back to top

Profile PM Website

DannyD

6

Years of Service

User Offline

Joined: 29th Aug 2017

Location:

Posted: 2nd Nov 2019 06:46

Link

@Kevin Picone
Following this tutorial to floodfill an image, and detect borders where to stop.
https://forum.thegamecreators.com/thread/213305

Completely new to this, so any advice appreciated

Back to top

Profile PM Website

fubarpk

Retired Moderator

19

Years of Service

User Offline

Joined: 11th Jan 2005

Playing: AGK is my friend

Posted: 2nd Nov 2019 08:51 Edited at: 2nd Nov 2019 08:58

Link

@DannyD I think what they are suggesting it would be better if instead of all those calls and creations of a memblocks
you could refine it by making one memblock of the whole image and then when the floodfill algorithm wants a color
use a bit of math. This would speed up the floodfill algorithm 100fold as it wouldn't need to keep creating memblocks
for every pixel detection

the c interpretation looks like

+ Code Snippet

void floodFill(int x,int y,int oldcolor,int newcolor)
{
	if(getpixel(x,y) == oldcolor)
	{
		putpixel(x,y,newcolor);
		floodFill(x+1,y,oldcolor,newcolor);
		floodFill(x,y+1,oldcolor,newcolor);
		floodFill(x-1,y,oldcolor,newcolor);
		floodFill(x,y-1,oldcolor,newcolor);
	}
}

which is a recursive process and there are faster alternatives
but using the above process getpixel could be calculated from one pre made memblock of the whole image

fubarpk
fubarpk on Itch...………...https://fubarpk.itch.io/
fubarpk on googleplay..https://play.google.com/store/apps/developer?id=fubarpk

Back to top

Profile PM Email Website

DannyD

6

Years of Service

User Offline

Joined: 29th Aug 2017

Location:

Posted: 2nd Nov 2019 09:27

Link

@fubarpk

Thanks, I will look into this. appreciate the help

Back to top

Profile PM Website

fubarpk

Retired Moderator

19

Years of Service

User Offline

Joined: 11th Jan 2005

Playing: AGK is my friend

Posted: 2nd Nov 2019 09:55

Link

your welcome im not sure if using one big memblock would cause a problem with the recursion tho
as I haven't tested it

fubarpk
fubarpk on Itch...………...https://fubarpk.itch.io/
fubarpk on googleplay..https://play.google.com/store/apps/developer?id=fubarpk

Back to top

Profile PM Email Website

Sorry your browser is not supported!

AppGameKit Studio Chat / Memblocks cleanup

Attachments