Movement code help - GameCreators Forum

Author

Message

Satchmo

20

Years of Service

User Offline

Joined: 29th May 2005

Location:

Posted: 20th Aug 2007 18:44 Edited at: 21st Aug 2007 18:50

Link

Hi everybody,
I recently started a pacman clone and I am already running into trouble, I just finished coding my movement code and it only semi works. You see, I'm trying to make the player only move in four directions, and face that direction every time you press a certain key, but when i tested it out, the player would not always go in the right direction. I have looked through my code to find the problem but I am having no luck. I have checked over all the numbers, variables and all the other checks and I have found nothing wrong(except for maybe its extreme inefficiency). Can you please help me and check it over it see if there is something I'm missing?

*note this is not the full code

rem up key
if upkey()=1 and up = 0 and left = 1
 left = 0
  yrotate object 1,90
   move object 1,10
   up = 1
   else
   if upkey()=1 and up = 0 and right = 1
   right = 0
   yrotate object 1,270
   move object 1,10
   up = 1
   else
   if upkey()=1 and up = 0 and down = 1
   down = 0
   yrotate object 1,180
   move object 1,10
   up = 1
  else
 if upkey()=1 and up = 1 then move object 1,10
endif
endif
endif
rem down key
if downkey()=1 and down = 0 and up = 1
 up = 0
  yrotate object 1,180
   move object 1,10
   down = 1
   else
   if downkey()=1 and down = 0 and right = 1
   right = 0
   yrotate object 1,90
   move object 1,10
   down = 1
   else
   if downkey() = 1 and down = 0 and left = 1
   left = 0
   yrotate object 1,270
   move object 1,10
   down = 1
  else
 if downkey() = 1 and down = 1 then move object 1,10
endif
endif
endif
rem left key
if leftkey()=1 and left = 0 and up = 1
 up = 0
  yrotate object 1,270
   move object 1,10
   left = 1
   else
   if leftkey()=1 and left = 0 and right = 1
   right = 0
   yrotate object 1,180
   move object 1,10
   left = 1
   else
   if leftkey()=1 and left = 0 and down = 1
   down = 0
   yrotate object 1,90
   move object 1,10
   left = 1
  else
 if leftkey()=1 and left = 1 then move object 1,10
endif
endif
endif
rem right key
if rightkey() = 1 and right = 0 and up = 1
 up = 0
  yrotate object 1,90
   move object 1,10
   right = 1
   else
   if rightkey() = 1 and right = 0 and down = 1
   down = 0
   yrotate object 1,270
   move object 1,10
   right = 1
   else
   if rightkey() = 1 and right = 0 and left = 1
   left = 0
   yrotate object 1,180
   move object 1,10
   right = 1
  else
 if rightkey() = 1 and right = 1 then move object 1,10
endif
endif
endif

+ Code Snippet

 rem up key
if upkey()=1 and up = 0 and left = 1
 left = 0
  yrotate object 1,90
   move object 1,10
   up = 1
   else
   if upkey()=1 and up = 0 and right = 1
   right = 0
   yrotate object 1,270
   move object 1,10
   up = 1
   else
   if upkey()=1 and up = 0 and down = 1
   down = 0
   yrotate object 1,180
   move object 1,10
   up = 1
  else
 if upkey()=1 and up = 1 then move object 1,10
endif
endif
endif
rem down key
if downkey()=1 and down = 0 and up = 1
 up = 0
  yrotate object 1,180
   move object 1,10
   down = 1
   else
   if downkey()=1 and down = 0 and right = 1
   right = 0
   yrotate object 1,90
   move object 1,10
   down = 1
   else
   if downkey() = 1 and down = 0 and left = 1
   left = 0
   yrotate object 1,270
   move object 1,10
   down = 1
  else
 if downkey() = 1 and down = 1 then move object 1,10
endif
endif
endif
rem left key
if leftkey()=1 and left = 0 and up = 1
 up = 0
  yrotate object 1,270
   move object 1,10
   left = 1
   else
   if leftkey()=1 and left = 0 and right = 1
   right = 0
   yrotate object 1,180
   move object 1,10
   left = 1
   else
   if leftkey()=1 and left = 0 and down = 1
   down = 0
   yrotate object 1,90
   move object 1,10
   left = 1
  else
 if leftkey()=1 and left = 1 then move object 1,10
endif
endif
endif
rem right key
if rightkey() = 1 and right = 0 and up = 1
 up = 0
  yrotate object 1,90
   move object 1,10
   right = 1
   else
   if rightkey() = 1 and right = 0 and down = 1
   down = 0
   yrotate object 1,270
   move object 1,10
   right = 1
   else
   if rightkey() = 1 and right = 0 and left = 1
   left = 0
   yrotate object 1,180
   move object 1,10
   right = 1
  else
 if rightkey() = 1 and right = 1 then move object 1,10
endif
endif
endif

-Thanks in advanced
-fxgamer

Your about to get pwned.

Back to top

Profile PM

Pixelator

17

Years of Service

User Offline

Joined: 8th Jul 2007

Location: here

Posted: 20th Aug 2007 19:08

Link

Too much code

My brain hurts!!!!!!!!

(three days later)

(Y=M*X+B)=(X=(Y-B)/M)=(B=Y-M*X)=(M=Y-B/X)
and if you can figure out what it means i will give you a cookie.

Back to top

Profile PM Email

Satchmo

20

Years of Service

User Offline

Joined: 29th May 2005

Location:

Posted: 20th Aug 2007 19:20 Edited at: 21st Aug 2007 18:50

Link

Dang I was hoping for some help!

Well, I gues in the meantime I could code some other stuff.

Your about to get pwned.

Back to top

Profile PM

TDK

Retired Moderator

22

Years of Service

User Offline

Joined: 19th Nov 2002

Location: UK

Posted: 20th Aug 2007 19:45

Link

Indent your code properly and problems will be much easier to find and we will be much more likely to make an effort to find them!

+ Code Snippet

 
rem up key
if upkey()=1 and up = 0 and left = 1
  left = 0
  yrotate object 1,90
  move object 1,10
  up = 1
else
  if upkey()=1 and up = 0 and right = 1
    right = 0
    yrotate object 1,270
    move object 1,10
    up = 1
  else
    if upkey()=1 and up = 0 and down = 1
      down = 0
      yrotate object 1,180
      move object 1,10
      up = 1
    else
      if upkey()=1 and up = 1 then move object 1,10
    endif
  endif
endif

TDK_Man

* TDK's Game Programming Forums - Open To All - DB & Team Request Boards *

Back to top

Profile PM Email Website

Libervurto

18

Years of Service

User Offline

Joined: 30th Jun 2006

Location: On Toast

Posted: 20th Aug 2007 19:58 Edited at: 20th Aug 2007 20:19

Link

This will only accept unique key presses and will keep Pac-man moving constantly, I've remmed out the IF statement that will mean he only moves when a key is pressed.

Sorry to do all of it for you but I was interested in this

+ Code Snippet

u=upkey() : r=rightkey() : d=downkey() : l=leftkey()
Pacman=1 : Pac_posX=object position x(Pacman) : Pac_posZ=object position z(Pacman)

if u>r+d+l then Pac_dirX=0 : Pac_dirZ=+1 : Pac_angY=0
if r>d+l+u then Pac_dirX=+1 : Pac_dirZ=0 : Pac_angY=90
if d>l+u+r then Pac_dirX=0 : Pac_dirZ=-1 : Pac_angY=180
if l>u+r+d then Pac_dirX=-1 : Pac_dirZ=0 : Pac_angY=270

rem if u+r+l+d = 1
  Pac_posX=Pac_posX+Pac_dirX : Pac_posZ=Pac_posZ+Pac_dirZ
rem endif

yrotate object Pacman,Pac_angY
Position object Pacman,Pac_posX,5,Pac_posZ

I've just made this up in the post so there's no guarantee it will work

[EDIT]
Got the Z direction the wrong way around but apart from that it works fine

Here's a fully functional version:

`-------------------------
`* 3D Pac-Man example
`* By OBese87
`-------------------------
make object cone 1,10
xrotate object 1,90 : fix object pivot 1

matX=200 : matZ=200
make matrix 1,matX,matZ,10,10

position camera matX/2,matZ,-50

hide mouse
sync on

`---------------------------
` MAIN LOOP
`---------------------------
DO
u=upkey() : r=rightkey() : d=downkey() : l=leftkey()
Pacman=1 : Pac_posX=object position x(Pacman) : Pac_posZ=object position z(Pacman)

if u>r+d+l then Pac_dirX=0 : Pac_dirZ=+1 : Pac_angY=0
if r>d+l+u then Pac_dirX=+1 : Pac_dirZ=0 : Pac_angY=90
if d>l+u+r then Pac_dirX=0 : Pac_dirZ=-1 : Pac_angY=180
if l>u+r+d then Pac_dirX=-1 : Pac_dirZ=0 : Pac_angY=270

rem if u+r+l+d = 1
  Pac_posX=Pac_posX+Pac_dirX : Pac_posZ=Pac_posZ+Pac_dirZ
  if Pac_posX<0 then Pac_posX=0
  if Pac_posZ<0 then Pac_posZ=0
  if Pac_posX>matX then Pac_posX=matX
  if Pac_posZ>matZ then Pac_posZ=matZ
rem endif

yrotate object Pacman,Pac_angY
Position object Pacman,Pac_posX,5,Pac_posZ

point camera Pac_posX,5,Pac_posZ
sync
LOOP

+ Code Snippet

`-------------------------
`* 3D Pac-Man example
`* By OBese87
`-------------------------
make object cone 1,10
xrotate object 1,90 : fix object pivot 1

matX=200 : matZ=200
make matrix 1,matX,matZ,10,10

position camera matX/2,matZ,-50

hide mouse
sync on

`---------------------------
` MAIN LOOP
`---------------------------
DO
u=upkey() : r=rightkey() : d=downkey() : l=leftkey()
Pacman=1 : Pac_posX=object position x(Pacman) : Pac_posZ=object position z(Pacman)

if u>r+d+l then Pac_dirX=0 : Pac_dirZ=+1 : Pac_angY=0
if r>d+l+u then Pac_dirX=+1 : Pac_dirZ=0 : Pac_angY=90
if d>l+u+r then Pac_dirX=0 : Pac_dirZ=-1 : Pac_angY=180
if l>u+r+d then Pac_dirX=-1 : Pac_dirZ=0 : Pac_angY=270

rem if u+r+l+d = 1
  Pac_posX=Pac_posX+Pac_dirX : Pac_posZ=Pac_posZ+Pac_dirZ
  if Pac_posX<0 then Pac_posX=0
  if Pac_posZ<0 then Pac_posZ=0
  if Pac_posX>matX then Pac_posX=matX
  if Pac_posZ>matZ then Pac_posZ=matZ
rem endif

yrotate object Pacman,Pac_angY
Position object Pacman,Pac_posX,5,Pac_posZ

point camera Pac_posX,5,Pac_posZ
sync
LOOP

I'm pleased with this, my code has improved so much since joining the forums

If you have any questions about my code please ask.
I will explain a clever trick I have used that I picked up from someone.

+ Code Snippet

if u>r+d+l then Pac_dirX=0 : Pac_dirZ=+1 : Pac_angY=0

this line of code is doing the same as

+ Code Snippet

if upkey()=1 and rightkey()=0 and downkey()=0 and leftkey()=0 then then Pac_dirX=0 : Pac_dirZ=+1 : Pac_angY=0

If you are using lots of ANDs and/or ORs (

) then try to think of ways to do the same statement mathematically

Your signature has been erased by a mod because it was rubbish.

Back to top

Profile PM Email

Satchmo

20

Years of Service

User Offline

Joined: 29th May 2005

Location:

Posted: 21st Aug 2007 02:46 Edited at: 21st Aug 2007 18:50

Link

Thanks OBese87, that's helped me some, I'm going to see if I can write my own movement code based on the same principle. Also when it comes to indentation, I'm clueless.

Your about to get pwned.

Back to top

Profile PM

Libervurto

18

Years of Service

User Offline

Joined: 30th Jun 2006

Location: On Toast

Posted: 21st Aug 2007 14:26 Edited at: 21st Aug 2007 15:07

Link

Quote: "Also when it comes to indentation, I'm clueless"

check out my tutorial on program structure

http://forum.thegamecreators.com/?m=forum_view&t=111855&b=10
I'd actually completely forgotten about it

, must finish it.

You can see how much of a difference good structure and economy makes; your movement code was 92 lines long and mine was 5! I'm not boasting, just pointing out the example

Your signature has been erased by a mod because it was rubbish.

Back to top

Profile PM Email

Satchmo

20

Years of Service

User Offline

Joined: 29th May 2005

Location:

Posted: 21st Aug 2007 15:30 Edited at: 21st Aug 2007 18:50

Link

Yeah but you stacked! Even still yours is much, much shorter, lol.

Your about to get pwned.

Back to top

Profile PM

Libervurto

18

Years of Service

User Offline

Joined: 30th Jun 2006

Location: On Toast

Posted: 21st Aug 2007 15:53

Link

What do you mean by stacked?
The main reason why your code is so long is that you have written statements like MOVE OBJECT for each instance, you should try to make it so you only have one call for things like that each loop.

The forums will help with all that though, it's amazing how fast you learn on here

Your signature has been erased by a mod because it was rubbish.

Back to top

Profile PM Email

Satchmo

20

Years of Service

User Offline

Joined: 29th May 2005

Location:

Posted: 21st Aug 2007 16:16 Edited at: 21st Aug 2007 18:49

Link

Thanks for all your help, I looked through your code and wrote my own based off it, it works pretty well too.

+ Code Snippet

Right = rightkey()
Left = leftkey()
Up = upkey()
Down = downkey()

If Up > 0 then Pacman_angY=0
If Right > 0 then Pacman_angY=90
If Down > 0 then Pacman_angY=180
If Left > 0 then Pacman_angY=270

yrotate object 1,Pacman_angY

If Up+Right+Down+Left = 1 then move object 1,10

[edit] By stacked I mean using stackers : to put more commands on one line[/edit]

Your about to get pwned.

Back to top

Profile PM

Libervurto

18

Years of Service

User Offline

Joined: 30th Jun 2006

Location: On Toast

Posted: 21st Aug 2007 17:17

Link

Nice work, you even got the unique key press thing in there, in a slightly different way.

Quote: "
If Up > 0 then Pacman_angY=0
"

I would have written that ^ like this

Quote: "
If Up = 1 then Pacman_angY=0
"

There's no problem with it, it's just it looks clearer to me

and the fact that Up could only be 0 or 1.

Your signature has been erased by a mod because it was rubbish.

Back to top

Profile PM Email

Satchmo

20

Years of Service

User Offline

Joined: 29th May 2005

Location:

Posted: 21st Aug 2007 18:48

Link

I guess your right, but it works either way really. Ive started writing a camera now and its working great.

Your about to get pwned.

Back to top

Profile PM

Libervurto

18

Years of Service

User Offline

Joined: 30th Jun 2006

Location: On Toast

Posted: 21st Aug 2007 19:12

Link

Quote: "I guess your right, but it works either way really."

Yeah I know, sorry I was just being extra picky

Your code looks much better, you catch on fast!

Your signature has been erased by a mod because it was rubbish.

Back to top

Profile PM Email

Sorry your browser is not supported!

DarkBASIC Discussion / Movement code help