Need feedback for my first application Cd Player.

Author

Message

Game Master1330

16

Years of Service

User Offline

Joined: 19th Oct 2007

Location: (GetReaderXYZ() * 42 ) / 0

Posted: 20th Jan 2008 09:24

Link

Hi,
I have been running round the forums trying to work out how to program but all of a sudden last night it clicked, amazing! (Well actually i read the manual but you know...) anyway so here is my first program!

rem Cd Player
print "Press escape to exit."
print "Please insert a cd."
do
input "Please type in the track number between 1-25 that you wish to play.",tracknumber
if tracknumber=1 then load cdmusic 1,1
if tracknumber=2 then load cdmusic 2,1
if tracknumber=3 then load cdmusic 3,1
if tracknumber=4 then load cdmusic 4,1
if tracknumber=5 then load cdmusic 5,1
if tracknumber=6 then load cdmusic 6,1
if tracknumber=7 then load cdmusic 7,1
if tracknumber=8 then load cdmusic 8,1
if tracknumber=9 then load cdmusic 9,1
if tracknumber=10 then load cdmusic 10,1
if tracknumber=11 then load cdmusic 11,1
if tracknumber=12 then load cdmusic 12,1
if tracknumber=13 then load cdmusic 13,1
if tracknumber=14 then load cdmusic 14,1
if tracknumber=15 then load cdmusic 15,1
if tracknumber=16 then load cdmusic 16,1
if tracknumber=17 then load cdmusic 17,1
if tracknumber=18 then load cdmusic 18,1
if tracknumber=19 then load cdmusic 19,1
if tracknumber=20 then load cdmusic 20,1
if tracknumber=21 then load cdmusic 21,1
if tracknumber=22 then load cdmusic 22,1
if tracknumber=23 then load cdmusic 23,1
if tracknumber=24 then load cdmusic 24,1
if tracknumber=25 then load cdmusic 25,1
play music 1
delete music 1
loop
wait key

+ Code Snippet

rem Cd Player
print "Press escape to exit."
print "Please insert a cd."
do
input "Please type in the track number between 1-25 that you wish to play.",tracknumber
if tracknumber=1 then load cdmusic 1,1
if tracknumber=2 then load cdmusic 2,1
if tracknumber=3 then load cdmusic 3,1
if tracknumber=4 then load cdmusic 4,1
if tracknumber=5 then load cdmusic 5,1
if tracknumber=6 then load cdmusic 6,1
if tracknumber=7 then load cdmusic 7,1
if tracknumber=8 then load cdmusic 8,1
if tracknumber=9 then load cdmusic 9,1
if tracknumber=10 then load cdmusic 10,1
if tracknumber=11 then load cdmusic 11,1
if tracknumber=12 then load cdmusic 12,1
if tracknumber=13 then load cdmusic 13,1
if tracknumber=14 then load cdmusic 14,1
if tracknumber=15 then load cdmusic 15,1
if tracknumber=16 then load cdmusic 16,1
if tracknumber=17 then load cdmusic 17,1
if tracknumber=18 then load cdmusic 18,1
if tracknumber=19 then load cdmusic 19,1
if tracknumber=20 then load cdmusic 20,1
if tracknumber=21 then load cdmusic 21,1
if tracknumber=22 then load cdmusic 22,1
if tracknumber=23 then load cdmusic 23,1
if tracknumber=24 then load cdmusic 24,1
if tracknumber=25 then load cdmusic 25,1
play music 1
delete music 1
loop
wait key

Instructions;
1. Put a cd in.
2. type in the track number.
3. Wait until it plays.
4. To play a different track type in another track number.
5. Press escape to exit anytime you like.

HELP! IM BEEN CHASED BY 12 FIRE CHIKENS!

Back to top

Profile PM Email

SimSmall

20

Years of Service

User Offline

Joined: 7th Aug 2004

Location: United Kingdom

Posted: 21st Jan 2008 19:31 Edited at: 8th Feb 2008 10:06

Link

Well, it's been sort of a long time since I came anywhere near this area of the forum, so I return by offering some helpful improvements you could perhaps make:

Point 1:

Instead of:

+ Code Snippet

if tracknumber = 1 then load cdmusic 1,1
if tracknumber = 2 then load cdmusic 2,1

you could replace the whole 25 line with a single:

+ Code Snippet

load cdmusic tracknumber,1

Point 2:

Although very unlikely, a CD can have more than 25 tracks. Just before loading cdmusic, you can place an if statement to check if the track number specified was valid.

+ Code Snippet

if tracknumber < 1 or tracknumber > get number of cd tracks()
   print "track number specified does not exist" : `Change this caption to anything you feel like
else
   load cdmusic tracknumber,1
endif

Point 3:

having no CD audio cable present in my machine, I can't really check, but I suspect that the music will play for about a few milliseconds before it is deleted... You can force your program to wait while music is playing with the music playing() expression

+ Code Snippet

play music 1
repeat
   `Program is forced wait between repeat and until... until music 1 is no longer playing...
until music playing(1) = 0
delete music 1

Edit: Hopefully you spotted the error in here...
music playing(1) = 1 should indeed have been
music playing(1) = 0 like it now says

Point 4:

your wait key call is never reached, pressing escape exits the program immediately, unless you have disabled the key in advance.

All in all, it's not bad for starter code. I won't show you some of my very first creations, but here are some ways to improve...

Have fun with DBP.

Back to top

Profile PM Email

DB PROgrammer

17

Years of Service

User Offline

Joined: 9th Feb 2007

Location: Nowhere But Everywhere

Posted: 7th Feb 2008 04:19

Link

Well add this to the top of the program:

+ Code Snippet

Sync On         `Turns sync on
Sync Rate 60    `Sets the sync rate to 60
Sync Sleep 1    `Lets windows control how much processor to use

`You don't need this stuff I just like it
Set Display Mode 600,225,32                                      `Sets the display mode to 200x50x32
Set Window On                                                   `Makes the program in windowed mode
Set Window Size 400,150                                         `Sets the size of the window
Set Window Title "Music Player - Created By Game Master1330"    `Add name to aplication
always active on

And after a while of messing around here is what I came up with.

Sync On         `Turns sync on
Sync Rate 60    `Sets the sync rate to 60
Sync Sleep 1    `Lets windows control how much processor to use

`You don't need this stuff I just like it
Set Display Mode 600,225,32                                      `Sets the display mode to 200x50x32
Set Window On                                                   `Makes the program in windowed mode
Set Window Size 400,150                                         `Sets the size of the window
Set Window Title "Music Player - Created By Game Master1330"    `Add name to aplication
always active on

start:
cls
print "Press escape to exit."
print "Please insert a cd."
tracknumber=0
tracknumber$=""
if music exist(1)=1
delete music 1
endif

repeat
tracknumber$=newinput("Please enter a tracknumber to play-->",0,45)
tracknumber=val(tracknumber$)
if get number of cd tracks()<>0
text 0,195,"CD Inserted"
text 0,210,"There are "+str$(get number of cd tracks())+" on this CD"
else
text 0,210,"No CD Inserted"
endif
sync
until tracknumber<>0

if tracknumber < 1 or tracknumber > get number of cd tracks()
   print "track number specified does not exist" : `Change this caption to anything you feel like
   goto start
else
   load cdmusic tracknumber,1
endif
play music 1
repeat
sync
until music playing(1) = 0
goto start

function newinput(printstatement$,x,y)
blank$=""
input$=entry$(1)
text x,y,printstatement$+entry$(1)
if returnkey()=1
clear entry buffer
exitfunction input$
endif
endfunction blank$

+ Code Snippet

Sync On         `Turns sync on
Sync Rate 60    `Sets the sync rate to 60
Sync Sleep 1    `Lets windows control how much processor to use

`You don't need this stuff I just like it
Set Display Mode 600,225,32                                      `Sets the display mode to 200x50x32
Set Window On                                                   `Makes the program in windowed mode
Set Window Size 400,150                                         `Sets the size of the window
Set Window Title "Music Player - Created By Game Master1330"    `Add name to aplication
always active on

start:
cls
print "Press escape to exit."
print "Please insert a cd."
tracknumber=0
tracknumber$=""
if music exist(1)=1
delete music 1
endif

repeat
tracknumber$=newinput("Please enter a tracknumber to play-->",0,45)
tracknumber=val(tracknumber$)
if get number of cd tracks()<>0
text 0,195,"CD Inserted"
text 0,210,"There are "+str$(get number of cd tracks())+" on this CD"
else
text 0,210,"No CD Inserted"
endif
sync
until tracknumber<>0

if tracknumber < 1 or tracknumber > get number of cd tracks()
   print "track number specified does not exist" : `Change this caption to anything you feel like
   goto start
else
   load cdmusic tracknumber,1
endif
play music 1
repeat
sync
until music playing(1) = 0
goto start

function newinput(printstatement$,x,y)
blank$=""
input$=entry$(1)
text x,y,printstatement$+entry$(1)
if returnkey()=1
clear entry buffer
exitfunction input$
endif
endfunction blank$

If it was illegal to be stupid we'd run out of room.

Back to top

Profile PM Email Website

Sorry your browser is not supported!

Newcomers DBPro Corner / Need feedback for my first application Cd Player.