Dice Roller - GameCreators Forum

Author

Message

Zen Master

16

Years of Service

User Offline

Joined: 6th Mar 2008

Location:

Posted: 8th Mar 2008 14:19

Link

Doing a dice rolling game have the basic functions of rolling the dice and before i put in the If I$="N" pressing Y would generate a rolled number, any ideas why it exits the program when i press Y now?

Rem Project: Tester
Rem Created: 3/8/2008 12:49:24 PM

Rem ***** Main Source File *****

Randomize Timer():
Dice=Rnd(7)+1:
CLS
Print "Please Enter Player One Name: ";
Input Name$
Print "Please Enter Player Two Name: ";
Input Name2$
CLS
POne:
Print "Hello ";Name$
Print "Do you want to roll the dice (Y/N)?"
    Repeat: Rem Repeat...Until loop repeats until Y or N key is pressed
      I$=Upper$(Inkey$()): Rem Read the keyboard for keypresses
    Until I$="Y" or I$="N"
    If I$="N":
    Print "Miss A Go"
    Sleep 2000
    Goto Ptwo:
    If I$="Y": Rem If Y was pressed
    Print "You rolled a:"
    Print Dice:
    Sleep 2000
    Goto PTwo:
    PTwo:
Print "Hello ";Name2$
Print "Do you want to roll the dice (Y/N)?"
    Repeat: Rem Repeat...Until loop repeats until Y or N key is pressed
      I$=Upper$(Inkey$()): Rem Read the keyboard for keypresses
    Until I$="Y" or I$="N"
    If I$="N":
    Print "Miss A Go"
    Sleep 2000
    Goto POne:
    If I$="Y": Rem If Y was pressed
    Print "You rolled a:"
    Print Dice:
    Sleep 2000
    Goto Pone:
    If escapekey() = 1 Then End: Rem End the program
 Endif
 Endif
 Endif
 Endif

+ Code Snippet

Rem Project: Tester
Rem Created: 3/8/2008 12:49:24 PM

Rem ***** Main Source File *****

Randomize Timer():
Dice=Rnd(7)+1:
CLS
Print "Please Enter Player One Name: ";
Input Name$
Print "Please Enter Player Two Name: ";
Input Name2$
CLS
POne:
Print "Hello ";Name$
Print "Do you want to roll the dice (Y/N)?"
    Repeat: Rem Repeat...Until loop repeats until Y or N key is pressed
      I$=Upper$(Inkey$()): Rem Read the keyboard for keypresses
    Until I$="Y" or I$="N"
    If I$="N":
    Print "Miss A Go"
    Sleep 2000
    Goto Ptwo:
    If I$="Y": Rem If Y was pressed
    Print "You rolled a:"
    Print Dice:
    Sleep 2000
    Goto PTwo:
    PTwo:
Print "Hello ";Name2$
Print "Do you want to roll the dice (Y/N)?"
    Repeat: Rem Repeat...Until loop repeats until Y or N key is pressed
      I$=Upper$(Inkey$()): Rem Read the keyboard for keypresses
    Until I$="Y" or I$="N"
    If I$="N":
    Print "Miss A Go"
    Sleep 2000
    Goto POne:
    If I$="Y": Rem If Y was pressed
    Print "You rolled a:"
    Print Dice:
    Sleep 2000
    Goto Pone:
    If escapekey() = 1 Then End: Rem End the program
 Endif
 Endif
 Endif
 Endif

Thanks for any replies

Zen

"Face it, if crime didnt pay there would be very few criminals."
Laughton Lewis Burdock

Back to top

Profile PM Email

BMacZero

18

Years of Service

User Offline

Joined: 30th Dec 2005

Location: E:/ NA / USA

Posted: 8th Mar 2008 15:37 Edited at: 8th Mar 2008 15:41

Link

1.) Ahhhg!!!! It's a goto!! Quick, get rid of it before TDK sees!

Seriously though, gosub is faster and better than goto. The only reason they kept goto around was for compatability with older projects where they didn't have gosubs.

2.) You don't need to put colons after every if statement...the only time you need a colon is if you are putting multiple commands on one line. Or if you are declaring a subroutine.

That's weird, though, I can't figure out why it crashes...

Back to top

Profile PM Email Website

BMacZero

18

Years of Service

User Offline

Joined: 30th Dec 2005

Location: E:/ NA / USA

Posted: 8th Mar 2008 15:44

Link

Ah, I found it! It's because you put all your endifs at the very end. Basically, it wasn't even checking for a press of Y unless you pressed N! Then it was skipping over the rest because you hadn't pressed Y. Hard to explain, but just look at the new code.

Your code should look like this:

Rem Project: Tester
Rem Created: 3/8/2008 12:49:24 PM

Rem ***** Main Source File *****

Randomize Timer():
Dice=Rnd(7)+1:
CLS
Print "Please Enter Player One Name: ";
Input Name$
Print "Please Enter Player Two Name: ";
Input Name2$
CLS
POne:
Print "Hello ";Name$
Print "Do you want to roll the dice (Y/N)?"
    Repeat: Rem Repeat...Until loop repeats until Y or N key is pressed
      I$=Upper$(Inkey$()): Rem Read the keyboard for keypresses
    Until I$="Y" or I$="N"
    If I$="N"
        Print "Miss A Go"
        Sleep 2000
        Gosub Ptwo
    endif
    If I$="Y": Rem If Y was pressed
        Print "You rolled a:"
        Print Dice
        Sleep 2000
        Gosub PTwo
    endif
PTwo:
Print "Hello ";Name2$
Print "Do you want to roll the dice (Y/N)?"
    Repeat: Rem Repeat...Until loop repeats until Y or N key is pressed
      I$=Upper$(Inkey$()): Rem Read the keyboard for keypresses
    Until I$="Y" or I$="N"
    If I$="N":
        Print "Miss A Go"
        Sleep 2000
        Gosub POne
    endif
    If I$="Y": Rem If Y was pressed
        Print "You rolled a:"
        Print Dice:
        Sleep 2000
        Gosub POne
    endif
    If escapekey() = 1 Then End: Rem End the program

+ Code Snippet

Rem Project: Tester
Rem Created: 3/8/2008 12:49:24 PM

Rem ***** Main Source File *****

Randomize Timer():
Dice=Rnd(7)+1:
CLS
Print "Please Enter Player One Name: ";
Input Name$
Print "Please Enter Player Two Name: ";
Input Name2$
CLS
POne:
Print "Hello ";Name$
Print "Do you want to roll the dice (Y/N)?"
    Repeat: Rem Repeat...Until loop repeats until Y or N key is pressed
      I$=Upper$(Inkey$()): Rem Read the keyboard for keypresses
    Until I$="Y" or I$="N"
    If I$="N"
        Print "Miss A Go"
        Sleep 2000
        Gosub Ptwo
    endif
    If I$="Y": Rem If Y was pressed
        Print "You rolled a:"
        Print Dice
        Sleep 2000
        Gosub PTwo
    endif
PTwo:
Print "Hello ";Name2$
Print "Do you want to roll the dice (Y/N)?"
    Repeat: Rem Repeat...Until loop repeats until Y or N key is pressed
      I$=Upper$(Inkey$()): Rem Read the keyboard for keypresses
    Until I$="Y" or I$="N"
    If I$="N":
        Print "Miss A Go"
        Sleep 2000
        Gosub POne
    endif
    If I$="Y": Rem If Y was pressed
        Print "You rolled a:"
        Print Dice:
        Sleep 2000
        Gosub POne
    endif
    If escapekey() = 1 Then End: Rem End the program

Back to top

Profile PM Email Website

IanM

Retired Moderator

22

Years of Service

User Offline

Joined: 11th Sep 2002

Location: In my moon base

Posted: 8th Mar 2008 16:52

Link

GOTO and GOSUB are not equivalent and one can't replace the other. You should also make sure that every GOSUB has an equivalent RETURN statement somewhere.

Anyhow, I've removed all GOTO/GOSUB commands from the code - they just aren't necessary for this code:

+ Code Snippet

Rem Project: Tester
Rem Created: 3/8/2008 12:49:24 PM

Rem ***** Main Source File *****

Randomize Timer():
Dice=Rnd(7)+1:
CLS
Print "Please Enter Player One Name: ";
Input Name$

Print "Please Enter Player Two Name: ";
Input Name2$
CLS

do
   Print "Hello ";Name$
   Print "Do you want to roll the dice (Y/N)?"
   Repeat: Rem Repeat...Until loop repeats until Y or N key is pressed
      I$=Upper$(Inkey$()): Rem Read the keyboard for keypresses
   Until I$="Y" or I$="N"
   If I$="Y": Rem If Y was pressed
      Print "You rolled a:"
      Print Dice
   else
      Print "Miss A Go"
   endif
   Sleep 2000

   Print "Hello ";Name2$
   Print "Do you want to roll the dice (Y/N)?"
   Repeat: Rem Repeat...Until loop repeats until Y or N key is pressed
      I$=Upper$(Inkey$()): Rem Read the keyboard for keypresses
   Until I$="Y" or I$="N"
   If I$="Y": Rem If Y was pressed
      Print "You rolled a:"
      Print Dice:
   else
      Print "Miss A Go"
   endif
   Sleep 2000
loop

You could go further and put the common code into a function too, but I'll leave that for now.

[b]Utility plugins collection (updated 28/02/08) and
http://www.matrix1.demon.co.uk

Back to top

Profile PM Email Website

Zen Master

16

Years of Service

User Offline

Joined: 6th Mar 2008

Location:

Posted: 8th Mar 2008 18:17

Link

Thanks Guys!!! Got it all running, re read up on If statements to make sure i get em!!

Im know this is poor layout etc... but it just helps me get to grips with it this is my first code so here we go after fixing it up we have

Rem Project: Tester
Rem Created: 3/8/2008 12:49:24 PM

Rem ***** Main Source File *****

Randomize Timer():
   Dice=Rnd(7)+1:
   Dice2=Rnd(7)+1:

CLS
   Print "Please Enter Player One Name: ";
   Input Name$
   Print "Please Enter Player Two Name: ";
   Input Name2$
   CLS

POne:
   Print "Hello ";Name$
   Print "It is your turn to roll the dice (Y/N)?"
   Repeat: Rem Repeat... loop repeats until Y or N key is pressed
   I$=Upper$(Inkey$()): Rem Read the keyboard for keypresses
   Until I$="Y" or I$="N"
   If I$="Y": Rem If Y was pressed
   Print "You rolled a:"
   Print Dice:
   Sleep 2000
   Goto PTwoguess:
   Else
   Goto close:
   Endif

POneguess:
   Print "Hello ";Name$
   Print "Will you roll higher or lower (H/L)?"
   Repeat:
   I$=Upper$(Inkey$()):
   Until I$="H" or I$="L"
   If I$="H" Then Goto POnerollH:
   If I$="L" Then Goto POnerollL:

POnerollH:
    Print "You rolled a:"
    Print Dice2:
    Sleep 2000
    If Dice1 > Dice2
    Print "Congratulations!! You Guessed Right!"
    Sleep 500
    Goto POne:
    Else
    Print "Unlucky"
    Print "Commencing Next Round"
    Goto POne:
    Endif

POnerollL:
    Print "You rolled a:"
    Print Dice1:
    Sleep 2000
    If Dice1 < Dice2
    Print "Congratulations!! You Guessed Right!"
    Sleep 500
    Goto POne:
    Else
    Print "Unlucky"
    Print "Commencing Next Round"
    Goto POne:
    Endif

PTwo:
    Print "Hello ";Name2$
    Print "It is your turn to roll the dice (Y/N)?"
    Repeat: Rem Repeat... loop repeats until Y or N key is pressed
    I$=Upper$(Inkey$()): Rem Read the keyboard for keypresses
    Until I$="Y" or I$="N"
    If I$="Y": Rem If Y was pressed
    Print "You rolled a:"
    Print Dice:
    Sleep 2000
    Goto POneguess:
    Else
    Goto close:
    Endif

PTwoguess:
   Print "Hello ";Name2$
   Print "Will you roll higher or lower (H/L)?"
   Repeat:
   I$=Upper$(Inkey$()):
   Until I$="H" or I$="L"
   If I$="H" Then Goto PTworollH:
   If I$="L" Then Goto PTworollL:

PTworollH:
    Print "You rolled a:"
    Print Dice2:
    Sleep 2000
    If Dice2 > Dice1
    Print "Congratulations!! You Guessed Right!"
    Sleep 500
    Goto PTwo:
    Else
    Print "Unlucky"
    Print "Commencing Next Round"
    Goto PTwo:
    Endif

PTworollL:
    Print "You rolled a:"
    Print Dice2:
    Sleep 2000
    If Dice2 < Dice1
    Print "Congratulations!! You Guessed Right!"
    Sleep 500
    Goto PTwo:
    Else
    Print "Unlucky"
    Print "Commencing Next Round"
    Goto PTwo:
    Endif

close:
    Print "Thanks For Playing"
    Sleep 1000
    End: Rem End the program

+ Code Snippet

Rem Project: Tester
Rem Created: 3/8/2008 12:49:24 PM

Rem ***** Main Source File *****

   Randomize Timer():
   Dice=Rnd(7)+1:
   Dice2=Rnd(7)+1:

   CLS
   Print "Please Enter Player One Name: ";
   Input Name$
   Print "Please Enter Player Two Name: ";
   Input Name2$
   CLS

POne:
   Print "Hello ";Name$
   Print "It is your turn to roll the dice (Y/N)?"
   Repeat: Rem Repeat... loop repeats until Y or N key is pressed
   I$=Upper$(Inkey$()): Rem Read the keyboard for keypresses
   Until I$="Y" or I$="N"
   If I$="Y": Rem If Y was pressed
   Print "You rolled a:"
   Print Dice:
   Sleep 2000
   Goto PTwoguess:
   Else
   Goto close:
   Endif

POneguess:
   Print "Hello ";Name$
   Print "Will you roll higher or lower (H/L)?"
   Repeat:
   I$=Upper$(Inkey$()):
   Until I$="H" or I$="L"
   If I$="H" Then Goto POnerollH:
   If I$="L" Then Goto POnerollL:

POnerollH:
    Print "You rolled a:"
    Print Dice2:
    Sleep 2000
    If Dice1 > Dice2
    Print "Congratulations!! You Guessed Right!"
    Sleep 500
    Goto POne:
    Else
    Print "Unlucky"
    Print "Commencing Next Round"
    Goto POne:
    Endif

POnerollL:
    Print "You rolled a:"
    Print Dice1:
    Sleep 2000
    If Dice1 < Dice2
    Print "Congratulations!! You Guessed Right!"
    Sleep 500
    Goto POne:
    Else
    Print "Unlucky"
    Print "Commencing Next Round"
    Goto POne:
    Endif

PTwo:
    Print "Hello ";Name2$
    Print "It is your turn to roll the dice (Y/N)?"
    Repeat: Rem Repeat... loop repeats until Y or N key is pressed
    I$=Upper$(Inkey$()): Rem Read the keyboard for keypresses
    Until I$="Y" or I$="N"
    If I$="Y": Rem If Y was pressed
    Print "You rolled a:"
    Print Dice:
    Sleep 2000
    Goto POneguess:
    Else
    Goto close:
    Endif

PTwoguess:
   Print "Hello ";Name2$
   Print "Will you roll higher or lower (H/L)?"
   Repeat:
   I$=Upper$(Inkey$()):
   Until I$="H" or I$="L"
   If I$="H" Then Goto PTworollH:
   If I$="L" Then Goto PTworollL:

PTworollH:
    Print "You rolled a:"
    Print Dice2:
    Sleep 2000
    If Dice2 > Dice1
    Print "Congratulations!! You Guessed Right!"
    Sleep 500
    Goto PTwo:
    Else
    Print "Unlucky"
    Print "Commencing Next Round"
    Goto PTwo:
    Endif

PTworollL:
    Print "You rolled a:"
    Print Dice2:
    Sleep 2000
    If Dice2 < Dice1
    Print "Congratulations!! You Guessed Right!"
    Sleep 500
    Goto PTwo:
    Else
    Print "Unlucky"
    Print "Commencing Next Round"
    Goto PTwo:
    Endif

close:
    Print "Thanks For Playing"
    Sleep 1000
    End: Rem End the program

It all works but for some strange reason this

+ Code Snippet

PTworollL:
    Print "You rolled a:"
    Print Dice2:
    Sleep 2000
    If Dice2 < Dice1
    Print "Congratulations!! You Guessed Right!"
    Sleep 500
    Goto PTwo:
    Else
    Print "Unlucky"
    Print "Commencing Next Round"
    Goto PTwo:
    Endif

Still shows up as Unlucky Commnecing Next Round when getting a lower number than player one

Please help
Thanks
Zen

"Face it, if crime didnt pay there would be very few criminals."
Laughton Lewis Burdock

Back to top

Profile PM Email

TDK

Retired Moderator

21

Years of Service

User Offline

Joined: 19th Nov 2002

Location: UK

Posted: 8th Mar 2008 18:43

Link

IanM showed you how to do it properly, so why have you reverted back to that spaghetti code mess using Goto?

I suggest that the majority of your current problems are down to this and unless you learn how to write your programs procedurally, the problems will only increase in the future.

Once again I suggest you read tutorials 1 to 4 here:

http://forum.thegamecreators.com/?m=forum_view&t=99497&b=10

And bmaczero explained about the colons - but they are still there!

In your last thread I told you that you shouldn't put semicolons on the end of every line and to read some beginners tutorials. Now your code has colons on the end of lines and as that's not in any of the tutorials I suggested you read, I have to assume that you didn't bother reading them.

If you ask questions then completely ignore our advice then don't be surprised if in the future no-one bothers to answer them.

TDK_Man

* TDK's Game Programming Forums - Open To All - DB & Team Request Boards *

Back to top

Profile PM Email Website

Sorry your browser is not supported!

Newcomers DBPro Corner / Dice Roller