get image problem - GameCreators Forum

Author

Message

Captain America

20

Years of Service

User Offline

Joined: 8th Apr 2005

Location: Here

Posted: 28th May 2008 03:08

Link

I have a small game where you can draw your own character on the screen and then play with it in the game.

However when I use the get image command it does not copy the things that you drew and only the white box behind it.

How can I fix this?

sync on : sync rate 0
set display mode 1024,768,32
sw = screen width()
sh = screen height()
white = rgb(500,500,500)

cls white
ink rgb(0,0,0),1
center text sw/2,10,"Draw Your Character"
ink rgb(0,0,0),1
box sw/2-100,sh/2-200,sw/2+100,sh/2+40
ink rgb(500,500,500),1
box sw/2-95,sh/2-195,sw/2+95,sh/2+35
ink rgb(0,0,0),1
center text sw/2,sh/2+60,"Press Enter When Finsihed"
do
if mouseclick() = 1
   dot mousex(),mousey()+1
   dot mousex(),mousey()+2
   dot mousex()+1,mousey()
   dot mousex()+2,mousey()
   dot mousex()+3,mousey()+1
   dot mousex()+3,mousey()+2
   dot mousex()+1,mousey()+3
   dot mousex()+2,mousey()+3
   dot mousex()+1,mousey()+1
   dot mousex()+2,mousey()+2
   dot mousex()+2,mousey()+1
   dot mousex()+1,mousey()+2
endif

if returnkey() = 1
   exit
   wait 100
endif
sync
loop
get image 1,sw/2-95,sh/2-195,sw/2+95,sh/2+35

cls rgb(500,500,500)

do
cls rgb(500,500,500)

if leftkey() = 1
   dec X
endif

if rightkey() = 1
   inc X
endif

if upkey() = 1
   dec Y
endif

if downkey() = 1
   inc Y
endif

sprite 1,X,Y,1
print X
print Y
sync
loop

+ Code Snippet

sync on : sync rate 0
set display mode 1024,768,32
sw = screen width()
sh = screen height()
white = rgb(500,500,500)

cls white
ink rgb(0,0,0),1
center text sw/2,10,"Draw Your Character"
ink rgb(0,0,0),1
box sw/2-100,sh/2-200,sw/2+100,sh/2+40
ink rgb(500,500,500),1
box sw/2-95,sh/2-195,sw/2+95,sh/2+35
ink rgb(0,0,0),1
center text sw/2,sh/2+60,"Press Enter When Finsihed"
do
if mouseclick() = 1
   dot mousex(),mousey()+1
   dot mousex(),mousey()+2
   dot mousex()+1,mousey()
   dot mousex()+2,mousey()
   dot mousex()+3,mousey()+1
   dot mousex()+3,mousey()+2
   dot mousex()+1,mousey()+3
   dot mousex()+2,mousey()+3
   dot mousex()+1,mousey()+1
   dot mousex()+2,mousey()+2
   dot mousex()+2,mousey()+1
   dot mousex()+1,mousey()+2
endif

if returnkey() = 1
   exit
   wait 100
endif
sync
loop
get image 1,sw/2-95,sh/2-195,sw/2+95,sh/2+35

cls rgb(500,500,500)

do
cls rgb(500,500,500)

if leftkey() = 1
   dec X
endif

if rightkey() = 1
   inc X
endif

if upkey() = 1
   dec Y
endif

if downkey() = 1
   inc Y
endif

sprite 1,X,Y,1
print X
print Y
sync
loop

Thanks!

Cheers,
Capt. America

Back to top

Profile PM Email Website

TDK

Retired Moderator

22

Years of Service

User Offline

Joined: 19th Nov 2002

Location: UK

Posted: 28th May 2008 04:40 Edited at: 28th May 2008 04:44

Link

Quote: "How can I fix this?"

What about the other problems?...

1. Set the display mode first - before turning Sync on as Set Display Mode re-initialises everything and can cause problems.

2. RGB values go up to 255 - not 500.

3. "ink rgb(0,0,0),1" <<< Do you understand what this does? Look Ink up in the help files. Read up on colours.

4. What do you see if you place a sprite which is black on a white background on top of a white screen? Answer - nothing, which is exactly what you were getting...

+ Code Snippet

set display mode 1024,768,32
sync on : sync rate 0
sw = screen width()
sh = screen height()
white = rgb(255,255,255)

cls white
ink 0,0
center text sw/2,10,"Draw Your Character"
box sw/2-100,sh/2-200,sw/2+100,sh/2+40
ink white,1
box sw/2-95,sh/2-195,sw/2+95,sh/2+35

rem Ink rgb(0,0,0),1: Rem <<< Here was your problem. Black in a sprite is transparent.
Ink rgb(20,20,20),0: Rem <<< This looks black but isn't so is not transparent
center text sw/2,sh/2+60,"Press Enter When Finsihed"
Repeat
  Mx=MouseX(): My=MouseY(): Mc=MouseClick()
  if Mc = 1
    Box Mx-1,My,Mx+2,My+1
    Box Mx,My-1,Mx+1,My+2
  endif
  sync
Until returnkey() = 1
get image 1,sw/2-95,sh/2-195,sw/2+95,sh/2+35
Set Text Opaque
CLS White
do
  if leftkey() = 1 Then dec X
  if rightkey() = 1 Then inc X
  if upkey() = 1 Then dec Y
  if downkey() = 1 Then inc Y
  sprite 1,X,Y,1
  sync
  Ink 0,white: Text 0,0,Str$(X)+"  "+Str$(Y)+"   "
loop

TDK_Man

* TDK's Game Programming Forums - Open To All - DB & Team Request Boards *

Back to top

Profile PM Email Website

BN2 Productions

21

Years of Service

User Offline

Joined: 22nd Jan 2004

Location:

Posted: 28th May 2008 05:11

Link

your problem:

DBC Automatically displays the color black as transparent. White bounding box with transparent character over a white background just looks like white.

solution:
1. Instead of coloring with rgb(0,0,0) use rgb(1,1,1). Looks the same, just doesn't get set as transparent

OR

2. Use the SET SPRITE command to disable the transparency

Ever notice how in Microsoft word, the word "microsoft" is auto corrected to be "Microsoft" but "macintosh" just gets the dumb red underline?

Back to top

Profile PM

TDK

Retired Moderator

22

Years of Service

User Offline

Joined: 19th Nov 2002

Location: UK

Posted: 28th May 2008 06:07

Link

There's an echo in here...

Quote: "Use the SET SPRITE command to disable the transparency"

Changing the colour is the better option as the Sprite command is being used in the main Do..Loop and Set Sprite would need to be called every time too.

TDK_Man

* TDK's Game Programming Forums - Open To All - DB & Team Request Boards *

Back to top

Profile PM Email Website

Captain America

20

Years of Service

User Offline

Joined: 8th Apr 2005

Location: Here

Posted: 28th May 2008 08:15

Link

@ALL

wow that was pretty rookie mistake!

Thanks for all the help!

@TDK

Does it affect the program at all if you use rgb(500,0,0) as opposed
to rgb(255,0,0)?

What is the difference?
Because it works the same for me.

Thanks again it would have taken me a LONG time to figure this out by myself!

Thanks again!

Cheers,
Capt. America

Back to top

Profile PM Email Website

Latch

18

Years of Service

User Offline

Joined: 23rd Jul 2006

Location:

Posted: 28th May 2008 08:38 Edited at: 28th May 2008 08:40

Link

Quote: "Changing the colour is the better option as the Sprite command is being used in the main Do..Loop and Set Sprite would need to be called every time too."

I'm gonna have to disagree with TDK on this one, though it also depends on the ultimate goal

Setting the transparency off will help solve the problem in this case - and if transparency is not needed, I think it should be a rule of thumb to turn it off; also Set Sprite only has to be called once for a sprite unless you delete the sprite. Plus turning off transparency if you don't need it improves performance as the number of sprites increase (you get a significant performance increase if you handle the redraw yourself also) Here's an example:

+ Code Snippet

set display mode 800,600,32
sync on
sync rate 0

cls 255
ink 0,0
box 40,40,80,80
get image 1,0,0,121,121

cls rgb(255,255,255)
sprite 1,-900,-900,1
set sprite 1,1,1

do
   cls
   text 0,0,"press space key to disable transparency and redraw"
   text 0,20,str$(screen fps())
   if spacekey()=1
      set sprite 1,0,0
      repeat
         sync
      until spacekey()=0
   endif

   sprite 1,200,200,1

   sync

loop

And in regards to using get image: without a sync following it, it often results in the image not being captured properly in my experience.

Enjoy your day.

Back to top

Profile PM

TDK

Retired Moderator

22

Years of Service

User Offline

Joined: 19th Nov 2002

Location: UK

Posted: 28th May 2008 10:21 Edited at: 28th May 2008 10:26

Link

I regarded changing the colour better only because you do it once - each time the Sprite command is used in the loop, it has to be followed by a Set Sprite command to turn transparency off.

I regard this worse than changing the colour once when creating the sprite image and leaving transparency on.

However, I doubt the difference in speed doing this would be much different than leaving it black and having two sprite commands called each time around the loop. Well not enough to warrant writing a program to benchmark it anyway!

Quote: "Set Sprite only has to be called once for a sprite unless you delete the sprite"

Strange... that's what I thought, but I tried that first and unless it was called repeatedly it didn't work. If you are right and I just had a glitch with V1.2.0, then I'm with you 100% on yours being the better way.

Quote: "What is the difference?
Because it works the same for me."

It isn't the same - they are different colours:

+ Code Snippet

Ink RGB(255,255,255),0: Box 0,0,319,479
Ink RGB(500,500,500),0: Box 320,0,639,479
Wait Key

RGB(500,500,500) is the same colour as RGB(245,245,245) - slightly darker than white.

TDK_Man

* TDK's Game Programming Forums - Open To All - DB & Team Request Boards *

Back to top

Profile PM Email Website

Libervurto

18

Years of Service

User Offline

Joined: 30th Jun 2006

Location: On Toast

Posted: 28th May 2008 21:40

Link

rgb(1,1,1) will still register as black although it depends on bit depth how bright the colour has to be before it's not seen as black.

rgb values loop after 255 (256 is black)
having 500 is unnecessary and will produce some funny results if you try doing any maths on the colours.

It is far better to complete a 10 line program than to start a 10,000 line program.

Back to top

Profile PM Email

Captain America

20

Years of Service

User Offline

Joined: 8th Apr 2005

Location: Here

Posted: 29th May 2008 07:29

Link

ok ill just stick to 255 then.

Thanks for all the help guys!

Cheers,
Capt. America

Back to top

Profile PM Email Website

Sorry your browser is not supported!

DarkBASIC Discussion / get image problem