Character not moving? - GameCreators Forum

Author

Message

Zeus

18

Years of Service

User Offline

Joined: 8th Jul 2006

Location: Atop Mount Olympus

Posted: 8th Jul 2008 18:42

Link

I am setting up something to where when you press spacebar he moves up, it is the highly remarked code, I made it easier for you (and me) to find.

Code:

+ Code Snippet

`Started July 8th 2008

`Screen Setup
set display mode 800,600,32
hide mouse


`Level Placing 
load animation "media\animations\getready3.avi",1
place animation 1,200,100,600,400
play animation 1
wait 2000
gosub level01


`Begin Level 1

level01:

`Staircase
load image "media\lvl01\staircaseLEVEL01.png",1
sprite 1,100,100,1


`Character Attributes
x=590 : `Position X
y=383 : `Position Y
energy#=0 : `Energy
strength#=0 : `Strength
score#=0 : `Current Score

load image "media\characters\1\normal.png",2 : `Character 1 Stand
load image "media\characters\1\crouch.png",3 : `Character 1 Crouch

sprite 2,x,y,2 : `Normal Character Sprite
sprite 3,x,y,3 : `Crouch Character Sprite
hide sprite 3 : `Hide Crouch Until Space Pressed



`Level 1 Loop
do

`To Jump Up
if spacekey()=1 then y=y-10

`To Crouch
if returnkey()=1
hide sprite 2
show sprite 3
crouched=1
endif

`To Stop Crouch
if crouched=1 and returnkey()=0
hide sprite 3
show sprite 2
endif 
loop
return

What am I doing wrong?

Thanks,
~Zeus~

Back to top

Profile PM Email

Ed222

17

Years of Service

User Offline

Joined: 3rd Nov 2007

Location: Calgary

Posted: 8th Jul 2008 18:50 Edited at: 8th Jul 2008 19:00

Link

I can't seem to find the problem could you tell us whats wrong?
BTW why are you using 2 sprites for 1 character?

Back to top

Profile PM Email

Robert The Robot

18

Years of Service

User Offline

Joined: 8th Jan 2007

Location: Fireball XL5

Posted: 8th Jul 2008 19:02 Edited at: 8th Jul 2008 19:03

Link

The command:
if spacekey()=1 then y=y-10
is what you're doing wrong - the instant the user hits the space bar, the characters y-coord is decreased by 10 every time the program loops. The result is that the character will almost immediately vanish off screen.

What you need is some kind of "gravity" that slows the player going up, and then pulls him down again. For example:

+ Code Snippet

If spacekey() = 1
   rem Only allow the player to jump if jumping is not being processed
   If Jumping = 0
      Jumping = 1
      Gravity = 10
   endif
else
   Jumping = 0
endif

If Jumping = 1
   rem Going up, so increase y
   If Gravity > 0
      y = y+1
      Gravity = Gravity-1
   endif

   rem We've reached the op of the bounce, so down we go
   If Gravity < 0
      y = y-1
      Gravity = Gravity - 1
   endif

   rem When the player is back where he started, Gravity will have
   rem been reduced by one more than expected (henbce the -11
   rem not -10).  The bounce is over, reset jump variables
   If Gravity = -11
      Jumping = 0
   endif
endif

Of course, if you want the player to "stick" to the staircase sprite mentioned in your code, you can always check for "Sprite Hit" (or is it sprite collision? I'm afraid I've never been able to figure out the difference

). If there is a collision, just set the variable jumping to 0 to freeze the y-coord where it already is.

By the way, I just noticed - you're using two different sprites for the normal and crouch positions. You only need to use the one sprite for a character, and just change which image the sprite uses.

Hope this helps!

Edit: Blimey, took so long typing that someone beat me to it!

It is said there are 10 types of people in this world - those who understand binary, and those who have friends!

Back to top

Profile PM Website

Zeus

18

Years of Service

User Offline

Joined: 8th Jul 2006

Location: Atop Mount Olympus

Posted: 8th Jul 2008 19:04

Link

One is crouch and one is stand.

Here is the code I was talking about,

+ Code Snippet

`To Jump Up
if spacekey()=1 then y=y-10

Back to top

Profile PM Email

Zeus

18

Years of Service

User Offline

Joined: 8th Jul 2006

Location: Atop Mount Olympus

Posted: 8th Jul 2008 19:07

Link

@Tha_Rami: It still doesn't move....

Back to top

Profile PM Email

Robert The Robot

18

Years of Service

User Offline

Joined: 8th Jan 2007

Location: Fireball XL5

Posted: 8th Jul 2008 19:13 Edited at: 8th Jul 2008 19:31

Link

Quote: "@Tha_Rami: It still doesn't move.... "

Do you mean me, or did you mean to post on another topic?

Actually, just realised I made a mistake - Y numbers are 0 at the top of the screen, and increase going down. My code snippet should read like this:

+ Code Snippet

If spacekey() = 1
   rem Only allow the player to jump if jumping is not being processed
   If Jumping = 0
      Jumping = 1
      Gravity = 10
   endif
else
   Jumping = 0
endif

If Jumping = 1
   rem Going up, so increase y
   If Gravity > 0
      y = y-1
      Gravity = Gravity-1
   endif

   rem We've reached the op of the bounce, so down we go
   If Gravity < 0
      y = y+1
      Gravity = Gravity - 1
   endif

   rem When the player is back where he started, Gravity will have
   rem been reduced by one more than expected (henbce the -11
   rem not -10).  The bounce is over, reset jump variables
   If Gravity = -11
      Jumping = 0
   endif
endif

Oops!

Edit
Oh, <slaps head>. I've just realised why nothing's moving.

You need to put the commands:

+ Code Snippet

Sprite 2, x, y, 2
Sprite 3, x, y, 3

inside your Do-Loop block. Otherwise, your sprites never get updated!

It is said there are 10 types of people in this world - those who understand binary, and those who have friends!

Back to top

Profile PM Website

Zeus

18

Years of Service

User Offline

Joined: 8th Jul 2006

Location: Atop Mount Olympus

Posted: 8th Jul 2008 19:29

Link

Still doesn't work.

Back to top

Profile PM Email

Ed222

17

Years of Service

User Offline

Joined: 3rd Nov 2007

Location: Calgary

Posted: 8th Jul 2008 19:46 Edited at: 8th Jul 2008 19:53

Link

oh man how could I have missed it!

i use 2d all the time. anyways Robert The Robot is right you have to make your guy come down but you also need a sync and a cls at the end of the loop also don't forget sync on so it should look like this

+ Code Snippet

`Started July 8th 2008
`turns sync on
sync on : sync rate 60
`Screen Setup
set display mode 800,600,32
hide mouse


`Level Placing 
load animation "mediaanimationsgetready3.avi",1
place animation 1,200,100,600,400
play animation 1
wait 2000
gosub level01


`Begin Level 1

level01:

`Staircase
load image "medialvl01staircaseLEVEL01.png",1
sprite 1,100,100,1


`Character Attributes
x=590 : `Position X
y=383 : `Position Y
energy#=0 : `Energy
strength#=0 : `Strength
score#=0 : `Current Score

load image "mediacharacters1normal.png",2 : `Character 1 Stand
load image "mediacharacters1crouch.png",3 : `Character 1 Crouch

sprite 2,x,y,2 : `Normal Character Sprite
sprite 3,x,y,3 : `Crouch Character Sprite
hide sprite 3 : `Hide Crouch Until Space Pressed



`Level 1 Loop
do
Sprite 2, x, y, 2
Sprite 3, x, y, 3
`your code
sync
cls
loop
return

BTW you should make your 2 sprites into 1

Back to top

Profile PM Email

Zeus

18

Years of Service

User Offline

Joined: 8th Jul 2006

Location: Atop Mount Olympus

Posted: 8th Jul 2008 19:49

Link

@tha_rami's edit: Now it is disappearing.

Back to top

Profile PM Email

Ed222

17

Years of Service

User Offline

Joined: 3rd Nov 2007

Location: Calgary

Posted: 8th Jul 2008 19:54

Link

Quote: "@tha_rami's edit: Now it is disappearing"

tha_rami? he didn't post here did he?

Back to top

Profile PM Email

Zeus

18

Years of Service

User Offline

Joined: 8th Jul 2006

Location: Atop Mount Olympus

Posted: 8th Jul 2008 22:05

Link

OMG Robert the Robot sorry.

Back to top

Profile PM Email

Robert The Robot

18

Years of Service

User Offline

Joined: 8th Jan 2007

Location: Fireball XL5

Posted: 9th Jul 2008 12:58 Edited at: 9th Jul 2008 16:59

Link

Don't worry Zeus, I don't mind.

I've just been running your code (I went and forgot to save the page last night

) and I think I've got it working. When you said "Now it is disappearing" it was because I'd messed up the SpaceKey() command:

+ Code Snippet

If spacekey() = 1
   rem Only allow the player to jump if jumping is not being processed
   If Jumping = 0
      Jumping = 1
      Gravity = 10
   endif
else
   Jumping = 0
endif

means that if you press and hold the space key, Gravity will always be 10, so the sprite will just go up and up and up. Anyway, I've corected that, and made a minor adjustment to my Gravity-Jump code so the sprite comes down at exactly the pixel it left from. I've also added in the "Sync" command as Ed222 pointed out, but CLS doesn't seem to make any difference so I left it out. Oh, and I've combined both player sprites so you only need the one.

`Started July 8th 2008

`Screen Setup
set display mode 800,600,32
hide mouse
Sync On

`Level Placing
`load animation "mediaanimationsgetready3.avi",1
`place animation 1,200,100,600,400
`play animation 1
`wait 2000
gosub level01

`Begin Level 1

level01:

`Staircase
Load image "medialvl01staircaseLEVEL01.png",1
sprite 1,100,100,1

`Character Attributes
x=590            : `Position X
y=383            : `Position Y
PlayerImage = 2  : `The Image of the player that is displayed

energy#=0 : `Energy
strength#=0 : `Strength
score#=0 : `Current Score

`Create player images (I didn't have yours)
`Create Bitmap 1, 10, 10
`Cls RGB(255, 0, 0)
`Get image 2, 0, 0, 10, 10
`Cls RGB(0, 255, 0)
`Get image 3, 0, 0, 10, 10

load image "mediacharacters1normal.png",2 : `Character 1 Stand
load image "mediacharacters1crouch.png",3 : `Character 1 Crouch

sprite 2,x,y,PlayerImage : `Normal Character Sprite

`Level 1 Loop
do

`To Jump Up
If spacekey() = 1
   If Jumping = 0
      Jumping = 1
      Gravity = 10
   endif
endif

If Jumping = 1
   If Gravity > 0
      y = y-1
      Gravity = Gravity-1
   endif

If Gravity = 0 then Gravity = Gravity-1

If Gravity < 0
      y = y+1
      Gravity = Gravity - 1
   endif

If Gravity = -11
      Jumping = 0
   endif
endif

`To Crouch
if returnkey()=1
   PlayerImage = 3
else
   PlayerImage = 2
endif

sprite 2,x,y, PlayerImage

sync

loop
return

+ Code Snippet


`Started July 8th 2008

`Screen Setup
set display mode 800,600,32
hide mouse
Sync On

`Level Placing
`load animation "mediaanimationsgetready3.avi",1
`place animation 1,200,100,600,400
`play animation 1
`wait 2000
gosub level01


`Begin Level 1

level01:

`Staircase
Load image "medialvl01staircaseLEVEL01.png",1
sprite 1,100,100,1


`Character Attributes
x=590            : `Position X
y=383            : `Position Y
PlayerImage = 2  : `The Image of the player that is displayed

energy#=0 : `Energy
strength#=0 : `Strength
score#=0 : `Current Score

`Create player images (I didn't have yours)
`Create Bitmap 1, 10, 10
`Cls RGB(255, 0, 0)
`Get image 2, 0, 0, 10, 10
`Cls RGB(0, 255, 0)
`Get image 3, 0, 0, 10, 10


load image "mediacharacters1normal.png",2 : `Character 1 Stand
load image "mediacharacters1crouch.png",3 : `Character 1 Crouch

sprite 2,x,y,PlayerImage : `Normal Character Sprite


`Level 1 Loop
do

`To Jump Up
If spacekey() = 1
   If Jumping = 0
      Jumping = 1
      Gravity = 10
   endif
endif

If Jumping = 1
   If Gravity > 0
      y = y-1
      Gravity = Gravity-1
   endif

   If Gravity = 0 then Gravity = Gravity-1

   If Gravity < 0
      y = y+1
      Gravity = Gravity - 1
   endif

   If Gravity = -11
      Jumping = 0
   endif
endif

`To Crouch
if returnkey()=1
   PlayerImage = 3
else
   PlayerImage = 2
endif

sprite 2,x,y, PlayerImage

sync

loop
return

Hope this works for you!

It is said there are 10 types of people in this world - those who understand binary, and those who have friends!

Back to top

Profile PM Website

Sorry your browser is not supported!

DarkBASIC Discussion / Character not moving?