Something wrong with this function?

Author

Message

Lavalord7

17

Years of Service

User Offline

Joined: 9th Jan 2007

Location:

Posted: 24th Nov 2008 23:12

Link

Is there anything wrong with this function? I can't get it to work...

+ Code Snippet

function MoveCharacterForward(distance#)
   move object 1, distance#
endfunction

Back to top

Profile PM

zenassem

21

Years of Service

User Offline

Joined: 10th Mar 2003

Location: Long Island, NY

Posted: 24th Nov 2008 23:25

Link

Not that I can see, except for the fact that the second parameter is really velocity (which is distance/time), and you are using the name distance.

So what is happening, what's not working exaclty?

"When I look at that square... I wish FPSC noobs would stay on their side of the forums and stop polluting these boards." - Benjamin

Back to top

Profile PM Email

Lavalord7

17

Years of Service

User Offline

Joined: 9th Jan 2007

Location:

Posted: 24th Nov 2008 23:33 Edited at: 24th Nov 2008 23:54

Link

Sorry, I have no idea why I called it distance...

I made a function called CheckKeyInput that basically checks the key input, and if you pressed W it moves the character forward. Does it matter that this CheckKeyInput function was defined before the other function?

EDIT: The problem appears to be with this function:

+ Code Snippet

function GetKeyInput()
   if keystate(17) = 1
      MoveCharacterForward(MOVEDISTANCE#)
   endif
endfunction

EDIT2: I'd put it in Step Thru mode, but I can't seem to get that to work either.

Back to top

Profile PM

zenassem

21

Years of Service

User Offline

Joined: 10th Mar 2003

Location: Long Island, NY

Posted: 25th Nov 2008 00:06

Link

Can you post the full source? Becuase I really can't see what is going on.

Did you try putting test stubs in your code to print out to the screen, when you reach a function, and what the values are? I've never gotten the debugger to work either,

"When I look at that square... I wish FPSC noobs would stay on their side of the forums and stop polluting these boards." - Benjamin

Back to top

Profile PM Email

Lavalord7

17

Years of Service

User Offline

Joined: 9th Jan 2007

Location:

Posted: 25th Nov 2008 00:22

Link

Well, excuse its sloppiness, but here's the entire source. Also completely ignore the camera stuff... I have no idea whats going on there.

sync on
sync rate 0

rem Define Variables
YES = 0
NO = 1
TRUE = YES
FALSE = NO
CHAR = 1
MOVESPEED# = 0.01

rem Other Pre-Loop Setup
hide mouse
CreateMainCharacter()
position camera CHARX, CHARY + 5, CHARZ - 5
point camera CHARX, CHARY, CHARZ

rem GAME LOOP
rem *************************************************************************************
rem *************************************************************************************

do
   rem Check for Input
   GetKeyInput()
   GetMouseInput()
   rem Position the Camera
   `PositionCamera()
   rem Update Variables
   UpdateCharacterPosition()
   rem Sync
   sync
loop

rem FUNCTIONS
rem *************************************************************************************
rem *************************************************************************************

function LoadResources()
   LoadModels()
   LoadImages()
   LoadMusic()
   LoadSounds()
   LoadShaders()
endfunction

function LoadModels()
endfunction

function LoadImages()
endfunction

function LoadMusic()
endfunction

function LoadSounds()
endfunction

function LoadShaders()
endfunction

function CreateMainCharacter()
   make object sphere 1, 1
   position object 1, 0, 0, 0
endfunction

function MoveCharacterForward(velocity#)
   move object 1, velocity#
endfunction

function MoveCharacterLeft(velocity#)
   move object left 1, velocity#
endfunction

function MoveCharacterRight(velocity#)
   move object right 1, velocity#
endfunction

function MoveCharacterBack(velocity#)
   move object 1, -velocity#
endfunction

function GetKeyInput()
   if keystate(17) = 1
      MoveCharacterForward(MOVESPEED#)
   endif
   if keystate(30) = 1
      MoveCharacterLeft(MOVESPEED#)
   endif
   if keystate(31) = 1
      MoveCharacterBack(MOVESPEED#)
   endif
   if keystate(32) = 1
      MoveCharacterRight(MOVESPEED#)
   endif
endfunction

function GetMouseInput()
endfunction

function PositionCamera()
   CAMY# = CAMY# + mousemovex()`*.1
   CAMX# = CAMX# + mousemovey()`*.1
   if CAMX#>90 and CAMX#<135 then CAMX#=90
   if CAMX#>270 and CAMX#<225 then CAMX#=90
   yrotate camera CAMY#
   xrotate camera CAMX#
   yrotate object 1,CAMY#
   xrotate object 1,CAMX#
endfunction

function UpdateCharacterPosition()
   CHARX# = object position x(1)
   CHARY# = object position y(1)
   CHARZ# = object position z(1)
endfunction

+ Code Snippet

sync on
sync rate 0

rem Define Variables
YES = 0
NO = 1
TRUE = YES
FALSE = NO
CHAR = 1
MOVESPEED# = 0.01

rem Other Pre-Loop Setup
hide mouse
CreateMainCharacter()
position camera CHARX, CHARY + 5, CHARZ - 5
point camera CHARX, CHARY, CHARZ

rem GAME LOOP
rem *************************************************************************************
rem *************************************************************************************

do
   rem Check for Input
   GetKeyInput()
   GetMouseInput()
   rem Position the Camera
   `PositionCamera()
   rem Update Variables
   UpdateCharacterPosition()
   rem Sync
   sync
loop

rem FUNCTIONS
rem *************************************************************************************
rem *************************************************************************************

function LoadResources()
   LoadModels()
   LoadImages()
   LoadMusic()
   LoadSounds()
   LoadShaders()
endfunction

function LoadModels()
endfunction

function LoadImages()
endfunction

function LoadMusic()
endfunction

function LoadSounds()
endfunction

function LoadShaders()
endfunction

function CreateMainCharacter()
   make object sphere 1, 1
   position object 1, 0, 0, 0
endfunction

function MoveCharacterForward(velocity#)
   move object 1, velocity#
endfunction

function MoveCharacterLeft(velocity#)
   move object left 1, velocity#
endfunction

function MoveCharacterRight(velocity#)
   move object right 1, velocity#
endfunction

function MoveCharacterBack(velocity#)
   move object 1, -velocity#
endfunction

function GetKeyInput()
   if keystate(17) = 1
      MoveCharacterForward(MOVESPEED#)
   endif
   if keystate(30) = 1
      MoveCharacterLeft(MOVESPEED#)
   endif
   if keystate(31) = 1
      MoveCharacterBack(MOVESPEED#)
   endif
   if keystate(32) = 1
      MoveCharacterRight(MOVESPEED#)
   endif
endfunction

function GetMouseInput()
endfunction

function PositionCamera()
   CAMY# = CAMY# + mousemovex()`*.1
   CAMX# = CAMX# + mousemovey()`*.1
   if CAMX#>90 and CAMX#<135 then CAMX#=90
   if CAMX#>270 and CAMX#<225 then CAMX#=90
   yrotate camera CAMY#
   xrotate camera CAMX#
   yrotate object 1,CAMY#
   xrotate object 1,CAMX#
endfunction

function UpdateCharacterPosition()
   CHARX# = object position x(1)
   CHARY# = object position y(1)
   CHARZ# = object position z(1)
endfunction

Back to top

Profile PM

zenassem

21

Years of Service

User Offline

Joined: 10th Mar 2003

Location: Long Island, NY

Posted: 25th Nov 2008 00:38 Edited at: 25th Nov 2008 00:55

Link

Just make your MOVESPEED# at the beginning of the source code global.

The functions had no visibility/access to it, and were hence creating a localized MOVESPEED# variable that had a value of 0. That is why your object was not moving,

In programming this is known as the variable's scope. A variable can have a local scope or a global scope.

+ Code Snippet

global MOVESPEED#
MOVESPEED# =.01

note in dbpro arrays are global by default.

By making MOVESPEED# Global, you are basically allowing the variable visible to the entire program (giving the variable a global scope rather than local scope), and allowing functions to access it & change it's value as well.

If it's not global, and you want a function to receive the value, you would need to pass it as a parameter.

"When I look at that square... I wish FPSC noobs would stay on their side of the forums and stop polluting these boards." - Benjamin

Back to top

Profile PM Email

Lavalord7

17

Years of Service

User Offline

Joined: 9th Jan 2007

Location:

Posted: 25th Nov 2008 00:54

Link

Thanks, it now works!

Back to top

Profile PM

Lavalord7

17

Years of Service

User Offline

Joined: 9th Jan 2007

Location:

Posted: 26th Nov 2008 03:48

Link

Okay, new problem.
I tried to implement sliding collision. Is there something wrong with my sliding collision function? Here is my full source:

sync on
sync rate 60

rem Define Types
type character
   objectid
   name$
   age
   speed#
endtype

type friendly
   istaken
   objectid
   name$
   age
   speed#
   x#
   y#
   z#
   doesplayerknow
endtype

rem Define Variables
global NO = 0
global YES = 1
global TRUE = YES
global FALSE = NO
global CHAR = 1
global MOVESPEED# = 0.1
global CHARX#
global CHARY#
global CHARZ#
global SCREENMIDX = 512
global SCREENMIDY = 384
global player as character
player.objectid = CHAR
player.speed# = MOVESPEED#
global dim npc(5000) as friendly
global OLDCHARX#
global OLDCHARY#
global OLDCHARZ#

rem Other Pre-Loop Setup
hide mouse
CreateMainCharacter()
UpdateCharacterPosition()
CreateNPC(0, 0, 5, "Arborum", 34, MOVESPEED#, 100, 0)

rem GAME LOOP
rem *************************************************************************************
rem *************************************************************************************

do
   rem Update Early Variables
   UpdateOldCharacterPosition()
   rem Check for Input
   GetKeyInput()
   GetMouseInput()
   rem DoCollisionChecks
   NPCSlidingCollision()
   rem Collision Checks
   rem NPCSlidingCollision()
   rem Position the Camera
   PositionCamera()
   rem Update Late Variables
   UpdateCharacterPosition()
   rem Display the HUD
   DisplayHUD()
   rem Sync
   sync
loop

rem FUNCTIONS
rem *************************************************************************************
rem *************************************************************************************

function CreateMainCharacter()
   make object sphere CHAR, 1
endfunction

function GetKeyInput()
   if keystate(17) = 1
      MoveCharacterUp(player.speed#)
   endif
   if keystate(30) = 1
      MoveCharacterLeft(player.speed#)
   endif
   if keystate(31) = 1
      MoveCharacterBack(player.speed#)
   endif
   if keystate(32) = 1
      MoveCharacterRight(player.speed#)
   endif
endfunction

function GetMouseInput()
endfunction

function MoveCharacterUp(velocity#)
   move object CHAR, velocity#
endfunction

function MoveCharacterLeft(velocity#)
   move object left CHAR, velocity#
endfunction

function MoveCharacterRight(velocity#)
   move object right CHAR, velocity#
endfunction

function MoveCharacterBack(velocity#)
   move object CHAR, -velocity#
endfunction

function PositionCamera()
   position camera CHARX#, CHARY#, CHARZ#
   rotate camera camera angle x(0)+(mousemovey()*0.1),camera angle y(0)+(mousemovex()*0.1),0
   rotate object CHAR, camera angle x(0),camera angle y(0),0
   DrawCrosshair()
endfunction

function UpdateCharacterPosition()
   CHARX# = object position x(CHAR)
   CHARY# = object position y(CHAR)
   CHARZ# = object position z(CHAR)
endfunction

function UpdateOldCharacterPosition()
   OLDCHARX# = object position x(CHAR)
   OLDCHARY# = object position y(CHAR)
   OLDCHARZ# = object position z(CHAR)
endfunction

function DrawCrosshair()
   circle screen width()/2, screen height()/2, 5
endfunction

function CreateNPC(x#, y#, z#, name$, age, speed#, objectid, npcid)
      if npc(npcid).istaken = FALSE
         npc(npcid).istaken = TRUE
         npc(npcid).x# = x#
         npc(npcid).y# = y#
         npc(npcid).z# = z#
         npc(npcid).name$ = name$
         npc(npcid).age = age
         npc(npcid).speed# = speed#
         npc(npcid).objectid = objectid
         make object sphere objectid, 1
         position object objectid, x#, y#, z#
         sc_setupobject objectid, 0, 0
      else
         exitfunction
      endif
endfunction

function DisplayHUD()
   text 5, 5, "FPS: " + str$(screen fps())
   text 5, 20, "x: " + str$(CHARX#)
   text 5, 35, "y: " + str$(CHARY#)
   text 5, 50, "z: " + str$(CHARZ#)
endfunction

function SlidingCollision(x1#, y1#, z1#, x2#, y2#, z2#, radius#, dyn, obj)
   c = sc_sphereslide(obj, x1#, y1#, z1#, x2#, y2#, z2#, radius#, 0)
   if c > 0
      cx# = sc_getcollisionslidex()
      cy# = sc_getcollisionslidey()
      cz# = sc_getcollisionslidez()
      position object dyn, cx#, cy#, cz#
   endif
endfunction

function NPCSlidingCollision()
   for x = 0 to 5000
      SlidingCollision(OLDCHARX#, OLDCHARY#, OLDCHARZ#, CHARX#, CHARY#, CHARZ#, 0.5, 1, npc(x).objectid)
   next
endfunction

delete memblock 1

+ Code Snippet

sync on
sync rate 60

rem Define Types
type character
   objectid
   name$
   age
   speed#
endtype

type friendly
   istaken
   objectid
   name$
   age
   speed#
   x#
   y#
   z#
   doesplayerknow
endtype

rem Define Variables
global NO = 0
global YES = 1
global TRUE = YES
global FALSE = NO
global CHAR = 1
global MOVESPEED# = 0.1
global CHARX#
global CHARY#
global CHARZ#
global SCREENMIDX = 512
global SCREENMIDY = 384
global player as character
player.objectid = CHAR
player.speed# = MOVESPEED#
global dim npc(5000) as friendly
global OLDCHARX#
global OLDCHARY#
global OLDCHARZ#

rem Other Pre-Loop Setup
hide mouse
CreateMainCharacter()
UpdateCharacterPosition()
CreateNPC(0, 0, 5, "Arborum", 34, MOVESPEED#, 100, 0)

rem GAME LOOP
rem *************************************************************************************
rem *************************************************************************************

do
   rem Update Early Variables
   UpdateOldCharacterPosition()
   rem Check for Input
   GetKeyInput()
   GetMouseInput()
   rem DoCollisionChecks
   NPCSlidingCollision()
   rem Collision Checks
   rem NPCSlidingCollision()
   rem Position the Camera
   PositionCamera()
   rem Update Late Variables
   UpdateCharacterPosition()
   rem Display the HUD
   DisplayHUD()
   rem Sync
   sync
loop

rem FUNCTIONS
rem *************************************************************************************
rem *************************************************************************************

function CreateMainCharacter()
   make object sphere CHAR, 1
endfunction

function GetKeyInput()
   if keystate(17) = 1
      MoveCharacterUp(player.speed#)
   endif
   if keystate(30) = 1
      MoveCharacterLeft(player.speed#)
   endif
   if keystate(31) = 1
      MoveCharacterBack(player.speed#)
   endif
   if keystate(32) = 1
      MoveCharacterRight(player.speed#)
   endif
endfunction

function GetMouseInput()
endfunction

function MoveCharacterUp(velocity#)
   move object CHAR, velocity#
endfunction

function MoveCharacterLeft(velocity#)
   move object left CHAR, velocity#
endfunction

function MoveCharacterRight(velocity#)
   move object right CHAR, velocity#
endfunction

function MoveCharacterBack(velocity#)
   move object CHAR, -velocity#
endfunction

function PositionCamera()
   position camera CHARX#, CHARY#, CHARZ#
   rotate camera camera angle x(0)+(mousemovey()*0.1),camera angle y(0)+(mousemovex()*0.1),0
   rotate object CHAR, camera angle x(0),camera angle y(0),0
   DrawCrosshair()
endfunction

function UpdateCharacterPosition()
   CHARX# = object position x(CHAR)
   CHARY# = object position y(CHAR)
   CHARZ# = object position z(CHAR)
endfunction

function UpdateOldCharacterPosition()
   OLDCHARX# = object position x(CHAR)
   OLDCHARY# = object position y(CHAR)
   OLDCHARZ# = object position z(CHAR)
endfunction

function DrawCrosshair()
   circle screen width()/2, screen height()/2, 5
endfunction

function CreateNPC(x#, y#, z#, name$, age, speed#, objectid, npcid)
      if npc(npcid).istaken = FALSE
         npc(npcid).istaken = TRUE
         npc(npcid).x# = x#
         npc(npcid).y# = y#
         npc(npcid).z# = z#
         npc(npcid).name$ = name$
         npc(npcid).age = age
         npc(npcid).speed# = speed#
         npc(npcid).objectid = objectid
         make object sphere objectid, 1
         position object objectid, x#, y#, z#
         sc_setupobject objectid, 0, 0
      else
         exitfunction
      endif
endfunction

function DisplayHUD()
   text 5, 5, "FPS: " + str$(screen fps())
   text 5, 20, "x: " + str$(CHARX#)
   text 5, 35, "y: " + str$(CHARY#)
   text 5, 50, "z: " + str$(CHARZ#)
endfunction

function SlidingCollision(x1#, y1#, z1#, x2#, y2#, z2#, radius#, dyn, obj)
   c = sc_sphereslide(obj, x1#, y1#, z1#, x2#, y2#, z2#, radius#, 0)
   if c > 0
      cx# = sc_getcollisionslidex()
      cy# = sc_getcollisionslidey()
      cz# = sc_getcollisionslidez()
      position object dyn, cx#, cy#, cz#
   endif
endfunction

function NPCSlidingCollision()
   for x = 0 to 5000
      SlidingCollision(OLDCHARX#, OLDCHARY#, OLDCHARZ#, CHARX#, CHARY#, CHARZ#, 0.5, 1, npc(x).objectid)
   next
endfunction

delete memblock 1

All help will be appreciated.

Back to top

Profile PM

Sorry your browser is not supported!

Newcomers DBPro Corner / Something wrong with this function?