Array Question - GameCreators Forum

Author

Message

Gingerkid Jack

19

Years of Service

User Offline

Joined: 15th May 2005

Location: UK

Posted: 5th Apr 2009 23:05 Edited at: 6th Apr 2009 00:26

Link

EDIT: Hi can a MOD rename this to Array Test

Hi there. Im not near a PC with DBPro on so this is just from memory:

Here is a simple program with arrays and I would just like to know if it was the right concept? Is it right, wrong and why? Anyhows here it is:

Rem Project: TestArray
Rem Created: 05/04/2009 22:20:01

Rem ***** Main Source File *****
Rem Characteristics Test

Dim People(1) as String
  People(0) = "Bob"
  People(1) = "Pat"

Dim Bob(3) as String
  Bob(0) = "No Hair"
  Bob(1) = "Blue Eyes"
  Bob(2) = "37"
  Bob(3) = "Boy"

Dim Pat(3) as String
  Pat(0) = "Blond Hair"
  Pat(1) = "Green Eyes"
  Pat(2) = "24"
  Pat(3) = "Girl"

Start:
 Print "Hello type in a Characteristic of Bob or Pat and I will identify them"
 wait 1000
 gosub Pick

Pick:
 CLS
 Input "type it in -> ";Char$
 Gosub Identify

Identify:
If Char$ = Bob(0) then
   Gosub Bob
   If Char$ = Bob(1) then
     Gosub Bob
     If Char$ = Bob(2) then
       Gosub Bob
       If Char$ = Bob(3) then
         Gosub Bob

If Char$ = Pat(0) then
   Gosub Pat
   If Char$ = Pat(1) then
     Gosub Pat
     If Char$ = Pat(2) then
       Gosub Pat
       If Char$ = Pat(3) then
         Gosub Pat
Return

Bob:
Print "This Characteristic belongs to ";People(0)
Wait 1500
Gosub Start
Pat:
Print "This Characteristic belongs to ";People(1)
Wait 1500
Gosub Start

+ Code Snippet

Rem Project: TestArray
Rem Created: 05/04/2009 22:20:01

Rem ***** Main Source File *****
Rem Characteristics Test

 Dim People(1) as String
  People(0) = "Bob"
  People(1) = "Pat"

 Dim Bob(3) as String
  Bob(0) = "No Hair"
  Bob(1) = "Blue Eyes"
  Bob(2) = "37"
  Bob(3) = "Boy"

 Dim Pat(3) as String
  Pat(0) = "Blond Hair"
  Pat(1) = "Green Eyes"
  Pat(2) = "24"
  Pat(3) = "Girl"

Start:
 Print "Hello type in a Characteristic of Bob or Pat and I will identify them"
 wait 1000
 gosub Pick

Pick:
 CLS
 Input "type it in -> ";Char$
 Gosub Identify

Identify:
If Char$ = Bob(0) then
   Gosub Bob
   If Char$ = Bob(1) then
     Gosub Bob
     If Char$ = Bob(2) then
       Gosub Bob
       If Char$ = Bob(3) then
         Gosub Bob

If Char$ = Pat(0) then
   Gosub Pat
   If Char$ = Pat(1) then
     Gosub Pat
     If Char$ = Pat(2) then
       Gosub Pat
       If Char$ = Pat(3) then
         Gosub Pat
Return

Bob:
Print "This Characteristic belongs to ";People(0)
Wait 1500
Gosub Start
Pat:
Print "This Characteristic belongs to ";People(1)
Wait 1500
Gosub Start

Well thats it, Like I said im not a machine with DBPro on so it's probably all wrong. Anyway this is just off the top of my head so...What do you think?

Jack

TheCleverGuyz

Back to top

Profile PM Email

Sixty Squares

18

Years of Service

User Offline

Joined: 7th Jun 2006

Location: Somewhere in the world

Posted: 5th Apr 2009 23:13

Link

Looks OK from what I can tell, but you're missing a few things:

*Each of your IF statements needs its own ENDIF unless you are using it in conjunction with THEN.
*Endif doesn't work on GOSUB labels. You will need to use RETURN.
*When referencing an array, you must refer to it you declared it (name-wise). For example, you declared your People array like this: DIM People$(1). But you later say People(0) = "Bob". Don't forget the $ sign

Other than that it looks okay at first glance. Good luck testing it!

<---Spell casting battle game!

Back to top

Profile PM Email

Gingerkid Jack

19

Years of Service

User Offline

Joined: 15th May 2005

Location: UK

Posted: 5th Apr 2009 23:20

Link

Is that better?

TheCleverGuyz

Back to top

Profile PM Email

Sixty Squares

18

Years of Service

User Offline

Joined: 7th Jun 2006

Location: Somewhere in the world

Posted: 5th Apr 2009 23:46

Link

No, sorry if I was unclear... I meant that if you DIM your array as People$(1), you need to say People$(0) = "Bob", not just People(0) = "Bob" if you want to put something in the array.

. Now it makes less sense than before...

<---Spell casting battle game!

Back to top

Profile PM Email

Gingerkid Jack

19

Years of Service

User Offline

Joined: 15th May 2005

Location: UK

Posted: 5th Apr 2009 23:56 Edited at: 6th Apr 2009 00:27

Link

Oh, ok. I changed the array to: Dim People(1) as String is this better?

EDIT: Ok I got on a machine with DB on and changed it round so it works. But only bob's characteristics work Pats do not? Whats the problem?

TheCleverGuyz

Back to top

Profile PM Email

Gingerkid Jack

19

Years of Service

User Offline

Joined: 15th May 2005

Location: UK

Posted: 6th Apr 2009 00:33

Link

I have made it cleaner but Pat's Chars still won't work

Rem Project: TestArray
Rem Created: 05/04/2009 22:20:01

Rem ***** Main Source File *****
Rem Characteristics Test

Dim People(1) as String
  People(0) = "Bob"
  People(1) = "Pat"

Dim Bob(3) as String
  Bob(0) = "No Hair"
  Bob(1) = "Blue Eyes"
  Bob(2) = "37"
  Bob(3) = "Boy"

Dim Pat(3) as String
  Pat(0) = "Blonde Hair"
  Pat(1) = "Green Eyes"
  Pat(2) = "24"
  Pat(3) = "Girl"

Start:
 Print "Hello type in a Characteristic of Bob or Pat and I will identify them"
 wait 1000
 gosub Pick

Pick:
 CLS
 Input "type it in -> ";Char$
 Gosub Identify

Identify:
If Char$ = Bob(0):
   Gosub Bob
   Char$ = Bob(1):
         Gosub Bob
   Char$ = Bob(2):
         Gosub Bob
   Char$ = Bob(3):
         Gosub Bob
   Char$ = Pat(0):
         Gosub Pat
   Char$ = Pat(1):
         Gosub Pat
   Char$ = Pat(2):
         Gosub Pat
   Char$ = Pat(3):
         Gosub Pat

Else
      Print "What? ->"
         wait 1500
      Gosub Start
Endif
Return

Bob:
Print "This Characteristic belongs to ";People(0)
Wait 1500
Gosub Start
Pat:
Print "This Characteristic belongs to ";People(1)
Wait 1500
Gosub Start

+ Code Snippet

Rem Project: TestArray
Rem Created: 05/04/2009 22:20:01

Rem ***** Main Source File *****
Rem Characteristics Test

 Dim People(1) as String
  People(0) = "Bob"
  People(1) = "Pat"

 Dim Bob(3) as String
  Bob(0) = "No Hair"
  Bob(1) = "Blue Eyes"
  Bob(2) = "37"
  Bob(3) = "Boy"

 Dim Pat(3) as String
  Pat(0) = "Blonde Hair"
  Pat(1) = "Green Eyes"
  Pat(2) = "24"
  Pat(3) = "Girl"

Start:
 Print "Hello type in a Characteristic of Bob or Pat and I will identify them"
 wait 1000
 gosub Pick

Pick:
 CLS
 Input "type it in -> ";Char$
 Gosub Identify

Identify:
If Char$ = Bob(0):
   Gosub Bob
   Char$ = Bob(1):
         Gosub Bob
   Char$ = Bob(2):
         Gosub Bob
   Char$ = Bob(3):
         Gosub Bob
   Char$ = Pat(0):
         Gosub Pat
   Char$ = Pat(1):
         Gosub Pat
   Char$ = Pat(2):
         Gosub Pat
   Char$ = Pat(3):
         Gosub Pat

   Else
      Print "What? ->"
         wait 1500
      Gosub Start
Endif
Return

Bob:
Print "This Characteristic belongs to ";People(0)
Wait 1500
Gosub Start
Pat:
Print "This Characteristic belongs to ";People(1)
Wait 1500
Gosub Start

TheCleverGuyz

Back to top

Profile PM Email

Quirkyjim

15

Years of Service

User Offline

Joined: 18th Oct 2008

Location: At my computer

Posted: 6th Apr 2009 00:37

Link

Well, your Bob and Pat subroutines have no return.

That's what they WANT you to think...

Back to top

Profile PM Email

Bursar

16

Years of Service

User Offline

Joined: 17th Sep 2008

Location:

Posted: 6th Apr 2009 01:39

Link

Why not use UDT arrays? Much neater than needing to have a separate array for each person.

+ Code Snippet

type people_details
	name as string
	hair as string
	eyes as string
	age as string
	gender as string
endtype

dim people(2) as people_details
valid_attribute as integer
valid_attribute = 0

people(0).name = "Bob"
people(0).hair = "No hair"
people(0).eyes = "Blue Eyes"
people(0).age = "37"
people(0).gender = "Boy"

people(1).name = "Pat"
people(1).hair = "Blonde hair"
people(1).eyes = "Green Eyes"
people(1).age = "24"
people(1).gender = "Girl"

Print "Hello type in a Characteristic of Bob or Pat and I will identify them"
Input "type it in -> ";Char$

for a = 0 to array count(people())
	if Char$ = people(a).hair or Char$ = people(a).eyes or Char$ = people(a).age or Char$ = people(a).gender
		print "This Characteristic belongs to "; people(a).name
		valid_attribute = 1
  	endif
 next
 
 if valid_attribute = 0 then print "This characteristic belongs to noone."
 
 wait key

Back to top

Profile PM

Sorry your browser is not supported!

Newcomers DBPro Corner / Array Question