Can someone help with my database please?

Author

Message

Game Master1330

17

Years of Service

User Offline

Joined: 19th Oct 2007

Location: (GetReaderXYZ() * 42 ) / 0

Posted: 29th Sep 2009 23:08 Edited at: 1st Oct 2009 22:35

Link

I've made a code which has data put in and when you put a number in, it shows the corresponding data. The problem is that i don't know how to get it to save new data that you put in. And also, i don't know how to get it to add an account automatically. You will see what i mean if you try to run it.

rem Declaring Data
dim database$(10,4)
database$(1,1) = "Name: name"
database$(1,2) = "Email: email"
database$(1,3) = "Account Name: accname"
database$(1,4) = "Account Status: accstatus"
goto choices

rem Choices
choices:
cls
print "Type 1 to search accounts"
print "Type 2 to add accounts"
input "Enter Choice> ",choice
if choice = 1 then goto search
if choice = 2 then goto add
goto choices
return

rem Search
search:
cls
input "Enter Account Number> ",number
if number = 1 then goto 1
if number = 2 then goto 2
if number => 2 then print "Invalid Number!"
wait key
goto choices
return

rem Add
add:
cls
input "Enter Name> ",currentname$
input "Enter Email> ",currentemail$
input "Enter Account Name> ",currentaccname$
input "Enter Account Status> ",currentaccstatus$
database$(2,1) = "Name: " + currentname$
database$(2,2) = "Email: " + currentemail$
database$(2,3) = "Account Name: " + currentaccname$
database$(2,4) = "Account Status: " + currentaccstatus$
print "Saved"
goto choices
return

rem Account 1
1:
cls
print database$(1,1)
print database$(1,2)
print database$(1,3)
print database$(1,4)
wait key
goto choices
return

rem Account 2
2:
cls
print database$(2,1)
print database$(2,2)
print database$(2,3)
print database$(2,4)
wait key
goto choices
return

+ Code Snippet

rem Declaring Data
dim database$(10,4)
database$(1,1) = "Name: name"
database$(1,2) = "Email: email"
database$(1,3) = "Account Name: accname"
database$(1,4) = "Account Status: accstatus"
goto choices

rem Choices
choices:
cls
print "Type 1 to search accounts"
print "Type 2 to add accounts"
input "Enter Choice> ",choice
if choice = 1 then goto search
if choice = 2 then goto add
goto choices
return

rem Search
search:
cls
input "Enter Account Number> ",number
if number = 1 then goto 1
if number = 2 then goto 2
if number => 2 then print "Invalid Number!"
wait key
goto choices
return

rem Add
add:
cls
input "Enter Name> ",currentname$
input "Enter Email> ",currentemail$
input "Enter Account Name> ",currentaccname$
input "Enter Account Status> ",currentaccstatus$
database$(2,1) = "Name: " + currentname$
database$(2,2) = "Email: " + currentemail$
database$(2,3) = "Account Name: " + currentaccname$
database$(2,4) = "Account Status: " + currentaccstatus$
print "Saved"
goto choices
return

rem Account 1
1:
cls
print database$(1,1)
print database$(1,2)
print database$(1,3)
print database$(1,4)
wait key
goto choices
return

rem Account 2
2:
cls
print database$(2,1)
print database$(2,2)
print database$(2,3)
print database$(2,4)
wait key
goto choices
return

EDIT - I have compleltely re-written most of the code and have now solved most of the issues.

I do still need help ironing out a couple more though.
I need to know how to check if a file exists and cancel a file reading operation if it doesn't. Because at the moment if the user types a file that doesn't exist, the program exits.

Also, i need to know how to set cd to the default path. At the moment, once you have made a default path, you have to go into settings and tell it to set it to the default path.

cd "Database"
currentdirectory$ = "Database"
goto choices

choices:
cls
print "Type 1 to search accounts"
print "Type 2 to add accounts"
print "Type 3 to change directory"
input "Enter Choice> ",choice
if choice = 1 then goto search
if choice = 2 then goto add
if choice = 3 then goto change
goto choices
return

search:
cls
input "Enter Account Number> ",number$
open to read 1, number$
read string 1, currentfile1$
read string 1, currentfile2$
read string 1, currentfile3$
read string 1, currentfile4$
cls
print currentfile1$
print currentfile2$
print currentfile3$
print currentfile4$
wait key
close file 1
goto choices
return

add:
cls
input "Enter ID> ",currentid$
cls
input "Enter Name> ",currentname$
cls
input "Enter Email> ",currentemail$
cls
input "Enter Account Name> ",currentaccname$
cls
input "Enter Account Status> ",currentaccstatus$
open to write 2, currentid$
write string 2, currentname$
write string 2, currentemail$
write string 2, currentaccname$
write string 2, currentaccstatus$
close file 2
cls
print "Saved"
wait key
goto choices
return

change:
input "Enter directory (1 is default)> ",currentdirectory$
if currentdirectory$ = "1" then goto defaultdir
open to write 3, "directory"
write string 3, currentdirectory$
close file 3
cd currentdirectory$
cls
print "'" + currentdirectory$ + "' has been set to the default directory."
wait key
open to write 3, "directory"
write string 3, currentdirectory$
close file 3
cls
goto choices
return

defaultdir:
open to read 4, "directory"
read string 4, defaultdir$
cd defaultdir$
close file 4
cls
print "'" + defaultdir$ + "' has been set to the default directory."
wait key
goto choices
return

+ Code Snippet

cd "Database"
currentdirectory$ = "Database"
goto choices

choices:
cls
print "Type 1 to search accounts"
print "Type 2 to add accounts"
print "Type 3 to change directory"
input "Enter Choice> ",choice
if choice = 1 then goto search
if choice = 2 then goto add
if choice = 3 then goto change
goto choices
return

search:
cls
input "Enter Account Number> ",number$
open to read 1, number$
read string 1, currentfile1$
read string 1, currentfile2$
read string 1, currentfile3$
read string 1, currentfile4$
cls
print currentfile1$
print currentfile2$
print currentfile3$
print currentfile4$
wait key
close file 1
goto choices
return

add:
cls
input "Enter ID> ",currentid$
cls
input "Enter Name> ",currentname$
cls
input "Enter Email> ",currentemail$
cls
input "Enter Account Name> ",currentaccname$
cls
input "Enter Account Status> ",currentaccstatus$
open to write 2, currentid$
write string 2, currentname$
write string 2, currentemail$
write string 2, currentaccname$
write string 2, currentaccstatus$
close file 2
cls
print "Saved"
wait key
goto choices
return

change:
input "Enter directory (1 is default)> ",currentdirectory$
if currentdirectory$ = "1" then goto defaultdir
open to write 3, "directory"
write string 3, currentdirectory$
close file 3
cd currentdirectory$
cls
print "'" + currentdirectory$ + "' has been set to the default directory."
wait key
open to write 3, "directory"
write string 3, currentdirectory$
close file 3
cls
goto choices
return

defaultdir:
open to read 4, "directory"
read string 4, defaultdir$
cd defaultdir$
close file 4
cls
print "'" + defaultdir$ + "' has been set to the default directory."
wait key
goto choices
return

I have edited it yet again (WITH LOADS OF HELP FROM GROG) to perfection (Hopefully)

cd "Database\"
if file exist ("directory") then gosub defaultdir
currentdirectory$ = "Database\"

choices:
do
 cls
 print "Type 1 to search data"
 print "Type 2 to add data"
 print "Type 3 to change directory"
 input "Enter Choice> ",choice
 if choice = 1 then gosub search
 if choice = 2 then gosub add
 if choice = 3 then gosub change
loop
return

search:
cls
repeat
cls
 input "Enter ID (# to return)> ",number$
 if number$ = "#" then gosub choices
until file exist(number$)
open to read 1, number$
read string 1, currentfile1$
read string 1, currentfile2$
read string 1, currentfile3$
read string 1, currentfile4$
cls
print "Name: " + currentfile1$
print "Price: " + currentfile2$
print "Supermarket: " + currentfile3$
print "Date: " + currentfile4$
wait key
close file 1
return

add:
cls
input "Enter ID (# to return)> ",currentid$
if currentid$ = "#" then gosub choices
cls
input "Enter Name (# to return)> ",currentname$
if currentname$ = "#" then gosub choices
cls
input "Enter Price (# to return)> ",currentprice$
if currentprice$ = "#" then gosub choices
cls
input "Enter Supermarket (# to return)> ",currentsupermarket$
if currentsupermarket$ = "#" then gosub choices
cls
input "Enter Date (# to return)> ",currentdate$
if currentdate$ = "#" then gosub choices
if file exist(currentid$) then delete file currentid$
open to write 2, currentid$
write string 2, currentname$
write string 2, currentprice$
write string 2, currentsupermarket$
write string 2, currentdate$
close file 2
cls
print "Saved"
wait key
return

change:
cls
input "Enter directory (1 is default, # to return)> ",currentdirectory$
if currentdirectory$ = "1" then gosub defaultdir
if currentdirectory$ = "#" then gosub choices
open to write 3, "directory"
write string 3, currentdirectory$
close file 3
cd currentdirectory$
cls
print "'" + currentdirectory$ + "' has been set to the default directory."
wait key
open to write 3, "directory"
write string 3, currentdirectory$
close file 3
cls
return

defaultdir:
open to read 4, "directory"
read string 4, defaultdir$
cd defaultdir$
close file 4
cls
print "'" + defaultdir$ + "' has been set to the default directory."
wait key
return

+ Code Snippet

cd "Database\"
if file exist ("directory") then gosub defaultdir
currentdirectory$ = "Database\"

choices:
do
 cls
 print "Type 1 to search data"
 print "Type 2 to add data"
 print "Type 3 to change directory"
 input "Enter Choice> ",choice
 if choice = 1 then gosub search
 if choice = 2 then gosub add
 if choice = 3 then gosub change
loop
return

search:
cls
repeat
cls
 input "Enter ID (# to return)> ",number$
 if number$ = "#" then gosub choices
until file exist(number$)
open to read 1, number$
read string 1, currentfile1$
read string 1, currentfile2$
read string 1, currentfile3$
read string 1, currentfile4$
cls
print "Name: " + currentfile1$
print "Price: " + currentfile2$
print "Supermarket: " + currentfile3$
print "Date: " + currentfile4$
wait key
close file 1
return

add:
cls
input "Enter ID (# to return)> ",currentid$
if currentid$ = "#" then gosub choices
cls
input "Enter Name (# to return)> ",currentname$
if currentname$ = "#" then gosub choices
cls
input "Enter Price (# to return)> ",currentprice$
if currentprice$ = "#" then gosub choices
cls
input "Enter Supermarket (# to return)> ",currentsupermarket$
if currentsupermarket$ = "#" then gosub choices
cls
input "Enter Date (# to return)> ",currentdate$
if currentdate$ = "#" then gosub choices
if file exist(currentid$) then delete file currentid$
open to write 2, currentid$
write string 2, currentname$
write string 2, currentprice$
write string 2, currentsupermarket$
write string 2, currentdate$
close file 2
cls
print "Saved"
wait key
return

change:
cls
input "Enter directory (1 is default, # to return)> ",currentdirectory$
if currentdirectory$ = "1" then gosub defaultdir
if currentdirectory$ = "#" then gosub choices
open to write 3, "directory"
write string 3, currentdirectory$
close file 3
cd currentdirectory$
cls
print "'" + currentdirectory$ + "' has been set to the default directory."
wait key
open to write 3, "directory"
write string 3, currentdirectory$
close file 3
cls
return

defaultdir:
open to read 4, "directory"
read string 4, defaultdir$
cd defaultdir$
close file 4
cls
print "'" + defaultdir$ + "' has been set to the default directory."
wait key
return

Please leave comments or suggestions.
Any help appreciated.
Matt

Umm...

Back to top

Profile PM Email

Grog Grueslayer

Valued Member

19

Years of Service

User Offline

Joined: 30th May 2005

Playing: Green Hell

Posted: 1st Oct 2009 07:20

Link

Quote: "I need to know how to check if a file exists and cancel a file reading operation if it doesn't. Because at the moment if the user types a file that doesn't exist, the program exits."

You can use the command FILE EXIST():

+ Code Snippet

if file exist("filename.ext")
 ` do whatever
endif

Quote: "Also, i need to know how to set cd to the default path. At the moment, once you have made a default path, you have to go into settings and tell it to set it to the default path."

I don't quite understand what you mean. The default path is always the directory the .exe is in. If you change to a directory within the starting directory and want to go back to the default you use CD ".." to go back one directory. And the \ should be at the end of the directory path... not the beginning.

What you should really do is keep away from GOTO. The way you do the code it's going to have a problem because you keep going to choices before the RETURN. When you want to use a RETURN you use GOSUB to go to the label and use RETURN to come back to the next line under the GOSUB.

If you want to repeat code you can encase it in a DO/LOOP instead of using GOTO over and over again. There are also conditional loops like REPEAT/UNTIL loops that should work nicely when you want to check if a file exists or not.

Another thing you may not realize is a file cannot exist before you can write to it. So to write a new file you need a check to see if the file exists already and deletes it if it does.

I really don't get why you want to change directories. The files are so small there's no need to have a bunch of different directories for each... and if you want to use account numbers you can add numbers to the filenames like Account_1.txt, Account_2.txt, Account_3.txt.

+ Code Snippet

` Do this 5 times (first loop t=1, second loop t=2, and so on.
for t=1 to 5

 ` Open "Account_"+ the string representation of t + ".txt"
 open to write 1,"Account_"+str$(t)+".txt"
 
  write string 1,"This is account #"+str$(t)
 
 close file 1

next t

But the easiest way is using the SAVE ARRAY and LOAD ARRAY commands. You can use those to quickly save the array you had in the first code snip and you won't have to worry about writing a bunch of different files.

+ Code Snippet

rem Declaring Data
dim database$(10,3)
` database$(xx,0) = Name
` database$(xx,1) = Email
` database$(xx,2) = Account Name
` database$(xx,3) = Account Status

` Define the array
database$(0,0)="Game Master1330"
database$(0,1)="Dontknow@somewhere.net"
database$(0,2)="Master1330, Game"
database$(0,3)="Active"

database$(1,0)="Grog Grueslayer"
database$(1,1)="Dontknow@somewhere.net"
database$(1,2)="Grueslayer, Grog"
database$(1,3)="Annoyed by GOTO"

` Save the array to a file
save array "Database.dat",database$()

` Clear the array
for t=0 to 1
 database$(t,0)=""
 database$(t,1)=""
 database$(t,2)=""
 database$(t,3)=""
next t

` Load the array
load array "Database.dat",database$()

` Show the array
for t=0 to 1
 print "Record #"+str$(t)
 print ""
 print database$(t,0)
 print database$(t,1)
 print database$(t,2)
 print database$(t,3)
 print ""
 print ""
next t

wait key

And don't be afraid to use rem statements... a remark filled code is easy to understand.

Here's some changes to your code:

cd "Database\"
currentdirectory$ = "Database\"

` Do this forever (no EXIT command to leave the DO/LOOP)
do
 cls
 print "Type 1 to search accounts"
 print "Type 2 to add accounts"
 print "Type 3 to change directory"
 input "Enter Choice> ",choice
 if choice = 1 then gosub search
 if choice = 2 then gosub add
 if choice = 3 then gosub change
` LOOP back to DO
loop

search:
cls

` Repeat this...
repeat 
 input "Enter Account Number> ",number$
` ...until the file exists
until file exist(number$)

open to read 1, number$
read string 1, currentfile1$
read string 1, currentfile2$
read string 1, currentfile3$
read string 1, currentfile4$
cls
print currentfile1$
print currentfile2$
print currentfile3$
print currentfile4$
wait key
close file 1
return

add:
cls
input "Enter ID> ",currentid$
cls
input "Enter Name> ",currentname$
cls
input "Enter Email> ",currentemail$
cls
input "Enter Account Name> ",currentaccname$
cls
input "Enter Account Status> ",currentaccstatus$

` Check if the file is already there and delete it
if file exist(currentid$) then delete file currentid$

open to write 2, currentid$
write string 2, currentname$
write string 2, currentemail$
write string 2, currentaccname$
write string 2, currentaccstatus$
close file 2
cls
print "Saved"
wait key
return

change:
input "Enter directory (1 is default)> ",currentdirectory$
if currentdirectory$ = "1" then gosub defaultdir
open to write 3, "directory"
write string 3, currentdirectory$
close file 3
cd currentdirectory$
cls
print "'" + currentdirectory$ + "' has been set to the default directory."
wait key
open to write 3, "directory"
write string 3, currentdirectory$
close file 3
cls
return

defaultdir:
open to read 4, "directory"
read string 4, defaultdir$
cd defaultdir$
close file 4
cls
print "'" + defaultdir$ + "' has been set to the default directory."
wait key
return

+ Code Snippet

cd "Database\"
currentdirectory$ = "Database\"

` Do this forever (no EXIT command to leave the DO/LOOP)
do
 cls
 print "Type 1 to search accounts"
 print "Type 2 to add accounts"
 print "Type 3 to change directory"
 input "Enter Choice> ",choice
 if choice = 1 then gosub search
 if choice = 2 then gosub add
 if choice = 3 then gosub change
` LOOP back to DO
loop


search:
cls

` Repeat this...
repeat 
 input "Enter Account Number> ",number$
` ...until the file exists
until file exist(number$)

open to read 1, number$
read string 1, currentfile1$
read string 1, currentfile2$
read string 1, currentfile3$
read string 1, currentfile4$
cls
print currentfile1$
print currentfile2$
print currentfile3$
print currentfile4$
wait key
close file 1
return

add:
cls
input "Enter ID> ",currentid$
cls
input "Enter Name> ",currentname$
cls
input "Enter Email> ",currentemail$
cls
input "Enter Account Name> ",currentaccname$
cls
input "Enter Account Status> ",currentaccstatus$

` Check if the file is already there and delete it
if file exist(currentid$) then delete file currentid$

open to write 2, currentid$
write string 2, currentname$
write string 2, currentemail$
write string 2, currentaccname$
write string 2, currentaccstatus$
close file 2
cls
print "Saved"
wait key
return

change:
input "Enter directory (1 is default)> ",currentdirectory$
if currentdirectory$ = "1" then gosub defaultdir
open to write 3, "directory"
write string 3, currentdirectory$
close file 3
cd currentdirectory$
cls
print "'" + currentdirectory$ + "' has been set to the default directory."
wait key
open to write 3, "directory"
write string 3, currentdirectory$
close file 3
cls
return

defaultdir:
open to read 4, "directory"
read string 4, defaultdir$
cd defaultdir$
close file 4
cls
print "'" + defaultdir$ + "' has been set to the default directory."
wait key
return

Back to top

Profile PM Email

Game Master1330

17

Years of Service

User Offline

Joined: 19th Oct 2007

Location: (GetReaderXYZ() * 42 ) / 0

Posted: 1st Oct 2009 09:52

Link

Thanks! This really helps. I knew about the file exist command and all of the commands that return a number but I didnt know how to use them and thanks for explaining the goto gosub thing. the reason I put the goto choices in every subroutine was because at the end of the subroutine, it always exited. Now i know that it was because of goto.

Thanks for the help!
Matt

Umm...

Back to top

Profile PM Email

Grog Grueslayer

Valued Member

19

Years of Service

User Offline

Joined: 30th May 2005

Playing: Green Hell

Posted: 1st Oct 2009 21:02

Link

Np.

Back to top

Profile PM Email

Sorry your browser is not supported!

Newcomers DBPro Corner / Can someone help with my database please?