String + Variable Addition ( DB Noob )

Author

Message

Swampert

15

Years of Service

User Offline

Joined: 17th Dec 2008

Location: Somewhere in the Interwebs

Posted: 26th Nov 2009 20:29 Edited at: 26th Nov 2009 20:31

Link

I'm sure this is probably going to be a very stupid question but hey, that means that it has an easy answer.

I just started with DarkBASIC after coming from C++ ( Dark GDK ). C++ is really going down the tubes I'm telling you. I'm going to be taking a class on it later then I'll settle down and maybe create my own game engine but I'm droning on now.

I'm making a little text based game for my friend to start out with DB and for some reason, if you lose the game, instead of printing out "You have lost, the winner is ";ePoke$, it does nothing and executes my replay function. It also does not display the winning message. What am I doing wrong?

Type Advantage is where the winning/losing comes in Fire-Water-Grass etc.

P1$ = "Bulbasaur"
P2$ = "Ivysaur"
P3$ = "Venusaur"
P4$ = "Charmander"
P5$ = "Charmeleon"
P6$ = "Charizard"
P7$ = "Squirtle"
P8$ = "Wartortle"
P9$ = "Blastoise"

game:
    input "Type in a number between 1 and 9 - ", playerP
    if playerP=1 then print "You have chosen Bulbasaur"
    
    if playerP=2 then print "You have chosen Ivysaur"
    
    
    if playerP=3 then print "You have chosen Venusaur"
    
    
    if playerP=4 then print "You have chosen Charmander"
    
    
    if playerP=5 then print "You have chosen Charmeleon"
    
    
    if playerP=6 then print "You have chosen Charizard"
    
    
    if playerP=7 then print "You have chosen Squirtle"
    
    
    if playerP=8 then print "You have chosen Wartortle"
    
    
    if playerP=9 then print "You have chosen Blastoise"
    
    if playerP>9 or playerP<1 then print "You did not enter a valid number"
    if playerP>9 or playerP<1 then gosub game
    
    input "Enter another number between 1 and 9 - ", enemyP
    
    if enemyP=1 then print "Your enemy has chosen Bulbasaur"
    if enemyP=1 then ePoke$=P1$
    
    if enemyP=2 then print "Your enemy has chosen Ivysaur"
    if enemyP=2 then ePoke$=P2$
    
    if enemyP=3 then print "Your enemy has chosen Venusaur"
    if enemyP=3 then ePoke$=P3$
    
    if enemyP=4 then print "Your enemy has chosen Charmander"
    if enemyP=4 then ePoke$=P4$
    
    if enemyP=5 then print "Your enemy has chosen Charmeleon"
    if enemyP=5 then ePoke$=P5$
    
    if enemyP=6 then print "Your enemy has chosen Charizard"
    if enemyP=6 then ePoke$=P6$
    
    if enemyP=7 then print "Your enemy has chosen Squirtle"
    if enemyP=7 then ePoke$=P7$
    
    if enemyP=8 then print "Your enemy has chosen Wartortle"
    if enemyP=8 then ePoke$=P8$
    
    if enemyP=9 then print "Your enemy has chosen Blastoise"
    if enemyP=9 then ePoke$=P9$
    
    if enemyP>9 or enemyP<1 then print "You did not enter a valid number"
    if enemyP>9 or enemyP<1 then gosub game
    
    wait 1500 //Wait for 1.5 seconds
    
    if playerP=1 and enemyP=1 then print "You have tied. Both Pokemon have Fainted"
    wait 2000
    playagain()
    if playerP=2 and enemyP=2 then print "You have tied. Both Pokemon have Fainted"
    wait 2000
    playagain()
    if playerP=3 and enemyP=3 then print "You have tied. Both Pokemon have Fainted"
    wait 2000
    playagain()
    if playerP=4 and enemyP=4 then print "You have tied. Both Pokemon have Fainted"
    wait 2000
    playagain()
    if playerP=5 and enemyP=5 then print "You have tied. Both Pokemon have Fainted"
    wait 2000
    playagain()
    if playerP=6 and enemyP=6 then print "You have tied. Both Pokemon have Fainted"
    wait 2000
    playagain()
    if playerP=7 and enemyP=7 then print "You have tied. Both Pokemon have Fainted"
    wait 2000
    playagain()
    if playerP=8 and enemyP=8 then print "You have tied. Both Pokemon have Fainted"
    wait 2000
    playagain()
    if playerP=9 and enemyP=9 then print "You have tied. Both Pokemon have Fainted"
    wait 2000
    playagain()
    //If You're Bulbasaur and the enemy is not a water type, then you lose.
    if playerP=1 and enemyP>1 and enemyP<7 then print "You have lost. The winner is ";ePoke$ else print "You have won!"
    wait 2000
    playagain()
    //If You're Ivysaur and the enemy is not a water type or a Bulbasaur, then you lose.
    if playerP=2 and enemyP>2 and enemyP<7 then print "You have lost. The winner is ";ePoke$ else print "You have won!"
    wait 2000
    playagain()
    //If you're Venusaur and the enemy is not a water type or a previous evolution, then you lose.
    if playerP=3 and enemyP>3 and enemyP<7 then print "You have lost. The winner is ";ePoke$ else print "You have won!"
    wait 2000
    playagain()
    //If you're Charmander and the enemy is not a grass type or a previous evolution, then you lose.
    if playerP=4 and enemyP>4 then print "You have lost. The winner is ";ePoke$ else print "You have won!"
    wait 2000
    playagain()
    //If you're Charmeleon and the enemy is not a grass type or a previous evolution, then you lose.
    if playerP=5 and enemyP>5 then print "You have lost. The winner is ";ePoke$ else print "You have won!"
    wait 2000
    playagain()
    //If you're a Charizard and the enemy is not a grass type or a previous evolution, then you lose.
    if playerP=6 and enemyP>6 then print "You have lost. The winner is ";ePoke$ else print "You have won!"
    wait 2000
    playagain()
    //If you're a Squirtle and the enemy is not a fire type or a previous evolution, then you lose.
    if playerP=7 and enemyP>0 and enemyP<4 then print "You have lost. The winner is ";ePoke$ else print "You have won!"
    wait 2000
    playagain()
    //Above Evolutions
    if playerP=7 and enemyP>7 then print "You have lost. The winner is ";ePoke$
    wait 2000
    playagain()   
    //If you're a Wartortle and the enemy is not a fire type or a previous evolution, then you lose.
    if playerP=8 and enemyP>0 and enemyP<4 then print "You have lost. The winner is ";ePoke$ else print "You have won!"
    wait 2000
    playagain()
    //Above Evolutions    
    if playerP=8 and enemyP>8 then print "You have lost. The winner is ";ePoke$
    wait 2000
    playagain()
    //If you're a Blastoise and the enemy is not a fire type or a previous evolution, then you lose.
    if playerP=9 and enemyP>0 and enemyP<4 then print "You have lost. The winner is ";ePoke$ else print "You have won!"
    wait 2000
    playagain()
    
function playagain()
	print "Would you like to play again? Y/N"	
	wait key
	if inkey$()="y" then gosub game else end
endfunction

+ Code Snippet

P1$ = "Bulbasaur"
P2$ = "Ivysaur"
P3$ = "Venusaur"
P4$ = "Charmander"
P5$ = "Charmeleon"
P6$ = "Charizard"
P7$ = "Squirtle"
P8$ = "Wartortle"
P9$ = "Blastoise"

game:
    input "Type in a number between 1 and 9 - ", playerP
    if playerP=1 then print "You have chosen Bulbasaur"
    
    if playerP=2 then print "You have chosen Ivysaur"
    
    
    if playerP=3 then print "You have chosen Venusaur"
    
    
    if playerP=4 then print "You have chosen Charmander"
    
    
    if playerP=5 then print "You have chosen Charmeleon"
    
    
    if playerP=6 then print "You have chosen Charizard"
    
    
    if playerP=7 then print "You have chosen Squirtle"
    
    
    if playerP=8 then print "You have chosen Wartortle"
    
    
    if playerP=9 then print "You have chosen Blastoise"
    
    if playerP>9 or playerP<1 then print "You did not enter a valid number"
    if playerP>9 or playerP<1 then gosub game
    
    input "Enter another number between 1 and 9 - ", enemyP
    
    if enemyP=1 then print "Your enemy has chosen Bulbasaur"
    if enemyP=1 then ePoke$=P1$
    
    if enemyP=2 then print "Your enemy has chosen Ivysaur"
    if enemyP=2 then ePoke$=P2$
    
    if enemyP=3 then print "Your enemy has chosen Venusaur"
    if enemyP=3 then ePoke$=P3$
    
    if enemyP=4 then print "Your enemy has chosen Charmander"
    if enemyP=4 then ePoke$=P4$
    
    if enemyP=5 then print "Your enemy has chosen Charmeleon"
    if enemyP=5 then ePoke$=P5$
    
    if enemyP=6 then print "Your enemy has chosen Charizard"
    if enemyP=6 then ePoke$=P6$
    
    if enemyP=7 then print "Your enemy has chosen Squirtle"
    if enemyP=7 then ePoke$=P7$
    
    if enemyP=8 then print "Your enemy has chosen Wartortle"
    if enemyP=8 then ePoke$=P8$
    
    if enemyP=9 then print "Your enemy has chosen Blastoise"
    if enemyP=9 then ePoke$=P9$
    
    if enemyP>9 or enemyP<1 then print "You did not enter a valid number"
    if enemyP>9 or enemyP<1 then gosub game
    
    wait 1500 //Wait for 1.5 seconds
    
    if playerP=1 and enemyP=1 then print "You have tied. Both Pokemon have Fainted"
    wait 2000
    playagain()
    if playerP=2 and enemyP=2 then print "You have tied. Both Pokemon have Fainted"
    wait 2000
    playagain()
    if playerP=3 and enemyP=3 then print "You have tied. Both Pokemon have Fainted"
    wait 2000
    playagain()
    if playerP=4 and enemyP=4 then print "You have tied. Both Pokemon have Fainted"
    wait 2000
    playagain()
    if playerP=5 and enemyP=5 then print "You have tied. Both Pokemon have Fainted"
    wait 2000
    playagain()
    if playerP=6 and enemyP=6 then print "You have tied. Both Pokemon have Fainted"
    wait 2000
    playagain()
    if playerP=7 and enemyP=7 then print "You have tied. Both Pokemon have Fainted"
    wait 2000
    playagain()
    if playerP=8 and enemyP=8 then print "You have tied. Both Pokemon have Fainted"
    wait 2000
    playagain()
    if playerP=9 and enemyP=9 then print "You have tied. Both Pokemon have Fainted"
    wait 2000
    playagain()
    //If You're Bulbasaur and the enemy is not a water type, then you lose.
    if playerP=1 and enemyP>1 and enemyP<7 then print "You have lost. The winner is ";ePoke$ else print "You have won!"
    wait 2000
    playagain()
    //If You're Ivysaur and the enemy is not a water type or a Bulbasaur, then you lose.
    if playerP=2 and enemyP>2 and enemyP<7 then print "You have lost. The winner is ";ePoke$ else print "You have won!"
    wait 2000
    playagain()
    //If you're Venusaur and the enemy is not a water type or a previous evolution, then you lose.
    if playerP=3 and enemyP>3 and enemyP<7 then print "You have lost. The winner is ";ePoke$ else print "You have won!"
    wait 2000
    playagain()
    //If you're Charmander and the enemy is not a grass type or a previous evolution, then you lose.
    if playerP=4 and enemyP>4 then print "You have lost. The winner is ";ePoke$ else print "You have won!"
    wait 2000
    playagain()
    //If you're Charmeleon and the enemy is not a grass type or a previous evolution, then you lose.
    if playerP=5 and enemyP>5 then print "You have lost. The winner is ";ePoke$ else print "You have won!"
    wait 2000
    playagain()
    //If you're a Charizard and the enemy is not a grass type or a previous evolution, then you lose.
    if playerP=6 and enemyP>6 then print "You have lost. The winner is ";ePoke$ else print "You have won!"
    wait 2000
    playagain()
    //If you're a Squirtle and the enemy is not a fire type or a previous evolution, then you lose.
    if playerP=7 and enemyP>0 and enemyP<4 then print "You have lost. The winner is ";ePoke$ else print "You have won!"
    wait 2000
    playagain()
    //Above Evolutions
    if playerP=7 and enemyP>7 then print "You have lost. The winner is ";ePoke$
    wait 2000
    playagain()   
    //If you're a Wartortle and the enemy is not a fire type or a previous evolution, then you lose.
    if playerP=8 and enemyP>0 and enemyP<4 then print "You have lost. The winner is ";ePoke$ else print "You have won!"
    wait 2000
    playagain()
    //Above Evolutions    
    if playerP=8 and enemyP>8 then print "You have lost. The winner is ";ePoke$
    wait 2000
    playagain()
    //If you're a Blastoise and the enemy is not a fire type or a previous evolution, then you lose.
    if playerP=9 and enemyP>0 and enemyP<4 then print "You have lost. The winner is ";ePoke$ else print "You have won!"
    wait 2000
    playagain()
    
function playagain()
	print "Would you like to play again? Y/N"	
	wait key
	if inkey$()="y" then gosub game else end
endfunction

Back to top

Profile PM Email

Hockeykid

DBPro Tool Maker

17

Years of Service

User Offline

Joined: 26th Sep 2007

Location:

Posted: 26th Nov 2009 20:50 Edited at: 26th Nov 2009 20:51

Link

Edit : never mind

Back to top

Profile PM Email

Latch

18

Years of Service

User Offline

Joined: 23rd Jul 2006

Location:

Posted: 26th Nov 2009 21:26

Link

Hello,

I'm actually surprised this would run at all in DBC. For one, you are using the comment indicator '//' which doesn't exist in DBC and will cause an error. To turn a single line into a comment either use
rem blah blah blah
or
use the reverse single quote (the key next to the 1 key)
` blah blah blah
If you want to add a comment on the same line after code, then separte the code and the comment with a ':'

+ Code Snippet

wait 1500 : rem Wait for 1.5 seconds

To remoark entire blocks of text use

+ Code Snippet

remstart
    code
remend

And number 2, in your function:

+ Code Snippet

function playagain() 
        print "Would you like to play again? Y/N"        
        wait key 
        if inkey$()="y" then gosub game else end 
endfunction

You have a reference to 'game' which does not exist inside the function. Any labels for subroutines referenced inside a function, must be created inside the function. You are trying to gosub to a label that exists in the main program outside of the function. The function cannot recognize this.

And in general, if you have huge lists of choices that depend on the value of a single variable, you can use the Select Case command combination. If you use C or C++, it is similar to the switch case combo:

+ Code Snippet

    input "Type in a number between 1 and 9 - ", playerP
    select playerP
      case 1 : print "You have chosen Bulbasaur" : endcase
      case 2 : print "You have chosen Ivysaur" : endcase
      case 3 : print "You have chosen Venusaur" : endcase

      etc...

      case default
          print "You did not enter a valid number"
          gosub game
      endcase
    endselect

Enjoy your day.

Back to top

Profile PM

Swampert

15

Years of Service

User Offline

Joined: 17th Dec 2008

Location: Somewhere in the Interwebs

Posted: 26th Nov 2009 23:14

Link

Ah. I'm using DBP. and that doesn't seem to be the problem because Although it doesn't give me whether I win or lose, it does go back to the game subroutine after pressing Y to play again.

Back to top

Profile PM Email

Digger412

17

Years of Service

User Offline

Joined: 12th Jun 2007

Location:

Posted: 27th Nov 2009 00:32 Edited at: 27th Nov 2009 00:32

Link

@Swampert - Hmm...I'm looking at it and I don't know why it wouldn't work. This works, though:

dim pokemon$(9)

for x=1 to 9
   read pkmn$
   pokemon$(x)=pkmn$
next x

game:
input "Type in a number between 1 and 9 - ", playerP
if playerP>0 and playerP<10
   print "You have chosen "+pokemon$(playerP)
else
   print "You did not enter a valid number"
   gosub game
endif

game2:
input "Enter another number between 1 and 9 - ", enemyP
if enemyP>0 and enemyP<10
   print "Your enemy has chosen "+pokemon$(enemyP)
   ePoke$=pokemon$(enemyP)
else
   print "You did not enter a valid number"
   gosub game2
endif

wait 1500

if playerP=enemyP
   print "You have tied. Both Pokemon have Fainted"
else
   battle(playerP,enemyP)
endif

wait 2000
play=playagain()
if play=1 : gosub game : else : end : endif

function battle(playerP,enemyP)
   rem if a=0 then you lose, if a=1 then you win
   select playerP
      case 1 : if enemyP>1 and enemyP<7 : a=0 : else : a=1 : endif : endcase
      case 2 : if enemyP>2 and enemyP<7 : a=0 : else : a=1 : endif : endcase
      case 3 : if enemyP>3 and enemyP<7 : a=0 : else : a=1 : endif : endcase
      case 4 : if enemyP>4 : a=0 : else : a=1 : endif : endcase
      case 5 : if enemyP>5 : a=0 : else : a=1 : endif : endcase
      case 6 : if enemyP>6 : a=0 : else : a=1 : endif : endcase
      case 7 : if (enemyP>0 and enemyP<4) or enemyP>7 : a=0 : else : a=1 : endif : endcase
      case 8 : if (enemyP>0 and enemyP<4) or enemyP>8 : a=0 : else : a=1 : endif : endcase
      case 9 : if enemyP>0 and enemyP<4 : a=0 : else : a=1 : endif : endcase
   endselect
   if a=0 : print "You have lost. The winner is "+pokemon$(enemyP) : endif
   if a=1 : print "You have won!" : endif
endfunction

function playagain()
        input "Would you like to play again? Y/N ", again$
        if lower$(again$)="y" then play=1
endfunction play

rem stores pokemon names
data "Bulbasaur","Ivysaur","Venusaur","Charmander","Charmeleon","Charizard","Squirtle","Wartortle","Blastoise"

+ Code Snippet

dim pokemon$(9)

for x=1 to 9
   read pkmn$
   pokemon$(x)=pkmn$
next x

game:
input "Type in a number between 1 and 9 - ", playerP
if playerP>0 and playerP<10
   print "You have chosen "+pokemon$(playerP)
else
   print "You did not enter a valid number"
   gosub game
endif

game2:
input "Enter another number between 1 and 9 - ", enemyP
if enemyP>0 and enemyP<10
   print "Your enemy has chosen "+pokemon$(enemyP)
   ePoke$=pokemon$(enemyP)
else
   print "You did not enter a valid number"
   gosub game2
endif

wait 1500

if playerP=enemyP
   print "You have tied. Both Pokemon have Fainted"
else
   battle(playerP,enemyP)
endif

wait 2000
play=playagain()
if play=1 : gosub game : else : end : endif

function battle(playerP,enemyP)
   rem if a=0 then you lose, if a=1 then you win
   select playerP
      case 1 : if enemyP>1 and enemyP<7 : a=0 : else : a=1 : endif : endcase
      case 2 : if enemyP>2 and enemyP<7 : a=0 : else : a=1 : endif : endcase
      case 3 : if enemyP>3 and enemyP<7 : a=0 : else : a=1 : endif : endcase
      case 4 : if enemyP>4 : a=0 : else : a=1 : endif : endcase
      case 5 : if enemyP>5 : a=0 : else : a=1 : endif : endcase
      case 6 : if enemyP>6 : a=0 : else : a=1 : endif : endcase
      case 7 : if (enemyP>0 and enemyP<4) or enemyP>7 : a=0 : else : a=1 : endif : endcase
      case 8 : if (enemyP>0 and enemyP<4) or enemyP>8 : a=0 : else : a=1 : endif : endcase
      case 9 : if enemyP>0 and enemyP<4 : a=0 : else : a=1 : endif : endcase
   endselect
   if a=0 : print "You have lost. The winner is "+pokemon$(enemyP) : endif
   if a=1 : print "You have won!" : endif
endfunction

function playagain()
        input "Would you like to play again? Y/N ", again$
        if lower$(again$)="y" then play=1
endfunction play

rem stores pokemon names
data "Bulbasaur","Ivysaur","Venusaur","Charmander","Charmeleon","Charizard","Squirtle","Wartortle","Blastoise"

Back to top

Profile PM

IanM

Retired Moderator

22

Years of Service

User Offline

Joined: 11th Sep 2002

Location: In my moon base

Posted: 28th Nov 2009 00:13

Link

Why are you all using GOSUB as if it were GOTO? Using GOSUB without having an equivalent RETURN statement is worse than GOTO on it's own - you are basically lying to yourself in code.

Also there's no need for this code to have any GOTO in it at all. For example:

+ Code Snippet

game:
input "Type in a number between 1 and 9 - ", playerP
if playerP>0 and playerP<10
   print "You have chosen "+pokemon$(playerP)
else
   print "You did not enter a valid number"
   gosub game
endif

Can be rewritten as:

+ Code Snippet

repeat
   input "Type in a number between 1 and 9 - ", playerP
   if playerP<1 and playerP>9
      print "You did not enter a valid number"
      playerP = 0
   endif
until playerP > 0
print "You have chosen "+pokemon$(playerP)

Utility plug-ins collection (updated 22 Oct 2009) and
http://www.matrix1.demon.co.uk

Back to top

Profile PM Email Website

Sorry your browser is not supported!

Newcomers DBPro Corner / String + Variable Addition ( DB Noob )