find character - GameCreators Forum

Author

Message

Dimension

20

Years of Service

User Offline

Joined: 23rd Nov 2003

Location:

Posted: 18th Aug 2010 01:45

Link

I'm creating a function to find the position of a character and for some reason it can't see when the characters are equal.

+ Code Snippet

int findCharacterPosition(char *string, char *character)
{
	for(int position = 1; position <= dbLen(string); position++)
	{
		if(dbMid(string, position) == character)
		{
			return position;
		}
	}
	
	return -1;
}

But when I modify the code as follows for some reason it works

+ Code Snippet


int findCharacterPosition(char *string, char *character)
{
	for(int position = 1; position <= dbLen(string); position++)
	{
		//Here I converted it to ASCII code
		if(dbAsc(dbMid(string, position)) == dbAsc(character))
		{
			return position;
		}
	}
	
	return -1;
}

Does anybody know why this is?

Back to top

Profile PM

Bran flakes91093

15

Years of Service

User Offline

Joined: 13th Sep 2008

Location: Crazy Land

Posted: 18th Aug 2010 01:59

Link

In the first code snippet, you are comparing two pointers, which are addresses in memory. You are not comparing the strings themselves, just where they are located in memory.

In the second snippet, you are comparing the strings correctly, byte by byte, but there is an easier way.

Use strcmp.

“C++ : Where friends have access to your private members.”
-Gavin Russell Baker

Back to top

Profile PM Email

Dimension

20

Years of Service

User Offline

Joined: 23rd Nov 2003

Location:

Posted: 18th Aug 2010 02:39

Link

Thanks for the help.

Back to top

Profile PM

dark coder

21

Years of Service

User Offline

Joined: 6th Oct 2002

Location: Japan

Posted: 18th Aug 2010 06:29

Link

Keep in mind dbMid returns a string on the heap, so your code will leak memory. Such a function doesn't even require GDK functions, just do something like:

+ Code Snippet

int findCharacterPosition(const char *string, char character)
{
	size_t length = strlen( string );
	for ( unsigned int position = 0; position < length; position++ )
		if ( string[position] == character )
			return position;
	
	return -1;
}

Of course a better method would be to use a string class, such as std::string which has find_first_of.

Back to top

Profile PM Email

Sorry your browser is not supported!

Dark GDK / find character