Read statement is reading the Data (I think) into the array but array(XXX).name is empty.

Author

Message

Fangs

15

Years of Service

User Offline

Joined: 24th Oct 2008

Location: 40 some miles North of the Emerald Coast

Posted: 30th Aug 2010 20:14

Link

In my text game, I've lost all my NPCs. In game, when an NPC is supposed to appear, I get 'There is a here' and the game continues.

Checking my code against a back-up copy, I can find no difference.
I placed 'print' statements into the 'for/next' loop to print (i) and array(xxx).name(i). 'i' prints out 1 through 10 while array(xxx).name(i) prints nothing.

In the 'encounters' subroutine I have the same print statements. 'i' is randomly generated and array(xxx).name(i) should give me the name of the NPC. I get the number but no name.

HELP!

The Fangman

Back to top

Profile PM

LBFN

17

Years of Service

User Offline

Joined: 7th Apr 2007

Location: USA

Posted: 30th Aug 2010 21:09

Link

It seems to me that your usage of UDT's is not quite right. I can see it being array(i).name, but not array(xxx).name(i). If this is not it, then maybe you could post where you define the UDTs in your code.

So many games to code.......so little time.

Back to top

Profile PM Email

=PRoF=

21

Years of Service

User Offline

Joined: 17th Mar 2003

Location: Milton Keynes, UK

Posted: 30th Aug 2010 21:14

Link

LBFN is correct, you cannot use an array inside a typed array.

array(xx).name is ok

array(xx).name(x) is not ok, It's quite annoying but with some lateral thinking can be worked around

Back to top

Profile PM Email Website

Fangs

15

Years of Service

User Offline

Joined: 24th Oct 2008

Location: 40 some miles North of the Emerald Coast

Posted: 31st Aug 2010 01:33

Link

This code works:

+ Code Snippet

` NPCs

` DECLARE MAXIMUM NUMBER OF NPCs IN GAME
MAX_NPC = 10

` CREATE A TYPE DEFINITION FOR NPCs

TYPE NPC
	NAME AS STRING
	DESC1 AS STRING
	DESC2 AS STRING
	LOCATION AS FLOAT
	SHOW AS INTEGER
	ATTACKING AS INTEGER
	KILLABLE AS INTEGER
	GOOD AS INTEGER
	THIEF AS INTEGER
	TALK AS INTEGER
	BAD AS INTEGER
ENDTYPE

` create an array of NPCs
DIM NPC_ARRAY(MAX_NPC) AS NPC

+ Code Snippet

` POPULATE THE ARRAY WITH NPC DATA

	FOR i = 1 TO MAX_NPC
		READ NPC_ARRAY(i).NAME
		READ NPC_ARRAY(i).DESC1
		READ NPC_ARRAY(i).DESC2
		READ NPC_ARRAY(i).LOCATION
		READ NPC_ARRAY(i).SHOW
		READ NPC_ARRAY(i).ATTACKING
		READ NPC_ARRAY(i).KILLABLE
		READ NPC_ARRAY(i).GOOD
		READ NPC_ARRAY(i).THIEF
		READ NPC_ARRAY(i).TALK
		READ NPC_ARRAY(i).BAD
	NEXT i

+ Code Snippet

` Game NPCs
` 1 name, 2 desc, 3 desc2 , 4 loc, 5 show, 6 attacking, 7 killable, 8 good, 9 thief, 10 talk, 11 bad,

	DATA "rat", "gigantic", "",0,1,1,1,0,0,0,1   ` 1
	DATA "gnome","warty","",0,1,1,1,0,1,0,1      ` 2
	DATA "troll","ugly","",0,1,1,1,0,1,0,1       ` 3
	DATA "bigfoot","hairy","",0,1,1,1,0,0,0,1    ` 4
	DATA "leprechaun","tiny","",0,1,0,0,1,1,1,0  ` 5
	DATA "fairy","golden","",0,1,0,0,1,0,1,0     ` 6
	DATA "wumpus","","",0,1,1,1,0,0,0,1          ` 7
	DATA "cadaver","","",0,1,0,0,1,0,1,0         ` 8
	DATA "elf","fat old","",26,1,0,0,0,0,1,0     ` 9
	DATA "lady","tiny old","",25,1,0,0,1,0,1,0   ` 10

This is the calling code (it also works).

+ Code Snippet

` Meeting some interestin folks
ENCOUNTERS:
   RANDOMIZE TIMER()
   IF plr_loc = 26
		      PRINT "There is a " + NPC_ARRAY(NPC1).DESC1 + " " + NPC_ARRAY(NPC1).NAME + " here."
   	    RETURN
   ENDIF

   IF plr_loc = 25
   	    npc1 = 10
 		    PRINT "There is a " + NPC_ARRAY(NPC1).DESC1 + " " + NPC_ARRAY(NPC1).NAME + " here."
  	    RETURN
   ENDIF
	  ` rnd(19) 8 out of 20 chances of meeting one of the NPCs
	   	i = RND(19) 
	  IF i < 1 THEN i = 20
	  IF i > 8 THEN RETURN
   ` LIST ANY NPCs at PLAYER LOCATION
   IF i => 8 THEN NPC_ARRAY(i).location = plr_loc
   	NPC1 = i   
 	 IF NPC_ARRAY(NPC1).SHOW = 1 
	      IF LEN(NPC_ARRAY(NPC1).DESC1) > 0 
			        PRINT "There is a " + NPC_ARRAY(NPC1).DESC1 + " " + NPC_ARRAY(NPC1).NAME + " here."
	      ELSE
	          PRINT "There is a " + NPC_ARRAY(NPC1).NAME + " here."
	      ENDIF
	      IF NPC_ARRAY(NPC1).attacking = 1
			        PRINT
	          GOSUB cmd_attack
	          RETURN
	      ENDIF
	  ENDIF
RETURN

I have compared this code with the current build and can see no differences.

The Fangman

Back to top

Profile PM

LBFN

17

Years of Service

User Offline

Joined: 7th Apr 2007

Location: USA

Posted: 31st Aug 2010 03:27

Link

Try reading the values into a variable and then setting the value of the NPC_ARRAY. Instead of :

+ Code Snippet

READ NPC_ARRAY(i).NAME

try

+ Code Snippet

READ name$ : NPC_ARRAY(i).NAME = name$

I seem to remember that DBP has trouble reading directly into UDT variables.

So many games to code.......so little time.

Back to top

Profile PM Email

Fangs

15

Years of Service

User Offline

Joined: 24th Oct 2008

Location: 40 some miles North of the Emerald Coast

Posted: 1st Sep 2010 03:02

Link

O.K. Guy's I found MY screw-up!!!

Actually there were two mistakes :

1 Max_OBJ was set at '45' while there were 36 read statements.
When MAX_OBJ for/next loop read the 36 lines of data, the
next set of data provided the next 9 lines.

2 The next set of data was in the wrong place (above
NPC_ARRAY).

I guess old age is getting to my eyes! I saw that '45' a thousand times and passed right over. After the # change, it was only a few print statements to find the second problem.

Bottom line...everything works correctly.

The Fangman

Back to top

Profile PM

Sorry your browser is not supported!

Newcomers DBPro Corner / Read statement is reading the Data (I think) into the array but array(XXX).name is empty.