Map displays wrong - GameCreators Forum

Author

Message

GameMaker Jason

21

Years of Service

User Offline

Joined: 22nd Nov 2003

Location: UK

Posted: 10th Jul 2004 03:56

Link

When i run this code

Remstart
Aurthor: Beehive Studios
Date Started: 08/07/2004
Date Last modified: 08/07/2004
Product Name: 3D Pacman
Product Version: v0.1
Remend

Rem Initialization
Set Display Mode 800,600,32
Hide Mouse : Sync On : Sync Rate 40
Backdrop On : Color Backdrop RGB(0,0,0) : CLS

Rem Setup map vairables
Mapsize=23
Dim Map$(Mapsize,Mapsize)
MapObjectNumber=1
LevelCreated=0

Rem Make a light
Make Light 1
Position Light 1,368,150,368
Point Light 1,368,0,368

Rem load textures
Load image "Wall.jpg",1,1
Load image "Floor.jpg",2,1

Do
	LoadMap("Level1.txt",Mapsize)
	If levelCreated=0
		For x=1 to Mapsize
			For z=1 to Mapsize
				If Map$(z,x)="#"
					Make Object Cube MapObjectNumber,32
					Position Object MapObjectNumber,x*32,0,z*32
					Texture Object MapObjectNumber,1
					MapObjectNumber=MapObjectNumber+1
				endif
			next z
		next x
		For x=1 to Mapsize
			For z=1 to Mapsize
				If Map$(z,x)="."
					Make Object Plain MapObjectNumber,32,32
					Position Object MapObjectNumber,x*32,0,z*32
					Texture Object MapObjectNumber,2
					MapObjectNumber=MapObjectNumber+1
				endif
			next z
		Next x
		levelCreated=1
	Endif
	If EscapeKey()=1 then end
	Position Camera 1000,400,1000
	Point Camera 368,0,368
	Sync
Loop

Function LoadMap(Filename$,Size)
	Open to read 1,Filename$
	For x=1 to Size
	For y=1 to Size
		Read Byte 1,tmp
		map$(x,y)=chr$(tmp)
	next y
	next x
	Close File 1
Endfunction

+ Code Snippet

Remstart
Aurthor: Beehive Studios
Date Started: 08/07/2004
Date Last modified: 08/07/2004
Product Name: 3D Pacman
Product Version: v0.1
Remend

Rem Initialization
Set Display Mode 800,600,32
Hide Mouse : Sync On : Sync Rate 40
Backdrop On : Color Backdrop RGB(0,0,0) : CLS

Rem Setup map vairables
Mapsize=23
Dim Map$(Mapsize,Mapsize)
MapObjectNumber=1
LevelCreated=0

Rem Make a light
Make Light 1
Position Light 1,368,150,368
Point Light 1,368,0,368

Rem load textures
Load image "Wall.jpg",1,1
Load image "Floor.jpg",2,1

Do
	LoadMap("Level1.txt",Mapsize)
	If levelCreated=0
		For x=1 to Mapsize
			For z=1 to Mapsize
				If Map$(z,x)="#"
					Make Object Cube MapObjectNumber,32
					Position Object MapObjectNumber,x*32,0,z*32
					Texture Object MapObjectNumber,1
					MapObjectNumber=MapObjectNumber+1
				endif
			next z
		next x
		For x=1 to Mapsize
			For z=1 to Mapsize
				If Map$(z,x)="."
					Make Object Plain MapObjectNumber,32,32
					Position Object MapObjectNumber,x*32,0,z*32
					Texture Object MapObjectNumber,2
					MapObjectNumber=MapObjectNumber+1
				endif
			next z
		Next x
		levelCreated=1
	Endif
	If EscapeKey()=1 then end
	Position Camera 1000,400,1000
	Point Camera 368,0,368
	Sync
Loop

Function LoadMap(Filename$,Size)
	Open to read 1,Filename$
	For x=1 to Size
	For y=1 to Size
		Read Byte 1,tmp
		map$(x,y)=chr$(tmp)
	next y
	next x
	Close File 1
Endfunction

my cubes and plains do not position them selves in the right place. what am i doing wrong?

here is the map file

+ Code Snippet

#######################
#..........#..........#
#.###.####.#.####.###.#
#.# #.#  #.#.#  #.# #.#
#.###.####.#.####.###.#
#.....................#
#.###.#.#######.#.###.#
#.....#....#....#.....#
#####.####.#.####.#####
    #.#.........#.#    
#####.#.#######.#.#####
........#     #........
#####.#.#######.#.#####
    #.#.........#.#    
#####.#.#######.#.#####
#..........#..........#
#.###.####.#.####.###.#
#...#.............#...#
###.#.#.#######.#.#.###
#.....#....#....#.....#
#.########.#.########.#
#.....................#
#######################

I also have a screenshot.

http://www.beehivestudios.tk/

Back to top

Profile PM Email Website

SandraD

20

Years of Service

User Offline

Joined: 30th May 2004

Location: Down on the corner, out in the street.

Posted: 10th Jul 2004 05:25

Link

Jason,

I would also like to point out that you don't need to do a double loop for creating your level this should work fine;

+ Code Snippet

	   For x=1 to Mapsize
			For z=1 to Mapsize
				If Map$(z,x)="#"
					Make Object Cube MapObjectNumber,32
					Position Object MapObjectNumber,x*32,0,z*32
					Texture Object MapObjectNumber,1
					MapObjectNumber=MapObjectNumber+1
				endif
				If Map$(z,x)="."
					Make Object Plain MapObjectNumber,32,32
					Position Object MapObjectNumber,x*32,0,z*32
					Texture Object MapObjectNumber,2
					MapObjectNumber=MapObjectNumber+1
				endif
			next z
		Next x
		levelCreated=1

Now, as for why you're getting these results it's because of your READ MAP code... you have the X & Y values switched around.

+ Code Snippet

Function LoadMap(Filename$,Size)
	Open to read 1,Filename$
	For x=1 to Size
	For y=1 to Size
		Read Byte 1,tmp
		map$(x,y)=chr$(tmp)
	next y
	next x
	Close File 1
Endfunction

In other words -- when READ the map, you're reading it Left-to-Right then Top-to-Bottom, but when you build the image you're building it Top-to-Bottom then Left-To-Right. You're reading code and your building code must match...

In Read, the value it map(x,Y) -- with Y changing first, then X
In Build its map(z,x) -- with Z changing first!

oops.

S.

Any truly great code should be indisguishable from magic.

Back to top

Profile PM

GameMaker Jason

21

Years of Service

User Offline

Joined: 22nd Nov 2003

Location: UK

Posted: 10th Jul 2004 06:02

Link

im sorry but i cant get it to show write
coould you should me where i need to put all my x,y,z's please

thanx

http://www.beehivestudios.tk/

Back to top

Profile PM Email Website

SandraD

20

Years of Service

User Offline

Joined: 30th May 2004

Location: Down on the corner, out in the street.

Posted: 10th Jul 2004 06:07

Link

sure ... change;

+ Code Snippet

Function LoadMap(Filename$,Size)
	Open to read 1,Filename$
	For x=1 to Size
	For y=1 to Size
		Read Byte 1,tmp
		map$(x,y)=chr$(tmp)
	next y
	next x
	Close File 1
Endfunction

TO;

+ Code Snippet

Function LoadMap(Filename$,Size)
	Open to read 1,Filename$
	For x=1 to Size
	For y=1 to Size
		Read Byte 1,tmp
		map$(y,x)=chr$(tmp)
	next y
	next x
	Close File 1
Endfunction

Leave the rest as you posted it...
S.

(Look close -- there IS a change in there!)

Any truly great code should be indisguishable from magic.

Back to top

Profile PM

GameMaker Jason

21

Years of Service

User Offline

Joined: 22nd Nov 2003

Location: UK

Posted: 10th Jul 2004 07:16

Link

this doesn't work i would most apraite it if u would test the code on your pc just don't use the textures

thanx

http://www.beehivestudios.tk/

Back to top

Profile PM Email Website

SandraD

20

Years of Service

User Offline

Joined: 30th May 2004

Location: Down on the corner, out in the street.

Posted: 10th Jul 2004 14:03

Link

Oh! Of course... makes sense now...

You are saving your level file as a TEXT one.. meaning you have two characters at the end of each line. (That's a CR/LF)

The read MUST be changed to reflect this, as in;

+ Code Snippet

Function LoadMap(Filename$,Size)
	Open to read 1,Filename$
	For x=1 to Size
	For y=1 to Size
		Read Byte 1,tmp
		map$(x,y)=chr$(tmp)
	next y
        read byte 1, a
        read byte 1, b
	next x
	Close File 1
Endfunction

You were still reading it wrong in the x/y direction, but the above should solve your troubles...
S.

Any truly great code should be indisguishable from magic.

Back to top

Profile PM

Sorry your browser is not supported!

Newcomers DBPro Corner / Map displays wrong