Problems with Functions. Or loops. I'm not sure. Making menu's.

Author

Message

Dante Corwyn

21

Years of Service

User Offline

Joined: 18th Mar 2003

Location:

Posted: 10th Jul 2006 22:02

Link

I'm using DarkBasicClasic. What's going on is after I press either 1,2 or 3, DB crashes out. And I get one of those 'DB had to close, send report to Microsoft things'. No idea why. Here's my code here.

+ Code Snippet

rem SetUpVariables
 title$ = "ONE NIGHT A LISTENER"
 menu1$ = "1) Play Game"
 menu2$ = "2) Instructions"
 menu3$ = "3) Quit"
  keyboard$ = inkey$

 Rem Menu
  cls
 menu =0
center text 250,50, title$
center text 250,250, menu1$
center text 250,270, menu2$
center text 250,290, menu3$
repeat
if inkey$()= "1" then menu=1
if inkey$()= "2" then menu=2
if inkey$()= "3" then menu=3
until menu>0
rem The line below is meant to call a function that will start the main game
if menu=1 then print "START GAME:CODE ME ALREADY!"
else
  if menu=2
  Instructions()
  else
endif
end

rem Game Instructions
Function Instructions()
cls
print "Instructions go here"
print "Press the <SPACE> bar to continue."
repeat
until inkey$()= " "
EndFunction

The other annoying thing is if I try to make the menu a function with Function MainMenu() , then I just get dumped back to DarkEdit with "Runtime Error at Line 17(the line I start the function). Program ran into a function declaration at line 17". Which was kinda the point. Any idea's? Thanks.

Back to top

Profile PM Email

Crit

18

Years of Service

User Offline

Joined: 24th May 2006

Location:

Posted: 10th Jul 2006 22:32 Edited at: 10th Jul 2006 22:33

Link

That nested "if" structure is probably your problem. I know Dark Basic Pro wouldn't let you do that. This may seem like bad programming, but you could get rid of that structure and just make it regular if statments. This isn't in a place that would benefit from optimized code.

+ Code Snippet

  until menu>0 and menu <=2
  if menu=1 then print "START GAME:CODE ME ALREADY!"
  if menu=2 then Instructions()
end

And make sure your Function Mainmenu() is declared after the "end"

CHESS ENCOUNTER
Demo
WIP

Back to top

Profile PM

Dante Corwyn

21

Years of Service

User Offline

Joined: 18th Mar 2003

Location:

Posted: 10th Jul 2006 23:23

Link

That works. Cheers for the quick responce. One thing that seems a little odd to me though is how functions seem to work, at least in DBC. I ended up having the main menu in the main body, and near-enough duplicating it in a function (it just comes up as another "Runtime Error at Line blah,Program ran into a function declaration at line blah". Thought it was a little badly structured, or is this how DBC sets itself up? Probably better if I show you the code again.

+ Code Snippet

rem SetUpVariables
Rem Menu
  cls
 menu =0
center text 250,50, title$
center text 250,250, menu1$
center text 250,270, menu2$
center text 250,290, menu3$
repeat
if inkey$()= "1" then menu=1
if inkey$()= "2" then menu=2
if inkey$()= "3" then menu=3
until menu>0 and menu <=3
  if menu=1 then print "START GAME:CODE ME ALREADY!"
  if menu=2 then Instructions()
  if menu=3 then end
end

Function MainMenu()
title$ = "ONE NIGHT A LISTENER"
 menu1$ = "1) Play Game"
 menu2$ = "2) Instructions"
 menu3$ = "3) Quit"
 anger = 0
 fear = 0
 conscience = 0
 keyboard$ = inkey$
cls
 menu =0
center text 250,50, title$
center text 250,250, menu1$
center text 250,270, menu2$
center text 250,290, menu3$
repeat
if inkey$()= "1" then menu=1
if inkey$()= "2" then menu=2
if inkey$()= "3" then menu=3
until menu>0 and menu <=3
  if menu=1 then print "START GAME:CODE ME ALREADY!"
  if menu=2 then Instructions()
  if menu=3 then end
end
EndFunction

It hops back and forth from the Instructions function fine, but it seems odd that I cannot set a function right at the start; that I have to duplicate it as a function without having it as a function in the first place. Is this normal, or is this to encourage me to get BB Pro?

Back to top

Profile PM Email

Dream And Death

18

Years of Service

User Offline

Joined: 21st Feb 2006

Location: The circus! Juggling job, kids and DBPro

Posted: 11th Jul 2006 14:53 Edited at: 11th Jul 2006 14:56

Link

No, just looks like you are misunderstanding (a little!) the best way to use functions! Functions are used to remove duplicate code! So write a function that takes your title and choices and makes a menu then waits for an input. e.g.
Function DoMenu(Title$,menu1$,menu2$,menu3$)

Blah...

endfunction Menu

Then have your main code feed the function the right menu title and choices at the right time, and then deal with the returned input.

And functions have to be defined right at the end, otherwise the compiler would just carry on into your function when it shouldn't!

"You get what everyone gets, you get a lifetime!" - Death, The Sandman Library

First you Dream, then you ... - Neil Gaiman, 2001

Back to top

Profile PM

Sorry your browser is not supported!

Newcomers DBPro Corner / Problems with Functions. Or loops. I'm not sure. Making menu's.