DBC detecting when key is no longer being pressed

Author

Message

demons breath

20

Years of Service

User Offline

Joined: 4th Oct 2003

Location: Surrey, UK

Posted: 28th Aug 2006 00:55 Edited at: 28th Aug 2006 01:12

Link

basically like i said in my last post, i'm just trying to get used to the language again and i don't really know what i'm doing

but anyway this is my code:

cls

sync rate 0
sync on

rem load images
load bitmap "tiles.bmp",1
get image 1,0,0,20,20
get image 2,20,0,40,20
get image 3,40,0,60,20
delete bitmap 1

width#=14
height#=14

dim grid(width#,height#)

grid(5,0)=1

do

cls

for t=0 to width#
	for f=0 to height#
		if grid(t,f)=1
			paste image 3,t*20,f*20
		endif
		if grid(t,f)=0
			paste image 1,t*20,f*20
		endif
	next f
next t

if downkey()=1
	for t=0 to width#
		for f=0 to height#
			if grid(t,f)=1
				if f<height#
					grid(t,f)=0
					n=f+1
					grid(t,n)=1
				endif
			endif
		next f
	next t	
endif

if upkey()=1
	for t=0 to width#
		for f=0 to height#
			if grid(t,f)=1
				if f>0
					grid(t,f)=0
					n=f-1
					grid(t,n)=1
				endif
			endif
		next f
	next t	
endif

if leftkey()=1
	for t=0 to width#
		for f=0 to height#
			if grid(t,f)=1
				if t>0
					grid(t,f)=0
					n=t-1
					grid(n,f)=1
				endif
			endif
		next f
	next t	
endif

if rightkey()=1
	for t=0 to width#
		for f=0 to height#
			if grid(t,f)=1
				if t<width#
					grid(t,f)=0
					n=t+1
					grid(n,f)=1
				endif
			endif
		next f
	next t	
endif

sync

loop

+ Code Snippet

cls

sync rate 0
sync on

rem load images
load bitmap "tiles.bmp",1
get image 1,0,0,20,20
get image 2,20,0,40,20
get image 3,40,0,60,20
delete bitmap 1

width#=14
height#=14

dim grid(width#,height#)

grid(5,0)=1




do

cls

for t=0 to width#
	for f=0 to height#
		if grid(t,f)=1
			paste image 3,t*20,f*20
		endif
		if grid(t,f)=0
			paste image 1,t*20,f*20
		endif
	next f
next t	


if downkey()=1
	for t=0 to width#
		for f=0 to height#
			if grid(t,f)=1
				if f<height#
					grid(t,f)=0
					n=f+1
					grid(t,n)=1
				endif
			endif
		next f
	next t	
endif

if upkey()=1
	for t=0 to width#
		for f=0 to height#
			if grid(t,f)=1
				if f>0
					grid(t,f)=0
					n=f-1
					grid(t,n)=1
				endif
			endif
		next f
	next t	
endif

if leftkey()=1
	for t=0 to width#
		for f=0 to height#
			if grid(t,f)=1
				if t>0
					grid(t,f)=0
					n=t-1
					grid(n,f)=1
				endif
			endif
		next f
	next t	
endif

if rightkey()=1
	for t=0 to width#
		for f=0 to height#
			if grid(t,f)=1
				if t<width#
					grid(t,f)=0
					n=t+1
					grid(n,f)=1
				endif
			endif
		next f
	next t	
endif

sync

loop

my problem is, when i press the down button it just shoots to the bottom of the picture... i think this is probably because it keeps adding one until you let go of the down key but i'm not sure... but anyway how do i fix this? is there some simple code i can put in so that it doesn't execute the command until the down key is released?

EDIT: i just updated the code above... i've added in an upkey() and a leftkey() and that works how i want it to, with the movement slow instead of just shooting to the other place, but the rightkey() i added does that same thing... i don't know what i've done wrong

RIP Dimebag
http://db1games.topcities.com
(used to be demonsbreath)

Back to top

Profile PM Website

D Ogre

20

Years of Service

User Offline

Joined: 19th Nov 2003

Location:

Posted: 28th Aug 2006 01:54

Link

You could try using SCANCODE() and KEYSTATE() for yor keyboard inputs.

Back to top

Profile PM

demons breath

20

Years of Service

User Offline

Joined: 4th Oct 2003

Location: Surrey, UK

Posted: 28th Aug 2006 16:12

Link

no luck

i'm a bit stuck on thisn i don't know why the up and down are behaving differently, as the code is almost identical...

RIP Dimebag
http://db1games.topcities.com
(used to be demonsbreath)

Back to top

Profile PM Website

Ginga

18

Years of Service

User Offline

Joined: 3rd Jul 2006

Location: Dorset, England

Posted: 28th Aug 2006 20:22

Link

ok .. i had a slight problem with a similar thing .. I managed to get around it by adding 'Wait 50' near the end, that way, if the key is still being pressed after the time alotted, it will continue again, else move on.

EXAMPLE for upkey

+ Code Snippet


if upkey()=1
  for t=0 to width#
    for f=0 to height#
    if grid(t,f)=1
      if f>0
      grid(t,f)=0
      n=f-1
      grid(t,n)=1
      endif
    endif
    next f
  next t
wait 50
endif

Hope it helps

Back to top

Profile PM Email

demons breath

20

Years of Service

User Offline

Joined: 4th Oct 2003

Location: Surrey, UK

Posted: 28th Aug 2006 21:21

Link

thanks but i already tried that... it just made a little delay before updating the screen, it still just jumped to the bottom of the grid.

RIP Dimebag
http://db1games.topcities.com
(used to be demonsbreath)

Back to top

Profile PM Website

Scraggle

Moderator

21

Years of Service

User Offline

Joined: 10th Jul 2003

Location: Yorkshire

Posted: 28th Aug 2006 21:38

Link

From what I can tell ... your title is a little miss-leading. It seems to me that you don't want to detect if a key is no longer pressed but rather, you want to move a sprite slowly while the key is being pressed.

This should do it:

rem load images
create bitmap 1, 60,60
box 0,0,60,60,Rgb(255,0,0),rgb(0,255,0),rgb(0,0,255),rgb(255,255,0)
get image 1,0,0,20,20
get image 2,20,0,40,20
get image 3,40,0,60,20
delete bitmap 1

Global Width = 14
Global Height = 14
Global Xpos = 1
Global Ypos = 1
Global UpPressed 	
Global DownPressed
Global LeftPressed
Global RightPressed
Global Pause = 250

sync rate 0
sync on

Do
	GetUserInput()
	UpdateScreen()
	sync
Loop

Function GetUserInput()
	
	if UpKey()
		if Ypos > 1
			if UpPressed
				if Timer() > UpPressed + Pause
					UpPressed = Timer()
					Dec Ypos
				endif
			else
				UpPressed = Timer()		
				Dec Ypos
			endif
		else
			UpPressed = 0
		endif
	endif
	
	if DownKey()
		if Ypos < Height
			if DownPressed
				if Timer() > DownPressed + Pause
					DownPressed = Timer()
					Inc Ypos
				endif
			else
				DownPressed = Timer()		
				Inc Ypos
			endif
		else
			DownPressed = 0
		endif
	endif
	
	if LeftKey()
		if Xpos > 1
			if LeftPressed
				if Timer() > LeftPressed + Pause
					LeftPressed = Timer()
					Dec Xpos
				endif
			else
				LeftPressed = Timer()		
				Dec Xpos
			endif
		else
			LeftPressed = 0
		endif
	endif
	
	if RightKey()
		if Xpos < Width
			if RightPressed
				if Timer() > RightPressed + Pause
					RightPressed = Timer()
					Inc Xpos
				endif
			else
				RightPressed = Timer()		
				Inc Xpos
			endif
		else
			RightPressed = 0
		endif
	endif

endfunction

Function UpdateScreen()
	
	for y = 1 to Height
		for x = 1 to Width
			paste image 3, x * 20, y * 20
		next x
	next y
	paste image 1, Xpos * 20, Ypos * 20
	
endfunction

+ Code Snippet


rem load images
create bitmap 1, 60,60
box 0,0,60,60,Rgb(255,0,0),rgb(0,255,0),rgb(0,0,255),rgb(255,255,0)
get image 1,0,0,20,20
get image 2,20,0,40,20
get image 3,40,0,60,20
delete bitmap 1

Global Width = 14
Global Height = 14
Global Xpos = 1
Global Ypos = 1
Global UpPressed 	
Global DownPressed
Global LeftPressed
Global RightPressed
Global Pause = 250

sync rate 0
sync on

Do
	GetUserInput()
	UpdateScreen()
	sync
Loop

Function GetUserInput()
	
	if UpKey()
		if Ypos > 1
			if UpPressed
				if Timer() > UpPressed + Pause
					UpPressed = Timer()
					Dec Ypos
				endif
			else
				UpPressed = Timer()		
				Dec Ypos
			endif
		else
			UpPressed = 0
		endif
	endif
	
	if DownKey()
		if Ypos < Height
			if DownPressed
				if Timer() > DownPressed + Pause
					DownPressed = Timer()
					Inc Ypos
				endif
			else
				DownPressed = Timer()		
				Inc Ypos
			endif
		else
			DownPressed = 0
		endif
	endif
	
	if LeftKey()
		if Xpos > 1
			if LeftPressed
				if Timer() > LeftPressed + Pause
					LeftPressed = Timer()
					Dec Xpos
				endif
			else
				LeftPressed = Timer()		
				Dec Xpos
			endif
		else
			LeftPressed = 0
		endif
	endif
	
	if RightKey()
		if Xpos < Width
			if RightPressed
				if Timer() > RightPressed + Pause
					RightPressed = Timer()
					Inc Xpos
				endif
			else
				RightPressed = Timer()		
				Inc Xpos
			endif
		else
			RightPressed = 0
		endif
	endif


endfunction

Function UpdateScreen()
	
	for y = 1 to Height
		for x = 1 to Width
			paste image 3, x * 20, y * 20
		next x
	next y
	paste image 1, Xpos * 20, Ypos * 20
	
endfunction

Adjust the PAUSE variable to change the sprites speed in milliseconds.

Back to top

Profile PM Email

Zergei

19

Years of Service

User Offline

Joined: 9th Feb 2005

Location: Everywhere

Posted: 28th Aug 2006 21:44

Link

I know why this is done.
Your checking the array from left to right, up to down. So when you reposition it , say 1 tile lower, on the next loop it will find it there, so it will lower it once again, and then again and again.

How to solve it?... well, i'd do it by, instead of repositioning within the for/next loops, do it outside of it, but you could also exit from the for/next loop once you've done the moving operation. Do it by assigning "f" and "t" their proper max values, like this:

cls

sync rate 60
sync on

rem load images
load bitmap "tiles.bmp",1
get image 1,0,0,20,20
get image 2,20,0,40,20
get image 3,40,0,60,20
delete bitmap 1

width#=14
height#=14

dim grid(width#,height#)

grid(5,0)=1

do

cls

for t=0 to width#
   for f=0 to height#
      if grid(t,f)=1
         paste image 3,t*20,f*20
      endif
      if grid(t,f)=0
         paste image 1,t*20,f*20
      endif
   next f
next t

if downkey()=1
   for t=0 to width#
      for f=0 to height#
         if grid(t,f)=1
            if f<height#
               grid(t,f)=0
               n=f+1
               grid(t,n)=1
               t=width#
               f=height#
            endif
         endif
      next f
   next t
endif

if upkey()=1
   for t=0 to width#
      for f=0 to height#
         if grid(t,f)=1
            if f>0
               grid(t,f)=0
               n=f-1
               grid(t,n)=1
               t=width#
               f=height#
            endif
         endif
      next f
   next t
endif

if leftkey()=1
   for t=0 to width#
      for f=0 to height#
         if grid(t,f)=1
            if t>0
               grid(t,f)=0
               n=t-1
               grid(n,f)=1
               t=width#
               f=height#
            endif
         endif
      next f
   next t
endif

if rightkey()=1
   for t=0 to width#
      for f=0 to height#
         if grid(t,f)=1
            if t<width#
               grid(t,f)=0
               n=t+1
               grid(n,f)=1
               t=width#
               f=height#
            endif
         endif
      next f
   next t
endif

sync

loop

+ Code Snippet

cls

sync rate 60
sync on

rem load images
load bitmap "tiles.bmp",1
get image 1,0,0,20,20
get image 2,20,0,40,20
get image 3,40,0,60,20
delete bitmap 1

width#=14
height#=14

dim grid(width#,height#)

grid(5,0)=1




do

cls

for t=0 to width#
   for f=0 to height#
      if grid(t,f)=1
         paste image 3,t*20,f*20
      endif
      if grid(t,f)=0
         paste image 1,t*20,f*20
      endif
   next f
next t


if downkey()=1
   for t=0 to width#
      for f=0 to height#
         if grid(t,f)=1
            if f<height#
               grid(t,f)=0
               n=f+1
               grid(t,n)=1
               t=width#
               f=height#
            endif
         endif
      next f
   next t
endif

if upkey()=1
   for t=0 to width#
      for f=0 to height#
         if grid(t,f)=1
            if f>0
               grid(t,f)=0
               n=f-1
               grid(t,n)=1
               t=width#
               f=height#
            endif
         endif
      next f
   next t
endif

if leftkey()=1
   for t=0 to width#
      for f=0 to height#
         if grid(t,f)=1
            if t>0
               grid(t,f)=0
               n=t-1
               grid(n,f)=1
               t=width#
               f=height#
            endif
         endif
      next f
   next t
endif

if rightkey()=1
   for t=0 to width#
      for f=0 to height#
         if grid(t,f)=1
            if t<width#
               grid(t,f)=0
               n=t+1
               grid(n,f)=1
               t=width#
               f=height#
            endif
         endif
      next f
   next t
endif

sync

loop

I know that up and right works ok, but it is best to exit the loop, and not make the cpu work needless operations.

Further on my stuff at...

Back to top

Profile PM Email Website

Sorry your browser is not supported!

Newcomers DBPro Corner / DBC detecting when key is no longer being pressed