Labels or functions? - GameCreators Forum

Author

Message

dononeton

20

Years of Service

User Offline

Joined: 12th Jun 2004

Location: Tusaloosa, AL : USA

Posted: 18th Jan 2007 02:09 Edited at: 18th Jan 2007 02:10

Link

Well if I use this code as a function it runs alot slower

+ Code Snippet

function MoveObject()
if mouseclick()=0 then PickObject=0 : MouseOverObject=0
   Mclick=mouseclick()

if Mclick=>0 and PickObject=0 then

MouseOverObject=pick object(mousex(),mousey(),1,handel()-1)

if MouseOverObject>0
   PickObject=Mclick

PickDistance#=get pick distance()
   OPX#=get pick vector x()
   OPY#=get pick vector y()
   OPZ#=get pick vector z()

if PickObject=1
   OOX#=object position x(MouseOverObject)
   OOY#=object position y(MouseOverObject)
   OOZ#=object position z(MouseOverObject)

   endif
endif

if PickObject=1
   pick screen mousex(),mousey(),pickdistance#
   NPX#=get pick vector x()
   NPY#=get pick vector y()
   NPZ#=get pick vector z()

   DPX#=NPX#-OPX#
   DPY#=NPY#-OPY#
   DPZ#=NPZ#-OPZ#

   NOX#=OOX#+DPX#
   NOY#=OOY#+DPY#
   NOZ#=OOZ#+DPZ#

position object MouseOverObject,NOX#,NOY#,NOZ#
endif
endfunction

but if I use it as a label it runs alot faster I am making an error somewhere?

+ Code Snippet

MoveObject:

if mouseclick()=0 then PickObject=0 : MouseOverObject=0
   Mclick=mouseclick()

if Mclick=>0 and PickObject=0 then

MouseOverObject=pick object(mousex(),mousey(),1,handel()-1)

if MouseOverObject>0
   PickObject=Mclick

PickDistance#=get pick distance()
   OPX#=get pick vector x()
   OPY#=get pick vector y()
   OPZ#=get pick vector z()

if PickObject=1
   OOX#=object position x(MouseOverObject)
   OOY#=object position y(MouseOverObject)
   OOZ#=object position z(MouseOverObject)

   endif
endif

if PickObject=1
   pick screen mousex(),mousey(),pickdistance#
   NPX#=get pick vector x()
   NPY#=get pick vector y()
   NPZ#=get pick vector z()

   DPX#=NPX#-OPX#
   DPY#=NPY#-OPY#
   DPZ#=NPZ#-OPZ#

   NOX#=OOX#+DPX#
   NOY#=OOY#+DPY#
   NOZ#=OOZ#+DPZ#

position object MouseOverObject,NOX#,NOY#,NOZ#
endif
return

Back to top

Profile PM Email

IanM

Retired Moderator

22

Years of Service

User Offline

Joined: 11th Sep 2002

Location: In my moon base

Posted: 18th Jan 2007 17:50

Link

No, you're not making an error. When you call a function, any non-global variables that you use within the function will be initialised automatically to zero - this takes a small amount of time for the processor to do, but most of the time, it's not easily measurable.

In your function code, you have 18 variables, so these will be cleared to zero each time. In your subroutine code, you also have 18 variables, but these will not be cleared each time. This may actually cause difficult to find bugs in your code, both because they are not being reset, but also because you may accidentally use those variable names elsewhere in your code.

It's a trade-off you need to make between safety and speed, between 2-3% slower code, or hours extra debugging code that looks perfectly OK but has a problem caused by something in a completely different part of the program. I know which I'd choose - debugging is usually harder than coding.

For free Plug-ins and source code
http://www.matrix1.demon.co.uk
New Utility plugins collection

Back to top

Profile PM Email Website

TDK

Retired Moderator

21

Years of Service

User Offline

Joined: 19th Nov 2002

Location: UK

Posted: 18th Jan 2007 18:33

Link

You might also look at not using mouseclick() in the subroutine either. What you've done suggests to me that you are actually doing it in every subroutine.

I'm not quite sure what you are trying to do in that block of code, but why not read the mouse just once in the main loop?

Rem Main Program Loop
Do
  Mx=MouseX(): My=MouseY(): Mc=MouseClick()
  Gosub MoveObject
  Sync
Loop

MoveObject:
  If Mc=0
    Rem No Mouse Button Currently Being Clicked
    PickObject=0: MouseOverObject=0
  Else
    Rem A Mouse Button Currently Being Clicked
    If PickObject=0 then MouseOverObject = pick object(Mx,My,1,handel()-1)
    If MouseOverObject > 0
      PickObject=Mc
      PickDistance#=get pick distance()
      OPX#=get pick vector x()
      OPY#=get pick vector y()
      OPZ#=get pick vector z()
      If PickObject=1
        OOX#=object position x(MouseOverObject)
        OOY#=object position y(MouseOverObject)
        OOZ#=object position z(MouseOverObject)
        pick screen mousex(),mousey(),pickdistance#
        NPX#=get pick vector x()
        NPY#=get pick vector y()
        NPZ#=get pick vector z()
        DPX#=NPX#-OPX#
        DPY#=NPY#-OPY#
        DPZ#=NPZ#-OPZ#
        NOX#=OOX#+DPX#
        NOY#=OOY#+DPY#
        NOZ#=OOZ#+DPZ#
        position object MouseOverObject,NOX#,NOY#,NOZ#
      Endif
    Endif
  Endif
Return

+ Code Snippet

Rem Main Program Loop
Do
  Mx=MouseX(): My=MouseY(): Mc=MouseClick()
  Gosub MoveObject
  Sync
Loop

MoveObject:
  If Mc=0
    Rem No Mouse Button Currently Being Clicked
    PickObject=0: MouseOverObject=0
  Else
    Rem A Mouse Button Currently Being Clicked
    If PickObject=0 then MouseOverObject = pick object(Mx,My,1,handel()-1)
    If MouseOverObject > 0
      PickObject=Mc
      PickDistance#=get pick distance()
      OPX#=get pick vector x()
      OPY#=get pick vector y()
      OPZ#=get pick vector z()
      If PickObject=1
        OOX#=object position x(MouseOverObject)
        OOY#=object position y(MouseOverObject)
        OOZ#=object position z(MouseOverObject)
        pick screen mousex(),mousey(),pickdistance#
        NPX#=get pick vector x()
        NPY#=get pick vector y()
        NPZ#=get pick vector z()
        DPX#=NPX#-OPX#
        DPY#=NPY#-OPY#
        DPZ#=NPZ#-OPZ#
        NOX#=OOX#+DPX#
        NOY#=OOY#+DPY#
        NOZ#=OOZ#+DPZ#
        position object MouseOverObject,NOX#,NOY#,NOZ#
      Endif
    Endif
  Endif
Return

That snippet probably won't work as you want it to by the way - it's just to demonstrate the principle. You can then use the Mx, My and Mc variables in all procedures in the same way (or pass them to functions).

It should then be a fair bit faster.

TDK_Man

Back to top

Profile PM Email Website

dononeton

20

Years of Service

User Offline

Joined: 12th Jun 2004

Location: Tusaloosa, AL : USA

Posted: 19th Jan 2007 00:59 Edited at: 19th Jan 2007 01:13

Link

Thanks Guys I am still learning so I need to take my variables into consideration when I make my code. Some need to be local and others need to be global

If I make these variables global it works great

+ Code Snippet

global Mclick
global MouseOverObject
global PickObject

@ TDK_Man
Basically when you click on an object and hold the mouse button down you can move it

Back to top

Profile PM Email

TDK

Retired Moderator

21

Years of Service

User Offline

Joined: 19th Nov 2002

Location: UK

Posted: 20th Jan 2007 01:38 Edited at: 20th Jan 2007 01:42

Link

Quote: "Basically when you click on an object and hold the mouse button down you can move it"

Ah OK.

I did this a while ago in the attached program (if it's of any help to you).

TDK_Man

Attachments

Login to view attachments

Back to top

Profile PM Email Website

Sorry your browser is not supported!

Newcomers DBPro Corner / Labels or functions?

Attachments